Feedback to: Textpattern CMS 4.6.0 beta released

philwareham · 2016-06-18 07:29:27

How do you suggest it is improved?

The custom CSS and JS is a non-issue since users that advanced will know how to upgrade without overwriting, they also have the option of renaming those scripts to avoid overwrites happening.

gomedia · 2016-06-18 13:06:16

philwareham wrote #299830:

How do you suggest it is improved?

By having an extra directory to contain custom themes – textpattern/admin-themes-user or textpattern/admin-themes-custom – a directory that TXP checks (in addition to textpattern/admin-themes) when it makes up its list of available admin themes.

This directory would be manually added – i.e. not exist in the TXP distribution, so there is no danger of it being overwritten during an upgrade.

Destry · 2016-06-18 15:39:10

Getting these errors on updating one of my sites…

User_Error "Duplicate entry '1-pane_article_textfilter_help_visible-username' for key 'prefs_idx'"
in /Users/me/Sites/evilplans/textpattern/lib/txplib_db.php at line 405.

And…

textpattern/lib/txplib_misc.php:1677 adminErrorHandler()
updateErrorHandler()
textpattern/lib/txplib_db.php:405 trigger_error()
textpattern/lib/txplib_db.php:455 safe_query()
textpattern/update/_to_4.6.0.php:30 safe_update()
textpattern/update/_update.php:84 include()
textpattern/index.php:180 include()

I can login and it lands me on the Languages panel, where I see these errors at top, but I can’t do anything after that; not update languages, nav to a different panel, etc.

ruud · 2016-06-19 08:57:38

Destry wrote #299835:

Getting these errors on updating one of my sites…

User_Error "Duplicate entry '1-pane_article_textfilter_help_visible-username' for key 'prefs_idx'"...

That’s weird. Is that the exact error message you got or did you replace the actual username and id with 1 and ‘username’ in your post here? Try doing this manually:

safe_update('txp_prefs', "name = 'pane_article_textfilter_help_visible'", "name = 'pane_article_textile_help_visible'");

Just rename the key via PHPmyAdmin.

Bloke · 2016-06-19 18:37:06

gomedia wrote #299827:

By mixing custom files/directories in standard directories it now means that… Steps to upgrade Textpattern will become more complicated

Why? If my existing installation has a (simplified) directory structure:

textpattern
--> config.php
--> admin-themes
----> hive
------> hive.php
------> assets
--------> css
----------> textpattern.css
----------> custom.css
----------> custom.js
----> hiveneutral
------> hiveneutral.php
------> assets
--------> css
----------> textpattern.css
----------> custom.css
----------> custom.js
----> sandspace
------> sandspace.php
------> textpattern.css
...

and my downloaded textpattern package has this structure:

textpattern
--> admin-themes
----> hive
------> hive.php
------> assets
--------> css
----------> textpattern.css
----------> custom-example.css
----> hiveneutral
------> hiveneutral.php
------> assets
--------> css
----------> textpattern.css
----------> custom-example.css
...

when I drag the contents of the latter over the former and I choose to overwrite clashes, anything not in the Txp download package will remain on your disk. It won’t obliterate anything that’s there already. Never has. That’s why your config.php still exists after upgrade. The only way your custom files could be obliterated is if you delete them from your server prior to upgrade; and the instructions don’t say to do that.

Uploading folders and files over existing content will only replace anything that is in the new package. Customisations to non-core files persist. In the example above:

config.php
custom.css
custom.js
sandspace folder

remain untouched by the upload process (unless you have a fundamentally different FTP experience to me with FileZilla, for example?)

That’s why the core supplies files with -example or -dist on the end. So you can rename them and tweak them without fear of them being overwritten in future.

gomedia · 2016-06-19 23:18:48

Bloke wrote #299847:

when I drag the contents of the latter over the former and I choose to overwrite clashes, anything not in the Txp download package will remain on your disk. It won’t obliterate anything that’s there already. Never has.

Dragging a folder on top of another of the same name in Mac Finder replaces the destination folder, i.e. anything not in the new folder disappears.

Besides, as a matter if principle I’d complete separate user-customised folders/files from standard/official folders/files … but maybe that’s just me.

Destry · 2016-06-20 04:48:36

ruud wrote #299837:

That’s weird. Is that the exact error message you got or did you replace the actual username and id with 1 and ‘username’ in your post here?

That’s the exact error, though I did change my username (me) and webapp directory name (evilplans) in the path part.

I don’t have phpMyAdmin locally, so I’ll try doing this on the command line. A first.

phiw13 · 2016-06-20 05:16:08

Destry wrote #299855:

I don’t have phpMyAdmin locally, so I’ll try doing this on the command line. A first.

Sequel Pro is a good front for MYSQL db management on OS X (much friendlier that phpMyAdmin)

jakob · 2016-06-20 05:17:56

Destry wrote #299855:

I don’t have phpMyAdmin locally, so I’ll try doing this on the command line. A first.

If you have Sequel Pro (free) on your Mac, you can simply edit the key name directly in the table. You can run SQL statements in the “Query” pane too, but not php like in Ruud’s example. I was going to say you could also make a temporary page in the relevant txp installation and insert Ruud’s code within a txp:php container but if you can’t use the admin area, that won’t work of course.

Destry · 2016-06-20 05:19:20

Thanks, guys. Installing Sequal Pro now.

Bloke · 2016-06-20 08:41:03

gomedia wrote #299852:

Dragging a folder on top of another of the same name in Mac Finder replaces the destination folder, i.e. anything not in the new folder disappears.

Sure, OSX is an anomaly here, but that’d only really affect MAMP-style installations. I doubt very few run OSX on their web host, so FTPing the files up will do what most people expect: merge.

I’m surprised this hasn’t come up before, because anyone running OSX and upgrading a local MAMP install will trash their config.php. That’s been the same since time immemorial. Presumably, those people that do this employ the workarounds of either holding Option when dragging then selecting Merge, or using the ditto command.

It doesn’t fundamentally alter the way we distribute the software. To “fix” it, any custom configuration — including config.php — would have to reside outside the entire package that you’d download from textpattern.com; i.e. outside docroot. That would probably entail more hoop-jumping during installation, for example:

Copy the contents of the following textarea into a new file config.php. Make sure this is uploaded in a new directory one level above docroot on your server. Name this new directory something suitable and type it in the box below. Each directory must be unique for each instance of Textpattern. This is especially true if you are running more than one installation on the same server. And if you’re running multi-site you’ll need to… oh, crap… what? You’ve overwritten your entire sites folder that contained all your images and files too?!

Yeah, not pretty. But improvements to the way we do things is always welcome if you can suggest something that’d simplify matters.

phiw13 · 2016-06-20 09:04:36

Bloke wrote #299861:

Sure, OSX is an anomaly here, but that’d only really affect MAMP-style installations. I doubt very few run OSX on their web host, so FTPing the files up will do what most people expect: merge.

As I noted earlier, this depends on the configuration of the FTP client. Transmit for instance defaults to “replace” (when uploading folders), but has a “merge” button next to it.

I’m surprised this hasn’t come up before…

you’re not the only one there, to be honest; although I don’t think it is such a problematic issue.

Bloke · 2016-06-20 09:23:00

phiw13 wrote #299862:

Transmit for instance defaults to “replace” (when uploading folders), but has a “merge” button next to it.

I didn’t realise that, thanks for the info and sorry I missed your previous reference. I’m a FileZilla guy and have never ventured further afield.

sacripant · 2016-06-20 11:20:03

Textpattern update is not easy. Sometime dangerous ?

For me, Textpattern update must be more secure and simple.
Txp update need to manually replace files. And yes, some plateformes has different behaviors. personnlay I use bash “cp” command, because in mac with drag and drop, it’s a nightmare.

For me, a list of some difficulties :

Just replace new files directly in FTP in a prod website is not possible, because you don’t now if some plugins are brocken. Allways I make first a update in a local version. I don’t have a test or prod server for small websites.
Nothing help with plugins updates availables for new textpattern version. Textpattern.net is out of date. it is necessary to follow this forum, which is not a good solution.
Textpattern don’t provide a ‘user & role permission’ preferences. Only core solution is to manually modify “admin_config” file. A plugin exist but it is not an official plugin, no garanti. I modified admin_config on some sites, and on each update I must see if I need make a merge
Idem for .htaccess. Sometimes I added some rules.
Be careful not to overwrite “images”, “files” folders and the “config.php” file. Don’t copy setup folder…
I adapt back-office with my own CSS, in each update of theme, I need to manually link theme to ‘my-custom.css’ and patch my code.

I approve the proposal to add a custom-css in the core, it will improve updates and fix a offical way to modifiy admin theme CSS.

But if we could also scripting files update (propose a official bash script, use composer, One-click update button?), add a core preferences panel for “user & permissions” (please), a plugin update alert message. It would be happiness:)

philwareham · 2016-06-20 11:24:15

All this simplified install conversation, whilst interesting, needs to be moved to Textpattern 4.7 target, since a beta is not the place to be making substantial changes to the installation process. Please can someone open an issue for this topic at the repo and I will flag it as 4.7 proposed work, for discussion there.

Please come back on to topic for any problems/bugs specifically related to the beta. Thanks all! :)

Textpattern CMS support forum

#91 2016-06-18 07:29:27

Re: Feedback to: Textpattern CMS 4.6.0 beta released

#92 2016-06-18 13:06:16

Re: Feedback to: Textpattern CMS 4.6.0 beta released

philwareham wrote #299830:

#93 2016-06-18 15:39:10

Re: Feedback to: Textpattern CMS 4.6.0 beta released

#94 2016-06-19 08:57:38

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Destry wrote #299835:

#95 2016-06-19 18:37:06

Re: Feedback to: Textpattern CMS 4.6.0 beta released

gomedia wrote #299827:

#96 2016-06-19 23:18:48

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Bloke wrote #299847:

#97 2016-06-20 04:48:36

Re: Feedback to: Textpattern CMS 4.6.0 beta released

ruud wrote #299837:

#98 2016-06-20 05:16:08

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Destry wrote #299855:

#99 2016-06-20 05:17:56

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Destry wrote #299855:

#100 2016-06-20 05:19:20

Re: Feedback to: Textpattern CMS 4.6.0 beta released

#101 2016-06-20 08:41:03

Re: Feedback to: Textpattern CMS 4.6.0 beta released

gomedia wrote #299852:

#102 2016-06-20 09:04:36

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Bloke wrote #299861:

#103 2016-06-20 09:23:00

Re: Feedback to: Textpattern CMS 4.6.0 beta released

phiw13 wrote #299862:

#104 2016-06-20 11:20:03

Re: Feedback to: Textpattern CMS 4.6.0 beta released

#105 2016-06-20 11:24:15

Re: Feedback to: Textpattern CMS 4.6.0 beta released

Board footer