[plugin] [ORPHAN] ako_write_page_email

akokskis · 2007-04-01 17:11:20

Sorry mate, I’ve tried it on FF 2.0.0.2 on a Mac, and there seems to be no issue.
Check on the plugins page which version of the plugin you’re using. I seem to remember this was an issue that I dealth with going from 0.1->0.2. If you’re not at v0.2, you can get it here

bzx · 2007-04-01 17:52:07

Hey, thanks for checking that

Unfortunately the buttons don’t work for me – I’ve checked IE, Firefox and Opera, and there is a Javascript error in both IE and FF error console (posted before).

I am using IE 6.0, FF 2.0.0.3, Opera 9.03, working with Texpattern 4.0.4, your plugin version 0.2 of course.

I really don’t know what could be the issue, i thought it’s the language version of textpattern, but I have English language installed (using Polish by default.. btw I’m Polish, hence my previous question), and I’ve tried that and it wouldn’t work either.

I’ve also tried turning of some FF plugins with no result, but since I’ve tested it on 3 browsers then the problem is somewhere else..
But I have no clue..

Anyway, thanks for your effort, the plugin is useful without that feature anyway.

Peace
Tom

net-carver · 2007-04-01 19:18:59

bzx wrote:

thanks for a great plugin it works with my 4.0.4 installation however it does NOT insert the link into the body – there is an error on line 11, char 4, “Object doesn’t support this property or method” – I’m not quite sure where’s the problem.

has anyone have similar problem with this ?

Looks like it might be a PHP4 issue … are you running on a PHP4 host?

akokskis · 2007-04-01 19:25:06

net-carver wrote:

Looks like it might be a PHP4 issue … are you running on a PHP4 host?

Honestly, I don’t think so. I’m pretty sure (and I’ve have to check by going through the code) that there’s no OOP code in this plugin. What I think it seems to be is a JavaScript issue, which doesn’t really make too much sense to me, especially if Tom is running Firefox 2.

I’ll try to look into it a bit, but it’s kind of hard to tell (especially not being so hott with JS).

net-carver · 2007-04-01 19:30:31

akokskis wrote:

Honestly, I don’t think so. I’m pretty sure (and I’ve have to check by going through the code) that there’s no OOP code in this plugin. What I think it seems to be is a JavaScript issue, which doesn’t really make too much sense to me, especially if Tom is running Firefox 2.

Oh well, it seemed to remind me of the OOP compatibility problems that cropped up between v4 and v5 of PHP when I’ve worked on other plugins — hence the post.

bzx · 2007-04-01 19:55:48

net-carver wrote:

Looks like it might be a PHP4 issue … are you running on a PHP4 host?

hm.. didn’t think of it, but i don’t think that’s the cause. i can switch between PHP 4 and 5, i’ll see what’s the result and let you know…
just checked – nope, that’s not the issue.

btw. can anyone check if the insert buttons work when you open that link not in popup but in a new tab of firefox ?

peace

akokskis · 2007-04-01 20:16:42

I just tried with a new tab instead of a popup and it didn’t seem to work.
The way the JS works, as I recall, it should only actually work in a popup window, as a new tab is treated by the browser differently than a new poped up window (as in they have different JS variables, etc).
I would think that if you used it as a popup, the insert buttons should work.
Cheers.

bzx · 2007-04-01 21:11:51

Thanks man (that was my mistake, i thoguht i can’t get the console with a popup, but i can.. nevermind..)

anyway here’s the error from the console:
Error: window.opener.edInsertContent is not a function

And i found the error in your plugin code, and i was able to fix it :)
Errors in line 131 and 133, just before the declaration of the function “edInsertContent”:

Not working for me:
if (body) { window.opener.edInsertContent(window.opener.document.getElementById("body"), insert); } else { window.opener.edInsertContent(window.opener.document.getElementById("excerpt"), insert); } }

Working for me:
if (body) { edInsertContent(window.opener.document.getElementById("body"), insert); } else { edInsertContent(window.opener.document.getElementById("excerpt"), insert); } }

I’m sure that I have the latest version of your plugin, but it’s kinda strange that it worked for everyone else but me, even with that strange error – which I can’t tell if the fix is correct because I don’t know JS ;)

Peace

Last edited by bzx (2007-04-01 21:15:34)

bzx · 2007-04-03 22:08:03

no comments ?
ok cool, i’m glad it worked for me.

i also changed the function to have the link displayed under Textile Help, which is quicker than having it all the way down in Advanced.
just replaced “advanced” with “textile_help” in the declaration of ako_write_page_email() (optionally for those with txp 4.0.3 it’s in the function ako_write_page_email_old()).

peace

akokskis · 2007-04-03 22:21:00

Hmmm… haven’t had a chance to look at that change you made – I’ll look at it sometime soon and get back to you.

bzx · 2007-04-04 06:28:35

no probs, i hope it could help someone.
i’ll check here in a few weeks.

peace

masa · 2008-04-02 18:05:55

This used to be a handy little addition for clients, but I’ve just installed it under 4.0.6 and it doesn’t seem to work anymore:

the tag produced shows all special characters converted to html entities, e.g. <txp:email email=" etc. instead of <txp:email email=" and the insert buttons don’t do anything.

The tag builder on the forms page – which this plugin calls upon as far as I understand – works fine.

Any chance for a fix?

Last edited by masa (2008-04-02 18:06:53)

masa · 2009-08-31 18:23:47

Just to bump this up one more time.

I know Adrian isn’t around anymore, but it would be nice if someone could fix this plugin – it would be very useful.
Or if there are other ways allowing clients to easily insert spam-proof email links, I’m all ears.

Last edited by masa (2009-08-31 18:24:44)

TheEric · 2009-08-31 19:48:17

I’m updating this plugin and I’ll take it over. It’s a rather basic rewrite.

masa · 2009-09-01 17:27:51

Thanks, Eric.

I was hoping it would be simple.

Textpattern CMS

Textpattern CMS support forum

#16 2007-04-01 17:11:20

Re: [plugin] [ORPHAN] ako_write_page_email

#17 2007-04-01 17:52:07

Re: [plugin] [ORPHAN] ako_write_page_email

#18 2007-04-01 19:18:59

Re: [plugin] [ORPHAN] ako_write_page_email

#19 2007-04-01 19:25:06

Re: [plugin] [ORPHAN] ako_write_page_email

#20 2007-04-01 19:30:31

Re: [plugin] [ORPHAN] ako_write_page_email

#21 2007-04-01 19:55:48

Re: [plugin] [ORPHAN] ako_write_page_email

#22 2007-04-01 20:16:42

Re: [plugin] [ORPHAN] ako_write_page_email

#23 2007-04-01 21:11:51

Re: [plugin] [ORPHAN] ako_write_page_email

#24 2007-04-03 22:08:03

Re: [plugin] [ORPHAN] ako_write_page_email

#25 2007-04-03 22:21:00

Re: [plugin] [ORPHAN] ako_write_page_email

#26 2007-04-04 06:28:35

Re: [plugin] [ORPHAN] ako_write_page_email

#27 2008-04-02 18:05:55

Re: [plugin] [ORPHAN] ako_write_page_email

#28 2009-08-31 18:23:47

Re: [plugin] [ORPHAN] ako_write_page_email

#29 2009-08-31 19:48:17

Re: [plugin] [ORPHAN] ako_write_page_email

#30 2009-09-01 17:27:51

Re: [plugin] [ORPHAN] ako_write_page_email

Board footer