Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

MattD · 2009-08-24 23:40:26

johnstephens wrote:

…with the “DST enabled” radio button incorrectly set to “Yes” and grayed out, setting my timestamps one hour ahead.

DST should be set to Yes until November 1st in the US

Looks like wet has a potential fix.

Last edited by MattD (2009-08-24 23:42:00)

johnstephens · 2009-08-25 04:31:25

Oops. DST never made sense to me— that’s why I immediately enabled auto-DST in Textpattern, and didn’t look at what it was doing.

Last edited by johnstephens (2009-08-25 05:55:20)

wet · 2009-08-25 04:35:51

Anyone running 4.2.0 RC1 with time zone / DST issues in the “Preferences” tab please update /textpattern/lib/txplib_misc.php to at least r3271. Report any persisting DST / time zone issues subsequently.

johnstephens · 2009-08-25 05:53:45

r3271 fixes this behavior on both servers— all I had to do was disable Auto-DST, and re-enable it.

Cheers!

Last edited by johnstephens (2009-08-25 05:53:59)

graumeister · 2009-08-25 10:25:46

@Ruud: :D no, I talk about calling a tag that is not existent. In this case a tag <txp:gho_comment_num />delivered by a plug-in without the function gho_comment_num actually being defined. That tag is in a form ;)

Leonick · 2009-08-25 12:13:11

Because i’m tracking all scripts errors, with error_reporting(E_ALL) I have this error :

[8] ob_end_clean() [<a href=‘ref.outcontrol’>ref.outcontrol</a>]: failed to delete buffer. No buffer to delete. on line 1768 on file /…/textpattern/lib/txplib_misc.php

to resolve this, on handle_lastmod function i’ve modified while (ob_end_clean()); with while (ob_get_length()>0)ob_end_clean();

maverick · 2009-08-25 14:47:57

Wet

My apologies – due to a crazy schedule, I never followed up on your attempted fix for my post here.

It was the same problem DST issue reported by MattD and JohnStephens, and r33271 seems to fix the one install I had time to update and check.

Thanks

Mike

dl33 · 2009-08-25 23:02:24

Works very well up to now. The only question I have is whether it makes sense to share user accounts between the different sites when using the multiple sites feature? Is it possible to create a link between the two user tables?

maniqui · 2009-08-25 23:04:52

Could this be a bug?
<txp:if_article_id> on article list context is not being evaluated

Thanks.

maniqui · 2009-08-26 00:18:53

Well, let me add to the confussion:
<txp:if_article_list> inside <txp:article_custom /> always return true

Last edited by maniqui (2009-08-26 00:19:29)

hoho · 2009-09-04 16:22:05

maniqui wrote:

Could this be a bug?
<txp:if_article_id> on article list context is not being evaluated

I definitely consider it a bug. :) However, it was all the same in previous versions, 4.0.8 at least, and the code of this tag suggests this behaviour is on purpose.

Anyway, I would really like to see this element to evaluate to false instead of being dropped in article list context. It would be more intuitive and more convenient for typical use, imho. There is no reason this tag’s functionality should overlap with that of if_individual_article.

I’m going to replace lines 1477-1480 of publish/taghandler.php as follows:

return parse(EvalElse($thing, $id and in_list($thisarticle['thisid'], $id)));

Last edited by hoho (2009-09-04 19:16:20)

ruud · 2009-09-04 16:29:51

^^ submit a patch to the devs!

hoho · 2009-09-05 15:40:23

Patch submitted. I just had to think more thoroughly about it to base my argumentation on more solid basics than ‘intuition’. :) Here’s the core.

As far as I can tell, the if_article_id tag is the only TXP tag that
differentiates between a single article context and an article list context
in the sense that the tag does something in one context and does absolutely
nothing in the other.

Moreover, the tag is unique :) among other conditional TXP tags: it is the
only conditional tag that can evaluate neither clause without reporting an
error. Indeed, I haven’t seen such an if-statement in any other programming
language. :)

Having said all this, I would recommend changing semantics of the
if_article_id tag so that the condition evaluates to false if no value of
the ‘id’ can be determined. That’s exactly what the patch does.

The other option – reporting an error – would introduce a new type of error
in TXP which is not desirable in terms of simplicity of the overall
semantics, is it?

P.S. The change is not backward-compatible but if you think it through,
casulties should be rather limited – it should affect only the unlikely
(imho) cases when one uses an else-clause while relying on the fact that
the tag is ignored in an article list context.

Last edited by hoho (2009-09-06 21:29:01)

Walker · 2009-09-06 16:00:08

Setting up multi-site manager on Media Temple’s Grid Server.

Last edited by Walker (2009-09-06 17:02:12)

sarah · 2009-09-19 22:26:42

Hi, I’ve just upgraded to the new textpattern version.

However, I’ve noticed that there is absolutely no colour in the background, unlike version 4.0.8. Why is that?

Thanks!

Textpattern CMS

Textpattern CMS support forum

#136 2009-08-24 23:40:26

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#137 2009-08-25 04:31:25

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#138 2009-08-25 04:35:51

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#139 2009-08-25 05:53:45

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#140 2009-08-25 10:25:46

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#141 2009-08-25 12:13:11

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#142 2009-08-25 14:47:57

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#143 2009-08-25 23:02:24

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#144 2009-08-25 23:04:52

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#145 2009-08-26 00:18:53

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#146 2009-09-04 16:22:05

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#147 2009-09-04 16:29:51

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#148 2009-09-05 15:40:23

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#149 2009-09-06 16:00:08

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

#150 2009-09-19 22:26:42

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Board footer