Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Improving...
MattD wrote:
Didn’t the version of jquery change between those versions? Maybe just a jquery upgrade will make it work.
Maybe. Keith, do you see the “reply” link but it doesn’t work?
Offline
Re: Improving...
saccade wrote:
- When posted the final message is on an empty pane. For me it would be much more comfortable to get back to the comments catalogue again.
Yes. This is part of the “more polished” sentence :-)
- Just an idea: If your task is to answer lots of comments (e.g. when they are mostly questions, regarding an event or a product) it seems to me a little complicated, going through the edit-procedure. What I think of instead: Couldn’t an additional column be placed in the comments catalogue, with an input-textfield for each comment in which you could write your answer and post them all (means: all filled) by one single “post”-button? (But this may likely be impossible, because it interferes closely with the generating of the comments catalogue).
Yes, it’s more difficult, but I think this use has some interaction problems: input field too narrow, impossible preview, …
Offline
Re: Improving...
juanjonavarro wrote:
Maybe. Keith, do you see the “reply” link but it doesn’t work?
Yes, that’s the situation, Juanjo – but JQuery wasn’t bundled with 4.0.4 and although I’ve added it to my install, maybe I’ve got an older version of the script.
I’ll check that out, but don’t worry, I don’t mind if this doesn’t work on the 4.0.4 install…
Keith
Blyth, Northumberland, England
Capture The Moment
Offline
Re: Improving...
jQuery is only used for the “animation” effect (the reply form is hidden and is displayed using jQuery). It’s easy to modify if you need it. Just let me know if you need a modified version without jQuery.
Offline
Re: Improving...
Oh, bless your heart that’s kind of you!
Keith
Blyth, Northumberland, England
Capture The Moment
Offline
Re: Improving...
Ok. The “polished” version here
(“human” texts, go to the comments list after replying, it should work in 4.0.4)
What do you think?
Offline
Re: Improving...
Excellent, Juanjo – perfectly implemented (no “Preview” needed for the Admin!) and fully functional, even in 4.0.4.
The only improvement I can think of is that Admin comment responses via the plugin could be “auto-approved” and go straight to publication on submit.
Keith
Blyth, Northumberland, England
Capture The Moment
Offline
Re: Improving...
juanjonavarro wrote:
Ok. The “polished” version here
Really good job juanjonavarro. Some thoughts:
- Remember to escape the insert queries. Currently the web, email and name…
- Maybe you don’t need to define globals for every page when they don’t do anything. Actually you don’t even need them for anything, because the code always calls the function directly (or could).
- The
txp_discuss.phpinclude is not required if you just point the form to the comment edit page with correct inputs.
keith wrote:
The only improvement I can think of is that Admin comment responses via the plugin could be “auto-approved” and go straight to publication on submit.
The plugin should set visiblity automatically to 1.
Offline
Re: Improving...
keith wrote:
The only improvement I can think of is that Admin comment responses via the plugin could be “auto-approved” and go straight to publication on submit.
It’s already working this way! :-)
Offline
Re: Improving...
Doh!
I just assumed that I still needed to approve my post (I didn’t even look at the comment status when I was messing around), but you’re absolutely right!
Excellent work, Juanjo – this is going to make a lot of people very happy..!
Keith
Blyth, Northumberland, England
Capture The Moment
Offline
Re: Improving...
Gocom wrote:
Remember to escape the insert queries. Currently the web, email and name…
Ok.
Maybe you don’t need to define globals for every page when they don’t do anything. Actually you don’t even need them for anything, because the code always calls the function directly (or could).
Globals? What do you mean?
The
txp_discuss.phpinclude is not required if you just point the form to the comment edit page with correct inputs.
Using a “Location” Header? The problem is that I cannot send the confirmation message to be printed using a redirect. Do I?
Offline
Re: Improving...
juanjonavarro wrote:
Globals? What do you mean?
$textarrray. You could either define it inside the function (not outside of it) or then by just tranfering the form data with post from preview to submit ect. Currently the global is defined for whole backend.
juanjonavarro wrote:
Using a “Location” Header? The problem is that I cannot send the confirmation message to be printed using a redirect. Do I?
Well you could redirect, but not required. You only need to send the form to the correct page – for example to the same comment edit dialog was used to write the comment.
Yes, you can’t use pagetop() nor the inbuild message system. But you could use own message that is shown somewhere alongside the form content, for example. Not as fancy tho.
Offline
Re: Improving...
Gocom wrote:
$textarrray. You could either define it inside the function (not outside of it) or then by just tranfering the form data with post from preview to submit ect. Currently the global is defined for whole backend.
$textarray is the array of “literals” of textpattern. I’m just defining new literals so I can use them later with gTxt. I define them at the top so:
- It’s easier to translate it to your language when you install de plugin.
- Can be modified later by another plugin . I think I saw a plugin that let you modify these literals.
Well you could redirect, but not required. You only need to send the form to the correct page – for example to the same comment edit dialog was used to write the comment.
Yes, you can’t usepagetop()nor the inbuild message system. But you could use own message that is shown somewhere alongside the form content, for example. Not as fancy tho.
The problem is that I want to show the messages list after submit. And the message list function is not defined because we are not in the discuss “event”, so the txp_discuss.php (where it is defined) is not included by textpattern. That’s why I include the file here, so I can call discuss_list().
Offline
Re: Improving...
Here is the 0.3 version (first public version) and individual thread: jnm_reply_comments
Offline