Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2019-12-24 07:30:28

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,493
Website

Re: Feedback to: Textpattern CMS 4.8.0-beta released

Something else, for discussion, the theme panel, name column

If a site has only one (1) theme installed, should the “Assign sections” link and the “in use” note be actually displayed? Or should these be suppressed in this case? It looks kinda weird now, and a bit pointless.

And I don’t think a Section can exist without a theme assigned.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#26 2019-12-24 09:07:46

etc
Developer
Registered: 2010-11-11
Posts: 4,529
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

Ah, I see. <txp:header value="application/xml; charset=utf-8" /> is missing name attribute, it must be

<txp:header name="Content-Type" value="application/xml; charset=utf-8" />

I will revert name to 4.7-default Content-Type, sorry for the hassle.

Offline

#27 2019-12-24 11:56:38

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,538
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

phiw13 wrote #320685:

If a site has only one (1) theme installed, should the “Assign sections” link and the “in use” note be actually displayed?… I don’t think a Section can exist without a theme assigned.

True at the moment. But see this thread on article snippets for a possible future in which sections may be themeless. Then marking them up this way makes sense.

But if we decide not to pursue this way of working then maybe yes we could hide the pills and (perhaps) link. Will give it some thought.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#28 2019-12-24 13:29:05

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,679
GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

I’m curious about the 502 errors, I’ll investigate that – thanks for the heads up.

Offline

#29 2019-12-24 13:33:15

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,679
GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

colak wrote #320681:

Accessing beta-demo.textpattern.co/index.php?s=sitemap returns a 502 error.

I can replicate this. Here’s the error in the Nginx log:

2019/12/24 13:31:55 [error] 14090#14090: *9004 upstream sent invalid status "application/xml; charset=utf-8" while reading response header from upstream, client: [IPv4 address], server: beta-demo.textpattern.co, request: "GET /index.php?s=sitemap HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm.sock:", host: "beta-demo.textpattern.co"

Investigating…

Offline

#30 2019-12-24 13:36:33

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,679
GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

etc wrote #320689:

Ah, I see. <txp:header value="application/xml; charset=utf-8" /> is missing name attribute, it must be […]

Confirming this fixes the 502 on the beta site.

Offline

#31 2019-12-24 15:26:43

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,753
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.8.0-beta released

with the name attribute, all is working just fine.


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#32 2019-12-24 22:06:35

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,493
Website

Re: Feedback to: Textpattern CMS 4.8.0-beta released

Yes adding the name attribute makes all working fine. I didn’t know you had changed that.

And OK I see you reverted that requirement. That is probably better for backwards compatibility. I’ll still make it a habit to add the name attribute.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#33 2019-12-24 23:09:19

Myusername
Member
Registered: 2019-12-12
Posts: 141

Re: Feedback to: Textpattern CMS 4.8.0-beta released

colak wrote #320694:

with the name attribute, all is working just fine.

True, just use the name attribute that is working. It would be interesting to update the Textpattern documentation header, using examples with the name attribute(since without it does not work). Just a suggestion.

Offline

#34 2019-12-25 07:20:46

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,493
Website

Re: Feedback to: Textpattern CMS 4.8.0-beta released

Bloke wrote #320690:

True at the moment. But see this thread on article snippets for a possible future in which sections may be themeless. Then marking them up this way makes sense.

But if we decide not to pursue this way of working then maybe yes we could hide the pills and (perhaps) link. Will give it some thought.

I’ve now read partly through that thread, with some difficult but interesting concepts. In case you do introduce and use themeless sections, then yes, it probably makes sense, given how it now works, to keep the link (assign sections) next to the theme name. Not sure I fully understand those themeless sections ATM, but will keep reading.

The “pill” note (“in use”) might still be redundant, though ?


Where is that emoji for a solar powered submarine when you need it ?

Offline

#35 2019-12-25 14:24:36

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,538
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

phiw13 wrote #320701:

Not sure I fully understand those themeless sections ATM, but will keep reading.

Nothing’s decided yet but it’s just a notion whereby you could house unpublished content that you can call into other articles. Such sections could act as silos for content snippets – events, profiles, whatever – that you don’t have to relegate to forms (which are presentation not content) nor have to risk having a discoverable URL.

If a section has no theme, it has no output, therefore the content wouldn’t appear on your site or navigation unless you explicitly ask your templates to grab it as part of other articles in other sections.

The “pill” note (“in use”) might still be redundant, though ?

Yes. We could perhaps hide this if there’s only one theme installed.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#36 2019-12-25 15:56:27

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,538
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta released

Bloke wrote #320707:

We could perhaps hide this [in-use pill] if there’s only one theme installed.

Done.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB