upm_img_popper

Mary · 2005-10-13 20:14:05

Hey guys, just letting you know I’ll look at these problems shortly.

Mary · 2005-10-13 21:42:22

v.0.8.9.

Anyone using any version prior to 0.8.3 should update, and also read the info posted on how to fix the “division by zero” error.

juani81 · 2005-10-13 22:32:50

Im using v.0.8.9
When I use the type “popup” and I assign a class, it is assigned to the <code><a></code> tag instead of assign it to the <code><img></code> tag. There’s a solution for this? Thanks in advance!

Last edited by juani81 (2005-10-13 22:34:32)

Mary · 2005-10-13 22:33:45

That’s what it’s supposed to do.

juani81 · 2005-10-13 22:36:04

So i can’t assign a class to <code><img></code>?

juani81 · 2005-10-13 22:44:28

Perhaps I don’t explained it very well…

I have this: <code><txp:upm_image type=“popup” image_id=“4” class=“right borde” /></code>

The result is this: <code><a href=“http://www.someserver.com/images/4.jpg” class=“right” onclick=“return upm_pop_img(this.href, ‘492’, ‘369’, ‘Leo’, this.title);”><img src=“http://www.someserver.com/images/4t.jpg” width=“200” height=“150” alt=“Leo” title=”“ /></a></code> (look were it’s the class)

And I want this: <code><a href=“http://www.someserver.com/images/4.jpg” onclick=“return upm_pop_img(this.href, ‘492’, ‘369’, ‘Leo’, this.title);”><img src=“http://www.someserver.com/images/4t.jpg” width=“200” height=“150” alt=“Leo” title=”“ class=“right” /></a></code>

Thanks for the quick answer!

Last edited by juani81 (2005-10-13 22:46:24)

Mary · 2005-10-13 22:44:48

You can, if it isn’t wrapped in a tag. If you want to style the image itself, but its wrapped in a link or other html tag, then in your stylesheet you’d do (as an example):

<code>.the-class img {
border: none;
}</code>

Edit: woo, posted twenty seconds later… for your example, you’d do:

<code>.right img {
border: none;
}</code>

Last edited by Mary (2005-10-13 22:47:07)

juani81 · 2005-10-13 22:47:38

Well im going to do it like that…. Thank you very much for the answer!

wet · 2005-10-14 07:27:39

support request

I can’t get upm_image to react on the url attribute the way it is defined in the help text:
<blockquote>url=“webpage url”: Website url to make the image link to</blockquote>

I’ve include this in an article:

<txp:upm_image image_id="24" type="thumbnail" url="#" />

The generated markup looks like that:

<img src="http://www.example.com/images/24t.jpg" alt="Sample" height="65" width="90">

No <a> tag, to no avail. A glimpse into the source shows no obvious signs of the url attribute ever being used apart from line 1528 which seems to be run whenever upm_image is embracing a $thing. But that $url is set in line #1519 and from my point of view redefines the value for url passed via attributes.

I’m quite sure that this used to work with some earlier version (0.6?) .

feature request

Would it be feasible to change the url attribute to have the image link to an article with the id given in url if url is numeric?

Last edited by wet (2005-10-14 07:33:58)

colak · 2005-10-14 15:31:11

Hi Mary
Further to my bug report <a href=“http://forum.textpattern.com/viewtopic.php?pid=80807#p80807”>here</a> just to let you know that the Insert Image link only appears when in “use textile” mode

Last edited by colak (2005-10-14 15:31:53)

Mary · 2005-10-15 06:57:32

colak: The problems you’re having with the latest dev revision are due to the recent changes with Textile. Easily fixed, but I can’t roll that in to the plugin yet because the changes are incompatible. You can easily change this for yourself though. Make sure you have the latest version of the plugin. Find line #502, and change the number ‘2’ to the the number ‘1’.

Robert: Thanks for catching that, it should work properly now. I also added it to the form tags, and rolled in your feature request. Let me know if you have futher problems.

:)

colak · 2005-10-15 07:49:58

> mary wrote:

> colak: The problems you’re having with the latest dev revision are due to the recent changes with Textile. Easily fixed, but I can’t roll that in to the plugin yet because the changes are incompatible. You can easily change this for yourself though. Make sure you have the latest version of the plugin. Find line #502, and change the number ‘2’ to the the number ‘1’.

Hi Mary… Did it and seems that the plugin is back in wonderfully working mode.
A small thing…
What I have changed is the 2 on line #227 not on line #502. Where the script sais <code>$txt = ($use_textile == 2) ? gTxt(‘textile_help’) : gTxt(‘advanced_options’);</code>

Last edited by colak (2005-10-15 07:50:16)

Mary · 2005-10-15 07:54:56

Oh sorry, I keep forgetting that… that’s the line number it is in its original php file. Glad you can compensate for my lousy directions. ;D

wet · 2005-10-22 18:27:57

Hi,

I’ve jsut noticed one mismatch between help text and actual behaviour of upm_article_image:

When type="popup" then class is not attributed to the img but to the a tag. IMO, it should behave consistently and apply the supplied class name to img.

//w&

Mary · 2005-10-23 00:31:45

That was done on purpose, otherwise you cannot style the link itself, this way you can do either/both.

Textpattern CMS

Textpattern CMS support forum

#391 2005-10-13 20:14:05

Re: upm_img_popper

#392 2005-10-13 21:42:22

Re: upm_img_popper

#393 2005-10-13 22:32:50

Re: upm_img_popper

#394 2005-10-13 22:33:45

Re: upm_img_popper

#395 2005-10-13 22:36:04

Re: upm_img_popper

#396 2005-10-13 22:44:28

Re: upm_img_popper

#397 2005-10-13 22:44:48

Re: upm_img_popper

#398 2005-10-13 22:47:38

Re: upm_img_popper

#399 2005-10-14 07:27:39

Re: upm_img_popper

support request

feature request

#400 2005-10-14 15:31:11

Re: upm_img_popper

#401 2005-10-15 06:57:32

Re: upm_img_popper

#402 2005-10-15 07:49:58

Re: upm_img_popper

#403 2005-10-15 07:54:56

Re: upm_img_popper

#404 2005-10-22 18:27:57

Re: upm_img_popper

#405 2005-10-23 00:31:45

Re: upm_img_popper

Board footer