Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#136 2005-06-14 16:41:50
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
You must update to a higher revision.
“New in v.0.6.1: Teensy update as per revision 403”
Offline
#137 2005-06-14 18:03:56
Re: upm_img_popper
will 0.6.1 work with whtever version is available on the main page? What versions should we upgrade to with this plugin before have to update txp as well from the front page release? all the svn business and it’s benefits are bit above me:)
Offline
#138 2005-06-14 18:21:40
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
The version available from deanload (which, co-incidentally I can’t get at right now) is RC3. Not sure which revision, but it was a while back. Rev 403 or greater is needed.
For the sake of the masses, I’ll upload a second version, which will have all the features of the current one, but will work with that release available from deanload. I won’t be making this second version after this, as I want to encourage upgrading and I don’t want to support older versions indefinitely. :)
I’m off to do this, I’ll post back when its available.
Last edited by Mary (2005-06-14 18:22:07)
Offline
#139 2005-06-14 18:37:54
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
Posted.
Offline
#140 2005-06-14 18:43:11
- EddieG5
- Member
- From: Georgia
- Registered: 2004-03-03
- Posts: 96
Re: upm_img_popper
Mary … this is wonderful. Thanks for making this available to us!
Offline
#141 2005-06-17 02:15:50
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
Bug fix release.
Offline
#142 2005-06-17 23:34:03
Re: upm_img_popper
Um…. installed plugin. Went to extensions and set things and when I click on the Insert Image link I get a popup that says I have no images. When in fact, I do have some… any thoughts?
To even the least of these…
Offline
#143 2005-06-18 02:08:56
Re: upm_img_popper
> jbrew wrote:
> Um…. installed plugin. Went to extensions and set things and when I click on the Insert Image link I get a popup that says I have no images. When in fact, I do have some… any thoughts?
I’m seeing the same problem; tried it for both 0.6.2-old.txt version and 0.6.2.txt with updated TXP code.
Rolling back to 0.2.txt sees my images however.
one thing strange i saw with a cursory glance on line 463, there’s no ‘and’ after $cirteria
<code>
$rs = safe_rows_start(“*”, “txp_image”, “$criteria ext in(‘.gif’,’.jpg’,’.png’) order by $sort_sql limit $offset, $limit”);
</code>
adding the and didn’t seem to fix thing thou I had high hopes.
TV? Buglight for humans.
Offline
#144 2005-06-18 03:06:40
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
Whoops. Sorry ‘bout that folks. I’ve updated the plugin, is everything working correctly now?
“old” and the other one is are exactly the same. One won’t show you thumbnails, the other will, depending on how old your copy of Textpattern is. That’s the only difference.
Offline
#145 2005-06-18 03:41:28
Re: upm_img_popper
Yes it is working now!!! This is sweet! Thank you….
To even the least of these…
Offline
#146 2005-06-18 15:51:43
Re: upm_img_popper
Mary does the article image output the full image or the thumbnail image if used? Can it be optioned with thumbnail?
Thanks
Offline
#147 2005-06-18 21:47:05
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
Yes. Read the help.
Offline
#148 2005-06-24 17:28:08
Re: upm_img_popper
Mary, many thanks – this is a great job done.
I just wonder whether there could be any better way of solving the i18n issue, since right now the plugin code has to be edited within Textpattern to change language strings. I think a starting point solution could be e.g. to check whether a selected lang string is already set (so lang files get precedence), and add the lang strings into the help text (displayed in lang/* file format), so that translators could copy&paste them into those files.
Anyway, kudos to you.
Premek
Offline
#149 2005-06-24 19:57:00
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: upm_img_popper
This was discussed.
Lang files already get precedence.
There could be problems with modifying those files, for one thing: if you upgrade you have to redo it again anyway, no time has been saved. Keeping it within the plugin means that you’ll know exactly where to go to translate, rather than sift through a lang file.
Not shutting you down here, I am just waiting for a built-in method for translating plugins. Maybe a plugin lang table or something.
Offline
#150 2005-06-24 23:01:51
Re: upm_img_popper
> mary wrote:
> This was discussed.
OK, didn’t know about that thread, thanks. Waiting for a global strategy is of course a good choice.
> Lang files already get precedence.
I may be missing something here but they didn’t, for me (using version 0.6.2 and cs-cz locale). Only when I added if (gTxt($what) != $what) return gTxt($what); at the start of the upm_img_popper_gTxt() function, the lang file strings kicked in.
Premek
Offline