adi_file_tab - Enhanced file tab

gomedia · 2020-09-04 00:48:38

GugUser wrote #325774:

I am very grateful that you are updating your plug-ins.

My pleasure! I’ll get to them all … eventually.

gomedia · 2021-05-24 06:57:36

Version 0.5 ready:

- fix: minor layout issue (Safari)
- fix: filename language string
- fix: event registration

phiw13 · 2021-05-24 08:08:11

I regret to say, but after installing or updating on TXP 4.8.5 + 4.8.6 running on PHP 8.0.x gives the following unholly message, and nothing is displayed :-(

(when accessing the file tab for an individual file)

Fatal error: Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, null given in /home/user/test.local/textpattern/plugins/adi_file_tab/adi_file_tab.php:902 
Stack trace: 
#0 /home/user/test.local/textpattern/lib/txplib_misc.php(1578): adi_file_tab_edit_script('admin_side', 'body_end') 
#1 /home/user/test.local/textpattern/lib/txplib_html.php(48): callback_event('admin_side', 'body_end') 
#2 /home/user/test.local/textpattern/index.php(233): end_page() 
#3 {main} thrown in /home/user/test.local/textpattern/plugins/adi_file_tab/adi_file_tab.php on line 902

gomedia · 2021-05-24 08:50:32

phiw13 wrote #330243:

I regret to say …

Try this one

phiw13 · 2021-05-24 09:18:00

gomedia wrote #330245:

Try this one

At least on the localhost test site, this one installs and displays fine (and works fine too, needles to add…).

Thank you.

Testing on the live server will have to wait, time to start preparing some dinner, this side of the moon.

phiw13 · 2021-05-25 01:01:34

So here is another issue: when you edit any of a file’s metadata (e.g. “Title” field or “Publish date” field) and then save you don’t return to the file listing panel. After several tries, I noticed that after clicking “Save” you return briefly to the list panel and then immediately go back to the edit panel.

BTW, in the stylesheet for the plugin, you have this: div.posted-now input { margin-left:50%}. You can delete this as the default Textpattern admin theme already handles this; that is what the .txp-form-field-shim class is for.

gomedia · 2021-05-25 06:38:04

phiw13 wrote #330247:

So here is another issue: when you edit any of a file’s metadata (e.g. “Title” field or “Publish date” field) and then save you don’t return to the file listing panel.

It’s always done it … well since v0.4 anyway, but rather unhelpfully I didn’t document it anywhere. It’s something I do in adi_image_tab – the idea being to match what happens when an article is saved (i.e. don’t return to article list) as I think it’s a more logical workflow. If adi_link_tab existed I’d do the same.

Having said that, I’m a benevolent dictator, so do you want an option to switch it off?

BTW, in the stylesheet for the plugin, you have this: div.posted-now input { margin-left:50%}. You can delete this as the default Textpattern admin theme already handles this; that is what the .txp-form-field-shim class is for.

It’s still required for 4.7 backward compatibility but I’ll fix it for 4.8 thanks. Funny, I saw the odd checkbox positioning before but the neurons didn’t fire.

phiw13 · 2021-05-25 09:13:43

gomedia wrote #330249:

It’s always done it …

Is it ? I don’t remember ever noticing it. My bad.

The way I see it, those edit panels are similar to dialog boxes in many applications where you input or edit some kind of data and then press “save” (OK, …), the dialog then closes.

Having said that, I’m a benevolent dictator, so do you want an option to switch it off?

Well, allow me to be a benevolent dictator as well, but from the user’s side… I’d be quite happy with an option to return to the default Textpattern behaviour… No hurry of course!

GugUser · 2021-05-25 11:49:58

gomedia wrote #330245:

Try this one

Many thanks for keeping some of your plug-ins up to date.

gomedia · 2021-05-26 06:21:35

phiw13 wrote #330250:

I’d be quite happy with an option to return to the default Textpattern behaviour… No hurry of course!

Strike while the iron’s hot … could you try this and let me know if it’s OK? Thanks.

phiw13 · 2021-05-26 08:42:26

gomedia wrote #330260:

Strike while the iron’s hot … could you try this and let me know if it’s OK? Thanks.

Hot! works great thank you.

GugUser · 2021-05-26 23:09:09

Textpack for German:

#@owner gomedia
#@language de
#@admin-side
adi_admin_privs => Admin privileges:
adi_auto_update_filename => Dateiname automatisch aktualisieren
adi_copy_filename_title => Aus Dateiname kopieren
adi_copy_title_description => Aus Titel kopieren
adi_copy_update_filename_uploaded => Dateiname der hochgeladenen Datei übernehmen?
adi_delete_file => Datei löschen
adi_file_details => Angaben zur Datei
adi_file_exists_dir => Datei {name} ist in {dir} schon vorhanden
file_name => Dateiname
adi_file_rename_fail => Die Datei konnte nicht umbenannt werden
adi_file_renamed => Datei umbenannt
adi_file_replaced => Datei ersetzt
adi_file_tab_admin => Datei Voreinstellungen
adi_file_tab_confirm_update_filename => Den Dateinamen aktualisieren?
adi_file_tab_exclude_filter => Dateinamen ausschliessen
adi_file_tab_no_unlinked => Keine unverknüpften Dateien verfügbar
adi_file_tab_replace_default => Den Namen der ausgewählten Datei standardmässig ersetzen?
adi_file_updated => Datei aktualisiert
adi_filter_add => Füge Filter
adi_filter_edit => Filter hinzufügen
adi_filtered => Gefiltert
adi_name_is_dir => {name} ist ein Verzeichnis
adi_plugin_privs => Rechte für das Plug-In:
adi_rename => Umbenennen
adi_rename_file => Datei umbenennen
adi_replace_from_existing => Von der existierenden Datei ersetzen
adi_reset_downloads => Download-Zähler zurücksetzen
adi_std_admin_behaviour => Standardverhalten der Administrationsoberfläche?
adi_textpack_fail => Textpack-Installation fehlgeschlagen
adi_textpack_feedback => Textpack-Feedback
adi_textpack_online => Textpack ist auch online verfügbar
adi_timestamp_invalid => Ungültige Zeitangabe
adi_unfiltered => Ungefiltert
adi_update_filename => Dateiname aktualisieren
adi_update_prefs => Voreinstellungen aktualisieren

Textpattern CMS

Textpattern CMS support forum

#25 2020-09-04 00:48:38

Re: adi_file_tab - Enhanced file tab

GugUser wrote #325774:

#26 2021-05-24 06:57:36

Re: adi_file_tab - Enhanced file tab

#27 2021-05-24 08:08:11

Re: adi_file_tab - Enhanced file tab

#28 2021-05-24 08:50:32

Re: adi_file_tab - Enhanced file tab

phiw13 wrote #330243:

#29 2021-05-24 09:18:00

Re: adi_file_tab - Enhanced file tab

gomedia wrote #330245:

#30 2021-05-25 01:01:34

Re: adi_file_tab - Enhanced file tab

#31 2021-05-25 06:38:04

Re: adi_file_tab - Enhanced file tab

phiw13 wrote #330247:

#32 2021-05-25 09:13:43

Re: adi_file_tab - Enhanced file tab

gomedia wrote #330249:

#33 2021-05-25 11:49:58

Re: adi_file_tab - Enhanced file tab

gomedia wrote #330245:

#34 2021-05-26 06:21:35

Re: adi_file_tab - Enhanced file tab

phiw13 wrote #330250:

#35 2021-05-26 08:42:26

Re: adi_file_tab - Enhanced file tab

gomedia wrote #330260:

#36 2021-05-26 23:09:09

Re: adi_file_tab - Enhanced file tab

Board footer