adi_file_tab - Enhanced file tab

GugUser · 2016-06-14 13:02:26

Hi geomedia

Thanks for the beta. In a few trials it seems to work.

But, the positions of the buttons are distributed ugly (Safari 9.1.1).

Furthermore I couldn’t figure out for what I can use “Replace from existing file”. In my experiment I reached no result.

Many thanks for your work.

gomedia · 2016-06-14 13:36:24

GugUser wrote #299728:

Hi geomedia

Thanks for the beta. In a few trials it seems to work. But, the positions of the buttons are distributed ugly (Safari 9.1.1).

I don’t do anything with the Upload button – it’s in its standard position.
The Replace file button is being nudged by, what looks like, a very long filename. I’ll sort something out for that.
The Delete button looks fine on my Safari (9.0.2), so not sure what’s going on there. I’ll look into it.

Furthermore I couldn’t figure out for what I can use “Replace from existing file”. In my experiment I reached no result.

It’s analogous with the Upload existing file functionality on the File list tab, but instead you can use an existing file to replace one you’ve already uploaded.

Many thanks for your work.

Thanks for testing it! I’ll send you another beta.

GugUser · 2016-06-14 14:15:58

gomedia wrote #299733:

I don’t do anything with the Upload button – it’s in its standard position.

In the earlier adi_file_tab-0.2 version, all the buttons were aligned right.

The Replace file button is being nudged by, what looks like, a very long filename. I’ll sort something out for that.

Oh yes, but now the space below between the button and the line is better, it looks good.

It would look better if “Delete file” and the delete button were on the same line.

“Replace from existing file” for me doesn’t work. I don’t know what I’m doing wrong (MAMP, PHP 7).

gomedia · 2016-06-15 00:12:53

GugUser wrote #299734:

In the earlier adi_file_tab-0.2 version, all the buttons were aligned right.

adi_file_tab doesn’t mess with the Upload button – in previous plugin/TXP releases it was aligned right by default, but now it isn’t. I’ll see what fiddling can be done.

It would look better if “Delete file” and the delete button were on the same line.

Can’t reproduce this – it looks fine on my Safari, Firefox, Chrome.

“Replace from existing file” for me doesn’t work. I don’t know what I’m doing wrong (MAMP, PHP 7).

It works for me, what are the symptoms?

I’ll send you another update.

GugUser · 2016-06-15 04:47:36

Thank you for the newest version. I tried it in Safari, Chrome and Firefox, all in newest versions, with MAMP, PHP 7.

In Safari the “Replace from existing file” confirms “file replaced” but does nothing, in Chrome and Firefox it works as expected.

In all the three browsers “Delete file” and the delete button are still in two different lines. It’s not a browser caching issue because in Chrome and Firefox was the first try. It’s not essential and it’s not my intention to criticize your work, it’s just an observation. At the moment I haven’t the time to analyze why is this so, maybe on Thursday, sorry.

All the buttons are now aligned on the right side, I like that.

Thanks for the time you are giving for all users of this plugin.

gomedia · 2016-06-16 04:05:48

GugUser wrote #299745:

Thank you for the newest version. I tried it in Safari, Chrome and Firefox, all in newest versions, with MAMP, PHP 7.

In Safari the “Replace from existing file” confirms “file replaced” but does nothing, in Chrome and Firefox it works as expected.

Weird.

In all the three browsers “Delete file” and the delete button are still in two different lines. It’s not a browser caching issue because in Chrome and Firefox was the first try. It’s not essential and it’s not my intention to criticize your work, it’s just an observation. At the moment I haven’t the time to analyze why is this so, maybe on Thursday, sorry.

Weird #2.

Constructive criticism & bug finding always appreciated.

All the buttons are now aligned on the right side, I like that.

Good.

Thanks for the time you are giving for all users of this plugin.

No problem. I think I’ll release it “as is” & hopefully somewhere/someone along the way might get to the bottom of the niggles.

gomedia · 2016-06-21 01:56:40

Version 0.3 now available for download:

updated for TXP 4.6 (many thanks to GugUser for assistance)
enhancement: author edit (4.5.7+ only)

gomedia · 2020-09-02 22:39:33

Version 0.4 – updated for TXP 4.7+ – now available for download.

GugUser · 2020-09-03 22:13:49

I am very grateful that you are updating your plug-ins.

gomedia · 2020-09-04 00:48:38

GugUser wrote #325774:

I am very grateful that you are updating your plug-ins.

My pleasure! I’ll get to them all … eventually.

gomedia · 2021-05-24 06:57:36

Version 0.5 ready:

- fix: minor layout issue (Safari)
- fix: filename language string
- fix: event registration

phiw13 · 2021-05-24 08:08:11

I regret to say, but after installing or updating on TXP 4.8.5 + 4.8.6 running on PHP 8.0.x gives the following unholly message, and nothing is displayed :-(

(when accessing the file tab for an individual file)

Fatal error: Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, null given in /home/user/test.local/textpattern/plugins/adi_file_tab/adi_file_tab.php:902 
Stack trace: 
#0 /home/user/test.local/textpattern/lib/txplib_misc.php(1578): adi_file_tab_edit_script('admin_side', 'body_end') 
#1 /home/user/test.local/textpattern/lib/txplib_html.php(48): callback_event('admin_side', 'body_end') 
#2 /home/user/test.local/textpattern/index.php(233): end_page() 
#3 {main} thrown in /home/user/test.local/textpattern/plugins/adi_file_tab/adi_file_tab.php on line 902

gomedia · 2021-05-24 08:50:32

phiw13 wrote #330243:

I regret to say …

Try this one

phiw13 · 2021-05-24 09:18:00

gomedia wrote #330245:

Try this one

At least on the localhost test site, this one installs and displays fine (and works fine too, needles to add…).

Thank you.

Testing on the live server will have to wait, time to start preparing some dinner, this side of the moon.

phiw13 · 2021-05-25 01:01:34

So here is another issue: when you edit any of a file’s metadata (e.g. “Title” field or “Publish date” field) and then save you don’t return to the file listing panel. After several tries, I noticed that after clicking “Save” you return briefly to the list panel and then immediately go back to the edit panel.

BTW, in the stylesheet for the plugin, you have this: div.posted-now input { margin-left:50%}. You can delete this as the default Textpattern admin theme already handles this; that is what the .txp-form-field-shim class is for.

Textpattern CMS

Textpattern CMS support forum

#16 2016-06-14 13:02:26

Re: adi_file_tab - Enhanced file tab

#17 2016-06-14 13:36:24

Re: adi_file_tab - Enhanced file tab

GugUser wrote #299728:

#18 2016-06-14 14:15:58

Re: adi_file_tab - Enhanced file tab

gomedia wrote #299733:

#19 2016-06-15 00:12:53

Re: adi_file_tab - Enhanced file tab

GugUser wrote #299734:

#20 2016-06-15 04:47:36

Re: adi_file_tab - Enhanced file tab

#21 2016-06-16 04:05:48

Re: adi_file_tab - Enhanced file tab

GugUser wrote #299745:

#22 2016-06-21 01:56:40

Re: adi_file_tab - Enhanced file tab

#23 2020-09-02 22:39:33

Re: adi_file_tab - Enhanced file tab

#24 2020-09-03 22:13:49

Re: adi_file_tab - Enhanced file tab

#25 2020-09-04 00:48:38

Re: adi_file_tab - Enhanced file tab

GugUser wrote #325774:

#26 2021-05-24 06:57:36

Re: adi_file_tab - Enhanced file tab

#27 2021-05-24 08:08:11

Re: adi_file_tab - Enhanced file tab

#28 2021-05-24 08:50:32

Re: adi_file_tab - Enhanced file tab

phiw13 wrote #330243:

#29 2021-05-24 09:18:00

Re: adi_file_tab - Enhanced file tab

gomedia wrote #330245:

#30 2021-05-25 01:01:34

Re: adi_file_tab - Enhanced file tab

Board footer