Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2020-12-02 09:51:18

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,470
Website

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

For one site, I uploaded just index.php, css.php and the textpattern folder and all seems fine. Unusually, there is now an In use pill next to just one form. The only other place In use is to be found is where I’d expect it, in Themes.


BB6 Band My band
Gud One My blog

Offline

#14 2020-12-02 09:57:36

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,215
GitHub

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

michaelkpate wrote #327174:

P.S. And for outpacing the competition.

In fairness, they have a lot more code to check.

Offline

#15 2020-12-02 14:54:21

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,413
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

zero wrote #327196:

there is now an In use pill next to just one form.

If you’ve assigned that form to an article (as an override form) then that’s why you’ll see the notification. It’s just an indicator to warn that if you try to delete the form, the article will lose its assignment.

But note that you can now choose to alter the Override from the Forms panel and reassign any selected assets that were using it to a different form. It only affects articles that were assigned to the selected form(s).

Side note: forgot to list that feature in HISTORY.txt. We should probably add it for completeness.

Last edited by Bloke (2020-12-02 14:55:12)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#16 2020-12-02 17:21:15

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,470
Website

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

Bloke wrote #327205:

If you’ve assigned that form to an article (as an override form) then that’s why you’ll see the notification. It’s just an indicator to warn that if you try to delete the form, the article will lose its assignment.

But note that you can now choose to alter the Override from the Forms panel and reassign any selected assets that were using it to a different form. It only affects articles that were assigned to the selected form(s).

Aah! That explains it. Thanks Stef, nice to know. Another great release, btw. Thanks, team txp!


BB6 Band My band
Gud One My blog

Offline

#17 2020-12-07 08:14:52

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,064
Website GitHub Mastodon Twitter

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

When going through the process of clean installing this version on DH, txp asked me to copy paste the following on config.php file:

<?php
$txpcfg['db'] = 'db';
$txpcfg['user'] = 'user';
$txpcfg['pass'] = 'pass';
$txpcfg['host'] = 'host';
$txpcfg['table_prefix'] = 'c_';
$txpcfg['txpath'] = '/path/to/textpattern';
$txpcfg['dbcharset'] = 'utf8mb4';
define('PROTOCOL', 'https://');

The closing php tag (?>) was missing.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#18 2020-12-07 08:19:34

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,215
GitHub

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

I also spotted the omitted ?>. It validates on a PHP linter, and it works, so I didn’t give it further thought. I assumed there was a good reason for it, though I don’t know what.

Offline

#19 2020-12-07 08:27:51

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,413
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

colak wrote #327311:

The closing php tag (?>) was missing.

By design. When we tell people to add stuff to the end of the config.php file, we don’t need to say “before the closing ?> mark”, which is less confusing overall. And with the ability to add CSP stuff to the config file from 4.9.0, more people may be doing so.

They’re optional in PHP since a long time ago.

Last edited by Bloke (2020-12-07 08:55:37)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#20 2020-12-07 09:26:36

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,626
GitHub Twitter

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

… In order to prevent errors if a line break is present after the closing ?> tag.


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#21 2020-12-07 17:51:53

bici
Member
From: vancouver
Registered: 2004-02-24
Posts: 2,087
Website Mastodon

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

since Christ was a baby my config file has had the opening and closing tags:

<?php
$txpcfg['db'] = 'foods_txp';
$txpcfg['user'] = '******';
$txpcfg['pass'] = '******';
$txpcfg['host'] = 'localhost';
$txpcfg['table_prefix'] = '';
$txpcfg['txpath'] = '/home/me/apex/stuff_app/textpattern';
$txpcfg['dbcharset'] = 'utf8';
define('PROTOCOL', 'https://');
?>

i never noticed that the config-dist.php files that comes with the distribution did NOT have a closing tag:

?>

If i recall when we install textpattern are we not given the config..php file to replace the one that came with the distribution ? which has the closing tag?

EDIT: obfuscated your user/pass.


…. texted postive

Offline

#22 2020-12-07 18:03:39

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,702
Website

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

It doesn’t matter if it does or doesn’t have a closing tag, so both should work.


TXP Builders – finely-crafted code, design and txp

Offline

#23 2020-12-07 18:10:28

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,215
GitHub

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

bici wrote #327336:

If i recall when we install textpattern are we not given the config..php file to replace the one that came with the distribution ? which has the closing tag?

The config-dist.php is an example of what can be done, not necessarily would should be done, and your own site/server setup will have its own settings.

The config.php is not included so if you merge the new release into your site, it won’t nuke any config.php, though if you go full bore and overwrite /textpattern it will probably zap your config anyway, and a restore from backup will be needed.

Offline

#24 2020-12-10 19:03:01

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 305
Website GitHub Twitter

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

Updated all five sites from 4.8.3 to 4.8.4. No big problems yet. Recognized only, that the notice A new Textpattern version (4.8.4) has been installed. came up only in English.

I also switched from php 7.4.13 to php 8.0.0 and linked to that I got some errors in two plugins.

Fatal error: Array and string offset access syntax with curly braces is no longer supported

This problem I could solve by replacing these curly braces {} with square brackets [].

Despite of that I got a few warnings.

etc_pagination
<txp:etc_pagination range="5" prev="<" next=">" wraptag="" break="" pgcounter="pg" current="here" /> -> Warning: Undefined array key 1

smd_thumbnail
<txp:smd_thumbnail_info type='128px' item='w' /> -> Textpattern Notice: Unbekanntes Tag-Attribut: type.

aks_article
Warning: Undefined array key "aks_article_scope"
Warning: Trying to access array offset on value of type null
both in
textpattern/plugins/aks_article/aks_article.php:40 aks_article_doArticles()

But all plugins seem to work, as they should.

Textpattern version: 4.8.4 (b1d8d97c3c8ac6238394682e3c76a8d6)
Last update: 2020-12-10 16:51:47/2020-11-29 15:45:21
Textpattern path: __TXP-ROOT/textpattern
Article URL pattern: title_only
Production status: live
Temporary directory path: __TXP-ROOT/textpattern/tmp
PHP version: 8.0.0
GD Graphics Library: 2.2.5; Supported formats: GIF, JPEG, PNG, WebP.
Server timezone: Europe/Berlin
Server local time: 2020-12-10 19:49:08
Daylight Saving Time enabled?: 0
Automatically adjust Daylight Saving Time setting?: 1
Time zone (GMT offset in seconds): Europe/Berlin (3600)
MySQL: 5.5.5-10.5.8-MariaDB-1:10.5.8+maria~buster-log (mariadb.org binary distribution) 
Database server time: 2020-12-10 19:49:08
Database server time offset: 0 s
Database server timezone: SYSTEM
Database session timezone: SYSTEM
Locale: de_DE.UTF-8
Site / Admin language: de / de
Web server: nginx/1.18.0
PHP server API: fpm-fcgi
RFC 2616 headers: 0
Server OS: Linux 4.19.0
Admin-side theme: hive 4.8.4
Active plugins: 
	adi_gps-0.4
	aks_cache-0.3d
	aks_header-0.4.1
	arc_twitter-4.5.0 (modified)
	com_connect-4.6.0
	css_rating-0.1b
	etc_cache-0.2.4
	etc_pagination-0.4.7b
	ied_plugin_composer-1.2.1
	jnm_no_reset_time-0.1
	pap_comconnect-0.1.2
	peg_nested_comments-0.2.5
	smd_textile_bar-0.1.1
	smd_thumbnail-0.6.1
	the_video-0.8
	tru_tags-3.9.2 (modified)
	wcz_utf8_url-0.1.6

Update

Logging in in Debug mode, brings up a lot of warnings for values from txp_pref:

Warning "Undefined array key "max_custom_fields""
in /var/www/ahrens/textpattern/vendors/Textpattern/DB/Core.php at line 245.

textpattern/vendors/Textpattern/DB/Core.php:245 adminErrorHandler()
textpattern/include/txp_auth.php:342 Textpattern\DB\Core->checkPrefsIntegrity()
textpattern/include/txp_auth.php:50 doTxpValidate()
textpattern/index.php:150 doAuth()

Warning "Undefined array key "ied_plugin_editor""
in /var/www/ahrens/textpattern/vendors/Textpattern/DB/Core.php at line 245.

textpattern/vendors/Textpattern/DB/Core.php:245 adminErrorHandler()
textpattern/include/txp_auth.php:342 Textpattern\DB\Core->checkPrefsIntegrity()
textpattern/include/txp_auth.php:50 doTxpValidate()
textpattern/index.php:150 doAuth()

.....

Last edited by whocarez (2020-12-10 20:53:00)

Offline

Board footer

Powered by FluxBB