Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

gaekwad · 2020-11-29 16:25:31

Please provide any feedback here related to Textpattern CMS 4.8.4 released: PHP 8.0 compatible.

We appreciate all feedback. Please check the issue queue before raising a problem.

Destry · 2020-11-29 19:23:17

All good here with three installs updated. One (CSF) was a jump from 4.7.0. Funny how fast you forget about those once-upon-a-timers.

Destry · 2020-11-29 19:45:17

Spoke to soon. When logged out, my custom error page used in conjuction with rvm_maintenance says it lost contact with two forms…

Tag error: <txp:output_form form="tmpl_meta" /> ->  Textpattern Notice: Form not found. .tmpl_meta while parsing form None on page default

textpattern/lib/txplib_misc.php:3240 trigger_error()
textpattern/lib/txplib_misc.php:3270 fetch_form()
textpattern/publish/taghandlers.php:538 parse_form()
output_form()
textpattern/vendors/Textpattern/Tag/Registry.php:139 call_user_func()
textpattern/lib/txplib_publish.php:543 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:403 processTags()
textpattern/lib/txplib_misc.php:4311 parse()
textpattern/plugins/rvm_maintenance/rvm_maintenance.php:16 txp_die()
textpattern/lib/txplib_misc.php:1535 rvm_maintenance()

Tag error: <txp:output_form form="tmpl_tete_default" /> ->  Textpattern Notice: Form not found. .tmpl_tete_default while parsing form None on page default

textpattern/lib/txplib_misc.php:3240 trigger_error()
textpattern/lib/txplib_misc.php:3270 fetch_form()
textpattern/publish/taghandlers.php:538 parse_form()
output_form()
textpattern/vendors/Textpattern/Tag/Registry.php:139 call_user_func()
textpattern/lib/txplib_publish.php:543 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:403 processTags()
textpattern/lib/txplib_misc.php:4311 parse()
textpattern/plugins/rvm_maintenance/rvm_maintenance.php:16 txp_die()
textpattern/lib/txplib_misc.php:1535 rvm_maintenance()

But the forms are there and nothing changed from before.

I’m not worried about this too much because I think I’m going to nix using the plugin anyway, but just to mention.

Last edited by Destry (2020-11-30 00:47:59)

bici · 2020-11-30 01:08:48

updated 5 sites in less than an hour without a hitch. Smooth sailings. Many Thanks to the Devs! Fine work.

( Should the instructions on updating have a word about the Themes folders. I was using a theme which was over-written when i installed the new version. i simply overwrote the RPC and THEMES folders. which borked my site. of course i had a backup and re-installed the themes)

gaekwad · 2020-11-30 06:06:33

Destry wrote #327157:

Spoke to soon. When logged out, my custom error page used in conjuction with rvm_maintenance says it lost contact with two forms…

Tag error: <txp:output_form form="tmpl_meta" /> -> Textpattern Notice: Form not found. .tmpl_meta while parsing form None on page default...

Is it normal to have the form name prepended with . in the latter part of the message?

phiw13 · 2020-11-30 07:00:54

bici wrote #327158:

( Should the instructions on updating have a word about the Themes folders. I was using a theme which was over-written when i installed the new version. i simply overwrote the RPC and THEMES folders. which borked my site. of course i had a backup and re-installed the themes)

Me thinks a small note may be recommended. If you update from a previous TXP version there is absolutely no need to re-upload the themes folder (the RPC is ambiguous). Similarly, the textpattern/plugins folder does not need to be replaced, as it contains all install plugins. This one is less damaging, as the contents will be re-populated at first login, but at a minimum it is a waste of electricity…

Destry · 2020-11-30 08:34:01

gaekwad wrote #327160:

Is it normal to have the form name prepended with . in the latter part of the message?

Don’t know, but the forms are not named that way.

philwareham · 2020-11-30 08:34:49

phiw13 wrote #327162:

Me thinks a small note may be recommended.

I’ve just noted this in the repo, for future upgrades. Thanks all.

jakob · 2020-11-30 11:28:01

Cool! Big thanks to all concerned and must try out PHP 8 soon. Is there a good overview anywhere of what’s new?

gaekwad · 2020-11-30 14:38:12

jakob wrote #327169:

Cool! Big thanks to all concerned and must try out PHP 8 soon. Is there a good overview anywhere of what’s new?

wiki.php.net/rfc#php_80
stitcher.io/blog/new-in-php-8

michaelkpate · 2020-11-30 16:20:33

Congrats to the Dev Team for moving us into the future.

P.S. And for outpacing the competition.

phiw13 · 2020-12-01 03:13:15

philwareham wrote #327165:

I’ve just noted this in the repo, for future upgrades. Thanks all.

Thanks for that. How about textpattern/plugins? The contents is regenerated on first login (all or only active plugins? not sure) but the user could have deleted a plugin, but left the Delete from disk too checkbox unchecked, to keep the plugin for later use.

zero · 2020-12-02 09:51:18

For one site, I uploaded just index.php, css.php and the textpattern folder and all seems fine. Unusually, there is now an In use pill next to just one form. The only other place In use is to be found is where I’d expect it, in Themes.

gaekwad · 2020-12-02 09:57:36

michaelkpate wrote #327174:

P.S. And for outpacing the competition.

In fairness, they have a lot more code to check.

Bloke · 2020-12-02 14:54:21

zero wrote #327196:

there is now an In use pill next to just one form.

If you’ve assigned that form to an article (as an override form) then that’s why you’ll see the notification. It’s just an indicator to warn that if you try to delete the form, the article will lose its assignment.

But note that you can now choose to alter the Override from the Forms panel and reassign any selected assets that were using it to a different form. It only affects articles that were assigned to the selected form(s).

Side note: forgot to list that feature in HISTORY.txt. We should probably add it for completeness.

Last edited by Bloke (2020-12-02 14:55:12)

Textpattern CMS support forum

#1 2020-11-29 16:25:31