adi_mobile - Mobile browser detection

detail · 2018-06-14 05:59:40

Thanks Adi

That makes sense even to me. The joys of being entirely self-taught.

I think I spotted another plugin with a similar issue so I can update that one as well, accordingly.

You can tell I prefer content creation to the backend stuff.

Have you thought of writing haikus?

detail · 2018-06-17 19:40:07

gomedia wrote #312560:

I haven’t updated the plugin for the new tag registry. The workaround is to edit it and insert the following at the top somewhere:

Thanks so much Adi. That works a treat.

Sorry I took so long to reply. Been, umm, distracted.

gomedia · 2018-06-17 22:37:24

No need to worry
So glad that it is working
Talk another time

colak · 2020-08-07 07:26:08

Hi Adi, I have only just started using this plugin as a replacement to act_if_mobile. It appears that there is an issue when using it with txp 4.8.2, as it always returns 1. I disabled pat_speeder on the home page in order for you to easily see the output.

My default template can be found here
The source of our home page shows where the adi_mobile breaks on lines 11, 22.

> 2nd edit to add that I have tried this using php7, 7.2, and 7.4

Last edited by colak (2020-08-07 07:46:08)

gomedia · 2020-08-07 07:55:27

Hi Yiannis,

I haven’t got adi_mobile running on anything beyond 4.7 (yes, I know, people tell me I’m old school). However, it being a public-side plugin … in principle nothing should break (unless it’s a PHP problem).

From your template I can see that with <txp:adi_mobile include="tablet" /> you’re bundling mobiles & tablets together – i.e. <txp:adi_if_mobile> is true for both.

Not sure which lines 11, 22 I’m looking at … are there error messages or is <txp:adi_if_mobile> not doing the true/false thing properly?

colak · 2020-08-07 08:09:45

Hi Adi, Line 11 in the source code corresponds to these lines in the template and line 22 corresponds to this one.

I agree with you that the plugin should not have been broken but I have no idea why both yours and act_if_mobile return identical results.

> Edited to clarify. If you visit NeMe’s home page, and view the source, I am referring to the lines 11 and 22 there.

Last edited by colak (2020-08-07 08:18:15)

gomedia · 2020-08-07 08:21:22

Can you elaborate on “identical results”? What device is not being detected correctly?

You could try debug="1" on <txp:adi_mobile /> to see if that splurges out anything incriminating.

etc · 2020-08-07 08:36:32

The guilty is certainly the recent EvalElse() function (deprecated since txp 4.6) bug, sorry. I will take a look, but you should replace

parse(EvalElse($thing, $condition));

with

parse($thing, $condition);

colak · 2020-08-07 08:50:45

Thanks so much guys. I think that Oleg’s suggestion worked. At least on my desktop.

gomedia · 2020-08-07 08:57:53

etc wrote #325219:

The guilty is certainly the recent EvalElse() function bug …

And there was I thinking I only need to wade through all my admin plugins to bring them up to speed :-(

etc · 2020-08-07 09:58:47

gomedia wrote #325221:

And there was I thinking I only need to wade through all my admin plugins to bring them up to speed :-(

I’m the first annoyed, since many old plugins will break, unless we quickly release 4.8.3… sorry! :-(

colak · 2020-08-07 10:14:42

etc wrote #325222:

I’m the first annoyed, since many old plugins will break, unless we quickly release 4.8.3… sorry! :-(

If EvalElse is deprecated, it makes more sense for plugins to be updated. This one was easy to do. I’m sure that the rest will not be that hard either.

Prolonging the life of deprecated functions will make txp harder to control. I can understand, supporting some functions for a few years but 4.6 was released 4 years ago!

It is strange that neither this, or act_if_mobile plugins returned no errors until this morning. I’ll investigate my server logs to check if I have missed anything.

Textpattern CMS

Textpattern CMS support forum

#61 2018-06-14 05:59:40

Re: adi_mobile - Mobile browser detection

#62 2018-06-17 19:40:07

Re: adi_mobile - Mobile browser detection

gomedia wrote #312560:

#63 2018-06-17 22:37:24

Re: adi_mobile - Mobile browser detection

#64 2020-08-07 07:26:08

Re: adi_mobile - Mobile browser detection

#65 2020-08-07 07:55:27

Re: adi_mobile - Mobile browser detection

#66 2020-08-07 08:09:45

Re: adi_mobile - Mobile browser detection

#67 2020-08-07 08:21:22

Re: adi_mobile - Mobile browser detection

#68 2020-08-07 08:36:32

Re: adi_mobile - Mobile browser detection

#69 2020-08-07 08:50:45

Re: adi_mobile - Mobile browser detection

#70 2020-08-07 08:57:53

Re: adi_mobile - Mobile browser detection

etc wrote #325219:

#71 2020-08-07 09:58:47

Re: adi_mobile - Mobile browser detection

gomedia wrote #325221:

#72 2020-08-07 10:14:42

Re: adi_mobile - Mobile browser detection

etc wrote #325222:

Board footer