Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#85 2020-05-20 08:32:17

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: [feedback] Image upload directly in the write tab

Bloke wrote #323049:

Oleg assured me it was when I wondered why the page was doing some odd pausing/scrolling thing. He gave a compelling argument, but I’ve not tried it without.

That was just a convenience for drag-drop testing, otherwise textareas can get out of the viewport when scrolling. Then I’ve got used to it :-)

Offline

#86 2020-05-20 08:39:30

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: [feedback] Image upload directly in the write tab

etc wrote #323052:

convenience

aha… problem solved, as in not needed ?

Then I’ve got used to it :-)

/hive/assets/css/custom.css ? ;-)


Where is that emoji for a solar powered submarine when you need it ?

Offline

#87 2020-05-20 09:22:10

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: [feedback] Image upload directly in the write tab

phiw13 wrote #323053:

aha… problem solved, as in not needed ?

Not really, try displaying 96 images in the sidebar and dragging one from the bottom of the list to drop it on Body.

Offline

#88 2020-05-20 10:05:41

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: [feedback] Image upload directly in the write tab

etc wrote #323055:

Not really, try displaying 96 images in the sidebar and dragging one from the bottom of the list to drop it on Body.

Admittedly that is not something I tried, nor did it occur to me to try to squeeze that many images into the widget (and more, I was mostly testing on an iPad, drag and drop does not seem to work all that well with touch devices).


Where is that emoji for a solar powered submarine when you need it ?

Offline

#89 2020-05-21 08:27:35

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: [feedback] Image upload directly in the write tab

BTW, a bit of a problematic behaviour: if you add/upload a larger image (one that exceeds the max limit set in prefs), and save, you get a message that the (article) has been successfully saved, but the image is not added to the article image field (collection). The image is of course not uploaded. If you do the same from the Images panel, you get an angry (red) message spanking you for trying to upload something so large.

The point here is that there is, from the plugin side, absolutely no feedback on the problem.

(I am testing this with the latest version of smd_thumbnail, which process images uploaded via the Write panel according to its profiles).


Where is that emoji for a solar powered submarine when you need it ?

Offline

#90 2020-05-21 09:38:34

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: [feedback] Image upload directly in the write tab

FWIW, this plugin was written before 4.7 file upload enhancements, so it does not use new core widgets. Actually it should, but this requires some textpattern.js modifications and probably more wide core revisions. I wouldn’t expect it before 4.9.

Meanwhile, we can add a warning when a file exceeds the pref limit, but the problem will remain the same when the image’s size is lower than pref but higher than php limits.

Offline

#91 2020-05-21 10:05:44

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: [feedback] Image upload directly in the write tab

etc wrote #323087:

FWIW, this plugin was written before 4.7 file upload enhancements, so it does not use new core widgets.

aah, OK, that explains that behaviour. If it were possible to issue some kind of warning to the user that would be lovely, though.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#92 2020-05-21 11:45:30

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: [feedback] Image upload directly in the write tab

phiw13 wrote #323088:

If it were possible to issue some kind of warning to the user that would be lovely, though.

Pull request sent, awaiting commit done.

Offline

#93 2020-05-21 11:52:41

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,224
Website GitHub

Re: [feedback] Image upload directly in the write tab

Oh that’s sweet, Oleg, thanks!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#94 2020-05-21 11:58:13

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,224
Website GitHub

Re: [feedback] Image upload directly in the write tab

I see some sneaky paginator code commented out too… could that be a way to scoot through and locate more than the most recent N images until we get round to factoring in image search?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#95 2020-05-21 12:14:24

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: [feedback] Image upload directly in the write tab

There was another out-commented code appending an <iframe /> from Image tab. It provides the whole search/paginate functionality and I think that’s the most economic way. But it requires some css/js guru to squeeze the whole page into the sidebar.

Offline

#96 2020-05-22 08:28:18

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: [feedback] Image upload directly in the write tab

etc wrote #323089:

Pull request sent, awaiting commit done.

Lovely, Thanks.


Where is that emoji for a solar powered submarine when you need it ?

Offline

Board footer

Powered by FluxBB