[feedback] Image upload directly in the write tab

SuMu · 2012-12-03 06:16:13

Hello all!

Upload the images directly in the write tab (either as a article image or just positioned left, right, center) would necessarily have to be integrated into Textpattern.

This is the biggest weakness compared to WordPress!

Is this planned?

Last edited by SuMu (2012-12-03 06:42:21)

philwareham · 2012-12-03 09:31:42

Yes it’s planned at some point in the future.

First we will be working on a grid display view for images, then investigating modal (popup) boxes for edit screens. If that goes well then it would hopefully be easier to integrate images into the write screen.

SuMu · 2012-12-03 10:43:46

Hach Thanks :-) I will wait

gour · 2013-01-18 15:14:57

philwareham wrote:

Yes it’s planned at some point in the future.

4.6?

It would/will be great feature.

uli · 2013-01-18 15:37:35

gour, have you discovered bot_image_upload yet? The current, most popular, plugin solution. Used with abl_droploader, it really makes uploading images a breeze. Yes, in the Write panel.

gour · 2013-01-18 20:22:41

uli wrote:

gour, have you discovered bot_image_upload yet?

No, not at all.

The current, most popular, plugin solution. Used with abl_droploader, it really makes uploading images a breeze. Yes, in the Write panel.

I must admit I’m a bit overwhelmed with Textpattern…it feels really great and very capable to solve all my present and future web needs, but, otoh, it is definitely a bit different from everything I’ve seen so far (I must say that Tiki is also unusual CMS which I still evaluate along with Textpattern), so I need some time to connect missing pieces to (better) understand how everything works. :-)

While being engaged with it, I just wonder if there are some projects for which it’s not recommended to use Textpattern? (FAQ says that practically everything is possible, but still wonder is something is recommended ‘no’.)

colak · 2013-01-19 16:09:47

gour wrote:

While being engaged with it, I just wonder if there are some projects for which it’s not recommended to use Textpattern? (FAQ says that practically everything is possible, but still wonder is something is recommended ‘no’.)

I’m sure that txp may be inappropriate for some sites (none come to mind). From your initial post here, all can be done. As your requirements grow nevertheless, a wall will eventually appear. That’s where the plugins come in.

gour · 2013-01-19 20:34:55

colak wrote:

I’m sure that txp may be inappropriate for some sites (none come to mind). From your initial post here, all can be done.

Good…let me try to realize something.

etc · 2016-05-11 13:38:36

I’m experimenting with FormData submit. As a byproduct, uploading images (or files) from Write tab is a few-liner plugin. If somebody wants to test:

# Name: abc_article_image v0.3 
# Type: Admin/AJAX plugin
# 
# Author: 
# URL: 
# Recommended load order: 5

# .....................................................................
# This is a plugin for Textpattern CMS - http://textpattern.com/
# To install: textpattern > admin > plugins
# Paste the following text into the 'Install plugin' box:
# .....................................................................

YToxMTp7czo0OiJuYW1lIjtzOjE3OiJhYmNfYXJ0aWNsZV9pbWFnZSI7czo2OiJhdXRob3Ii
O3M6MDoiIjtzOjEwOiJhdXRob3JfdXJpIjtzOjA6IiI7czo3OiJ2ZXJzaW9uIjtzOjM6IjAu
MyI7czoxMToiZGVzY3JpcHRpb24iO3M6MDoiIjtzOjQ6ImNvZGUiO3M6NDc1MzoiaWYoaGFz
X3ByaXZzKCdpbWFnZS5lZGl0Lm93bicpKQ0Kew0KCXJlZ2lzdGVyX2NhbGxiYWNrKCdhYmNf
ZmlsZV91cGxvYWQnLCAnYXJ0aWNsZV91aScsICdhcnRpY2xlX2ltYWdlJyk7DQoJcmVnaXN0
ZXJfY2FsbGJhY2soJ2FiY19maWxlX3NhdmUnLCAnYXJ0aWNsZV9wb3N0ZWQnKTsNCglyZWdp
c3Rlcl9jYWxsYmFjaygnYWJjX2ZpbGVfc2F2ZScsICdhcnRpY2xlX3NhdmVkJyk7DQoJcmVn
aXN0ZXJfY2FsbGJhY2soJ2FiY19maWxlX2pzJywgJ2FkbWluX3NpZGUnLCAnYm9keV9lbmQn
KTsNCn0NCg0KZnVuY3Rpb24gYWJjX2ZpbGVfanMoJGV2ZW50LCAkc3RlcCkgew0KZWNobyBz
Y3JpcHRfanMoJw0KJCgiI3R4cC1pbWFnZS1ncm91cC1jb250ZW50Iikub24oImNsaWNrIiwg
IiNhcnRpY2xlLWZpbGUtcmVzZXQiLCBmdW5jdGlvbihlKSB7DQoJZS5wcmV2ZW50RGVmYXVs
dCgpOw0KCSQoIiNhcnRpY2xlLWZpbGUtaW5wdXQiKS52YWwoIiIpOw0KCSQoIiNhcnRpY2xl
LWZpbGUtcHJldmlldyIpLmVtcHR5KCk7DQoJJCgiI2FydGljbGUtZmlsZS1yZXNldCIpLmNz
cygidmlzaWJpbGl0eSIsICJoaWRkZW4iKTsNCn0pLm9uKCJjbGljayIsICIuc29ydGFibGUg
LmRlc3Ryb3kiLCBmdW5jdGlvbihlKSB7DQoJZS5wcmV2ZW50RGVmYXVsdCgpOw0KCXZhciAk
dGhpcyA9ICQodGhpcykucGFyZW50KCksICRjb250YWluZXIgPSAkdGhpcy5jbG9zZXN0KCJk
aXYiKTsNCgkkdGhpcy50b2dnbGVDbGFzcygiZGVsZXRlZCIpOw0KCSQoIiNhcnRpY2xlLWlt
YWdlIikudmFsKGFiY19yZWZyZXNoKCRjb250YWluZXIpLmpvaW4oKSkuZm9jdXMoKTsNCn0p
Ow0KDQokKCIjdHhwLWltYWdlLWdyb3VwLWNvbnRlbnQiKS5zb3J0YWJsZSh7DQoJaXRlbXM6
Ii5zb3J0YWJsZSIsDQoJdXBkYXRlOiBmdW5jdGlvbiggZXZlbnQsIHVpICkgew0KCQl2YXIg
JGNvbnRhaW5lciA9IHVpLml0ZW0uY2xvc2VzdCgiZGl2Iik7DQoJCSQoIiNhcnRpY2xlLWlt
YWdlIikudmFsKGFiY19yZWZyZXNoKCRjb250YWluZXIpLmpvaW4oKSk7DQoJfQ0KfSk7DQoN
CndpbmRvdy5hYmNfcmVmcmVzaCA9IGZ1bmN0aW9uICgkY29udGFpbmVyKSB7DQoJdmFyIGxp
c3QgPSBbXTsNCgkkY29udGFpbmVyLmNoaWxkcmVuKCJwIikubm90KCIuZGVsZXRlZCIpLmVh
Y2goZnVuY3Rpb24oKSB7DQoJCWxpc3QucHVzaCgkKHRoaXMpLmRhdGEoImlkIikpOw0KCX0p
Ow0KCXJldHVybiBsaXN0Ow0KfQ0KDQp3aW5kb3cuYWJjX3ByZXZpZXcgPSBmdW5jdGlvbiAo
aW5wdXQpIHsNCglpZiAoISF3aW5kb3cuRmlsZVJlYWRlciAmJiBpbnB1dC5maWxlcyAmJiBp
bnB1dC5maWxlc1swXSkgew0KCQkkKCIjYXJ0aWNsZS1maWxlLXByZXZpZXciKS5lbXB0eSgp
Ow0KCQkkKCIjYXJ0aWNsZS1maWxlLXJlc2V0IikuY3NzKCJ2aXNpYmlsaXR5IiwgInZpc2li
bGUiKTsNCgkJJChpbnB1dC5maWxlcykuZWFjaChmdW5jdGlvbiAoKSB7DQoJCQl2YXIgcmVh
ZGVyID0gbmV3IEZpbGVSZWFkZXIoKTsNCgkJCXJlYWRlci5yZWFkQXNEYXRhVVJMKHRoaXMp
Ow0KCQkJcmVhZGVyLm9ubG9hZCA9IGZ1bmN0aW9uIChlKSB7DQoJCQkJJCgiI2FydGljbGUt
ZmlsZS1wcmV2aWV3IikuYXBwZW5kKCI8cD48aW1nIHNyYz1cJyIgKyBlLnRhcmdldC5yZXN1
bHQgKyAiXCcgLz48L3A+Iik7DQoJCQl9DQoJCX0pOw0KCX0NCn0nKS5uDQouJzxzdHlsZT4N
CgkjdHhwLWltYWdlLWdyb3VwLWNvbnRlbnQgaW1ne21heC13aWR0aDoxMDAlO2hlaWdodDph
dXRvfQ0KCSN0eHAtaW1hZ2UtZ3JvdXAtY29udGVudCAuZGVsZXRlZHtvcGFjaXR5OjAuMjV9
DQoJI3R4cC1pbWFnZS1ncm91cC1jb250ZW50IC5zb3J0YWJsZXtwb3NpdGlvbjpyZWxhdGl2
ZX0NCgkjdHhwLWltYWdlLWdyb3VwLWNvbnRlbnQgLmRlc3Ryb3l7cG9zaXRpb246YWJzb2x1
dGU7cmlnaHQ6MDt6LWluZGV4OjEwMH0NCgkjYXJ0aWNsZS1maWxlLXJlc2V0e3Zpc2liaWxp
dHk6aGlkZGVufQ0KCSNhcnRpY2xlLWZpbGUtaW5wdXR7aGVpZ2h0OiAxMDAlOyB3aWR0aDog
MTAwJTsgei1pbmRleDogNTA7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgb3BhY2l0eTogMH0NCgkj
YXJ0aWNsZS1maWxlLWRyb3A+ZGl2LnR4cC1mb3JtLWZpZWxkLXZhbHVle3Bvc2l0aW9uOiBy
ZWxhdGl2ZTsgYmFja2dyb3VuZDogd2hpdGU7IG91dGxpbmU6IDFweCBzb2xpZCByZ2IoMjIx
LCAyMjEsIDIyMSk7IG1pbi1oZWlnaHQ6IDVleH0NCjwvc3R5bGU+JzsNCn0NCg0KZnVuY3Rp
b24gYWJjX2ZpbGVfdXBsb2FkKCRldmVudCwgJHN0ZXAsICRkYXRhLCAkcnMpDQp7DQoJJGFy
dGljbGVfaW1hZ2UgPSAnJzsNCglpZiAoIWVtcHR5KCRyc1snSW1hZ2UnXSkpDQoJew0KCQlp
bmNsdWRlX29uY2UgJ3B1Ymxpc2gnLkRJUkVDVE9SWV9TRVBBUkFUT1IuJ3RhZ2hhbmRsZXJz
LnBocCc7DQoJCSRpbWFnZXMgPSBhcnJheSgpOw0KCQlmb3JlYWNoIChkb19saXN0X3VuaXF1
ZSgkcnNbJ0ltYWdlJ10pIGFzICRpZCkgew0KCQkJaWYgKCFpc19udW1lcmljKCRpZCkpDQoJ
CQkJJGlkID0gKGludCkgZmV0Y2goJ2lkJywgJ3R4cF9pbWFnZScsICduYW1lJywgJGlkKTsN
Cg0KCQkJaWYgKCRpZCkgJGltYWdlc1tdID0gJzxwIGNsYXNzPSJzb3J0YWJsZSIgZGF0YS1p
ZD0iJy4kaWQuJyI+PGJ1dHRvbiBjbGFzcz0iZGVzdHJveSI+PHNwYW4gY2xhc3M9InVpLWlj
b24gdWktaWNvbi1jbG9zZSI+Jy5nVHh0KCdkZWxldGUnKS4nPC9zcGFuPjwvYnV0dG9uPjxh
IGhyZWY9ImluZGV4LnBocD9ldmVudD1pbWFnZSZzdGVwPWltYWdlX2VkaXQmaWQ9Jy4kaWQu
JyIgdGl0bGU9IicuJGlkLiciPicNCgkJCQkuaW1hZ2UoYXJyYXkoJ2lkJyA9PiAkaWQpKQ0K
CQkJCS4nPC9hPjwvcD4nOw0KCQl9DQoJCWlmICgkaW1hZ2VzKQ0KCQkJJGFydGljbGVfaW1h
Z2UgPSAnPGRpdj4nLmltcGxvZGUobiwgJGltYWdlcykuJzwvZGl2PicubjsNCgl9DQoNCgly
ZXR1cm4gJGRhdGEubi4kYXJ0aWNsZV9pbWFnZS4nPGhyIC8+Jy5pbnB1dExhYmVsKA0KCQkn
YXJ0aWNsZS1maWxlJywNCgkJJzxidXR0b24gaWQ9ImFydGljbGUtZmlsZS1yZXNldCIgY2xh
c3M9ImRlc3Ryb3kiPjxzcGFuIGNsYXNzPSJ1aS1pY29uIHVpLWljb24tY2xvc2UiPicuZ1R4
dCgnZGVsZXRlJykuJzwvc3Bhbj48L2J1dHRvbj4nLm4uDQoJCSc8aW5wdXQgaWQ9ImFydGlj
bGUtZmlsZS1pbnB1dCIgdHlwZT0iZmlsZSIgbmFtZT0iYXJ0aWNsZV9maWxlW10iIG11bHRp
cGxlPSJtdWx0aXBsZSIgb25jaGFuZ2U9ImFiY19wcmV2aWV3KHRoaXMpIiAvPicNCgkJCS4n
PHA+Q2xpY2sgb3IgZHJvcCBvbiB0aGlzIHpvbmU8L3A+Jy5uDQoJCS4nPGRpdiBpZD0iYXJ0
aWNsZS1maWxlLXByZXZpZXciPjwvZGl2PicubiwNCgkJZ1R4dCgndXBsb2FkX2ltYWdlJyku
bg0KCQkJLmNoZWNrYm94KCdhcnRpY2xlX2ZpbGVfYWRkJywgMSwgdHJ1ZSwgMCwgJ2FydGlj
bGUtZmlsZS1hZGQnKQ0KCQkJLic8bGFiZWwgZm9yPSJhcnRpY2xlLWZpbGUtYWRkIj4nLmdU
eHQoJ2FkZCcpLic8L2xhYmVsPicsDQoJCWFycmF5KCcnLCAnaW5zdHJ1Y3Rpb25zX2FydGlj
bGVfaW1hZ2UnKSwNCgkJYXJyYXkoJ2lkJyA9PiAnYXJ0aWNsZS1maWxlLWRyb3AnLCAnY2xh
c3MnID0+ICd0eHAtZm9ybS1maWVsZCBhcnRpY2xlLWltYWdlJykNCgkpOw0KfQ0KDQpmdW5j
dGlvbiBhYmNfZmlsZV9zYXZlKCRldmVudCwgJHN0ZXAsICRycykNCnsNCglpZihlbXB0eSgk
X0ZJTEVTWydhcnRpY2xlX2ZpbGUnXVsndG1wX25hbWUnXVswXSkgfHwgIWhhc19wcml2cygn
aW1hZ2UuZWRpdC5vd24nKSkgcmV0dXJuOw0KDQoJaW5jbHVkZV9vbmNlICdsaWInLkRJUkVD
VE9SWV9TRVBBUkFUT1IuJ2NsYXNzLnRodW1iLnBocCc7DQoJJGlkcyA9IGFycmF5KCk7DQoJ
JGZpbGVzID0gYWJjX2ZpbGVfcmVmYWN0b3IoJF9GSUxFU1snYXJ0aWNsZV9maWxlJ10pOw0K
DQoJZm9yZWFjaCAoJGZpbGVzIGFzICRmaWxlKSB7DQoJCSRtZXRhID0gYXJyYXkoJ2FsdCcg
PT4gJGZpbGVbJ25hbWUnXSk7ICAvL2NhcHRpb24sIGNhdGVnb3J5DQoJCSRpbWdfcmVzdWx0
ID0gaW1hZ2VfZGF0YSgkZmlsZSwgJG1ldGEpOw0KDQoJCWlmIChpc19hcnJheSgkaW1nX3Jl
c3VsdCkpIHsNCgkJCWxpc3QoJG1lc3NhZ2UsICRpZCkgPSAkaW1nX3Jlc3VsdDsNCgkJCSRp
ZHNbXSA9ICRpZDsNCgkJfQ0KCX0NCg0KCSRHTE9CQUxTWydJRCddID0gaW50dmFsKCRyc1sn
SUQnXSk7Ly8gc2ljIQ0KCSRpZHMgPSBpbXBsb2RlKCcsJywgJGlkcyk7DQoJaWYoZ3BzKCdh
cnRpY2xlX2ZpbGVfYWRkJykpICRpZHMgPSBpbXBsb2RlKCcsJywgZG9fbGlzdF91bmlxdWUo
JHJzWydJbWFnZSddLicsJy4kaWRzKSk7DQoJc2FmZV91cGRhdGUoJ3RleHRwYXR0ZXJuJywg
IkltYWdlPSciLmRvU2xhc2goJGlkcykuIiciLCAnSUQ9Jy4kR0xPQkFMU1snSUQnXSk7DQp9
DQoNCmZ1bmN0aW9uIGFiY19maWxlX3JlZmFjdG9yKCYkZmlsZSkNCnsNCgkkaXNfYXJyYXkg
PSBpc19hcnJheSgkZmlsZVsnbmFtZSddKTsNCgkkZmlsZV9hcnJheSA9IGFycmF5KCk7DQoJ
JGZpbGVfY291bnQgPSAkaXNfYXJyYXkgPyBjb3VudCgkZmlsZVsnbmFtZSddKSA6IDE7DQoJ
JGZpbGVfa2V5cyA9IGFycmF5X2tleXMoJGZpbGUpOw0KDQoJZm9yICgkaT0wOyAkaTwkZmls
ZV9jb3VudDsgJGkrKykgew0KCQlmb3JlYWNoICgkZmlsZV9rZXlzIGFzICRrZXkpIHsNCgkJ
CSRmaWxlX2FycmF5WyRpXVska2V5XSA9ICRpc19hcnJheSA/ICRmaWxlWyRrZXldWyRpXSA6
ICRmaWxlWyRrZXldOw0KCQl9DQoJfQ0KDQoJcmV0dXJuICRmaWxlX2FycmF5Ow0KfSI7czo0
OiJ0eXBlIjtzOjE6IjQiO3M6NToib3JkZXIiO3M6MToiNSI7czo1OiJmbGFncyI7czoxOiIw
IjtzOjQ6ImhlbHAiO2I6MDtzOjM6Im1kNSI7czozMjoiMWZhNjRlMTcyNmRkOTBmNjA4YTVh
ODMzOTFkMzlhMGYiO30=

Edit: code re-updated, thanks again, Stef.

Last edited by etc (2016-09-17 09:00:05)

Bloke · 2016-05-11 14:37:30

etc wrote #299057:

uploading images (or files) from Write tab is a few-liner plugin.

OK, first of all: yes! Regardless of whether the remainder of your prefs patch manages to get squeezed into 4.6 before final release, I think this commit ought to be in core, as it continues the tradition of fixing containers to shield plugin authors from markup changes, as well as laying the foundations for plugins such as this one.

That said, the plugin needs a couple of tweaks so it works for me. Firstly to fix this error:

PHP Fatal error:  Class 'txp_thumb' not found

(just need to include_once lib/class.thumb.php; for those of us that have auto thumb creation on).

Secondly, I small possible enhancement. Could you add a check for suitable privs before rendering the file browser widget? If someone doesn’t have privs to be able to upload images (or manage their own images) then they shouldn’t be able to upload them from the Write panel at all. Otherwise, I think you’d get the situation where they could select a file for upload, hit Save and find it doesn’t get saved, which is confusing UX. Might be wrong as I’ve not stepped through the code, just glanced at it so far.

Otherwise, a worthy idea. And if your commit lands in core, this plugin is a nice stop-gap solution until we can address image additions fully. Bravo!

Bloke · 2016-05-11 15:41:46

Regarding your edit: ummm, think you need this line:

include_once 'lib'.DS.'class.thumb.php';

in the abc_file_save() function, since it tries to write the thumbnails inside the image_data() function.

There’s actually an argument for adding that line to the image_data() function itself in txplib_misc.php? After all, it’s a dependency in that function. What do you think?

etc · 2016-05-11 18:11:39

Bloke wrote #299060:

Regarding your edit: ummm, think you need this line:

include_once 'lib'.DS.'class.thumb.php';...

in the abc_file_save() function, since it tries to write the thumbnails inside the image_data() function.

Oops, sorry, never used thumbnails, updated.

There’s actually an argument for adding that line to the image_data() function itself in txplib_misc.php? After all, it’s a dependency in that function. What do you think?

Well.. don’t know :)

Textpattern CMS

Textpattern CMS support forum

#1 2012-12-03 06:16:13