Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2020-01-16 22:27:14

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

What if we totally remove dev-theme related stuff for admins who have disabled ‘Enable dev preview’ pref? So basically they would be able to manage only live themes?

Edit: it’s a private (per user) pref.

Offline

#14 2020-01-16 22:33:04

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,250
Website GitHub

Re: themes on 4.8beta

etc wrote #321153:

What if we totally remove dev-theme related stuff for admins who have disabled ‘Enable dev preview’ pref? So basically they would be able to manage only live themes?

Intriguing. I like that!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#15 2020-01-16 22:39:12

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,909
Website

Re: themes on 4.8beta

etc wrote #321153:

What if we totally remove dev-theme related stuff for admins who have disabled ‘Enable dev preview’ pref?

That’s kind of how I thought the preference worked, to be honest, which is why I was having some trouble understanding the need for the ‘Live’ check box.

The ‘Deploy to live’ option, however, makes sense to me, in the dev environment.

So I don’t know.

Offline

#16 2020-01-16 22:39:41

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

Bloke wrote #321154:

Intriguing. I like that!

Please test and revert if needed.

Offline

#17 2020-01-16 22:42:50

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

Destry wrote #321155:

That’s kind of how I thought the preference worked, to be honest, which is why I was having some trouble understanding the need for the ‘Live’ check box.

Sorry for the confusion. With ‘dev preview’ disabled you were still able to follow theme development on the admin side, but would be served ‘live’ version on the public side. If enabled, you get ‘dev’ version on public side too.

Offline

#18 2020-01-16 22:46:44

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,909
Website

Re: themes on 4.8beta

Oh right. That sounds familiar. I think one of you explained that to me before in repo threads.

Offline

#19 2020-01-17 01:10:55

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,250
Website GitHub

Re: themes on 4.8beta

Okay, I’ve promoted the developer preview options to first class citizens on the multi-edit dropdown. Please test.

If this is okay, the switch_dev_live string can be removed.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#20 2020-01-17 01:37:11

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,058
Website

Re: themes on 4.8beta

Bloke wrote #321159:

Okay, I’ve promoted the developer preview options to first class citizens on the multi-edit dropdown. Please test.

If this is okay, the switch_dev_live string can be removed.

That is of course a little tricky. What does it means “Deploy/Reset to Live” for a section that already is set to use a Live theme?

In the screenshot, 2 sections are already live and using the Live theme. The top one is still on Dev.

p.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#21 2020-01-17 10:16:55

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,250
Website GitHub

Re: themes on 4.8beta

phiw13 wrote #321160:

What does it means “Deploy/Reset to Live” for a section that already is set to use a Live theme?

Nothing. It’ll be ignored. Same way as, before the commit, you could:

  1. Select a bunch of sections (some dev, some live as in your example).
  2. Choose ‘Developer preview’ from multi-edit.
  3. Pick Deploy to live to push dev->live themes on those selected sections (and ignore the ones that had no dev).
  4. Pick Reset to live to ditch the dev themes on those selected sections (and ignore the ones that had no dev).

No change in functionality, it’s just fewer clicks now to achieve the same thing.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#22 2020-01-17 10:25:26

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

Bloke wrote #321148:

Are you going to make the live/dev checkboxes remember their state? I presume that’s possible?

On a second thought, this state should not be browser-dependent, rather a user preference?

Offline

#23 2020-01-17 10:50:33

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

Bloke wrote #321159:

If this is okay, the switch_dev_live string can be removed.

I second @phiw13, without this string the wording is fuzzy.

Offline

#24 2020-01-17 11:14:51

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,250
Website GitHub

Re: themes on 4.8beta

etc wrote #321168:

without [switch_dev_live] string the wording is fuzzy.

Maybe. If it’s more confusing, I’m fine if the commit is reverted. Just trying it out.

etc wrote #321164:

On a second thought, this state should not be browser-dependent, rather a user preference?

Do you mean a per-user pref that’s automatically updated to store the checkbox states when you perform a change theme/page/style action, as opposed to storing it in localStorage?

Or do you mean a physical pref setting on the Prefs panel?

I’m fine with the former. Not sure the latter would help!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB