Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2016-09-13 06:29:24

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,858
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.6.0 released

Bloke wrote #301394:

Fixed, thanks.

It still mentions v4.5. Should that be v4.6?


Yiannis
——————————
neme.org | hblack.net | EMAP | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#26 2016-09-13 06:43:14

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,720
Website GitHub

Re: Feedback to: Textpattern CMS 4.6.0 released

colak wrote #301395:

It still mentions v4.5. Should that be v4.6?

OK, really fixed now :-)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#27 2016-09-14 00:59:49

JimJoe
Member
From: United States
Registered: 2010-01-30
Posts: 539
Website

Re: Feedback to: Textpattern CMS 4.6.0 released

Thanks for all the work !

Offline

#28 2016-09-14 13:54:58

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 997
Website

Re: Feedback to: Textpattern CMS 4.6.0 released

Thank you! Thank you!

Did something change about the way $variable works? I have the following code working under 4.5.7, but it throws an “undefined index” error on 4.6:

<txp:php>

global $variable;

if ($variable['my_variable']) {
  $variable['my_variable'] = ' '.$variable['my_variable'];
} else {
  $variable['my_variable'] = '';
}

</txp:php>
philwareham wrote #301382:

Hi. That’s planned for a later release, not 4.6.

Is the “ghost” Robert? What happened?

Offline

#29 2016-09-14 14:03:06

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,553
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301456:

Is the “ghost” Robert? What happened?

Ha! That is where we ported the issues across from Google Code, it made all old commenters a ghost for some reason.

Offline

#30 2016-09-14 14:04:30

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,720
Website GitHub

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301456:

Did something change about the way $variable works?

Don’t think so, but our warning levels changed so your PHP version may be throwing the warning now, when it didn’t (but should have) under 4.5.7. The error-free way to check if a variable exists in PHP is either:

if (isset($variable['my_variable'])) { ... }

or:

if (!empty($variable['my_variable'])) { ... }

Though be careful of the latter if you expect values that can be evaluated as empty, such as 0, false, null, '', etc.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#31 2016-09-14 14:23:15

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 997
Website

Re: Feedback to: Textpattern CMS 4.6.0 released

Thank you! In short, “user error”.

I also notice article_custom no longer supports the listform attribute. Easy to work around, though—no problem. I imagine this was a matter of cleanup too?

Offline

#32 2016-09-14 14:27:55

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 997
Website

Re: Feedback to: Textpattern CMS 4.6.0 released

philwareham wrote #301459:

Ha! That is where we ported the issues across from Google Code, it made all old commenters a ghost for some reason.

That’s a relief! I was imagining a cadre of cyber-assassins stalking Team Textpattern and silently rubbing you out, one by one, starting on Github.

Offline

#33 2016-09-14 14:28:52

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,720
Website GitHub

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301463:

I also notice article_custom no longer supports the listform attribute… I imagine this was a matter of cleanup too?

Yes, the two tags are handled by the same internal function, and we were a bit lax about which atts went with which. You could legitimately do things like <txp:article id="50" /> and it would let you, but ignore it if you were in article context. Now it’s not permitted and will throw a warning.

Vice-versa, some of the <txp:article /> attributes were allowed in article_custom tags, even though they didn’t make sense. No more.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#34 2016-09-14 19:20:18

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 997
Website

Re: Feedback to: Textpattern CMS 4.6.0 released

I just noticed that two files are missing from the update directory:

  • textpattern/update/_to_4.4.0.php
  • textpattern/update/_to_4.4.1.php

Does this matter?

Offline

#35 2016-09-14 20:03:41

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,872
GitHub

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301478:

I just noticed that two files are missing from the update directory:

  • textpattern/update/_to_4.4.0.php
  • textpattern/update/_to_4.4.1.php

Does this matter?

Checking these files against the 4.5.7 distribution, there were no actual changes made, so I suspect they were culled as cruft.

Offline

#36 2016-09-14 20:10:45

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,720
Website GitHub

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301478:

two files are missing from the update directory… Does this matter?

Nope. They were, as Pete said, cruft. Never used, just had to be there as placeholders because of limitations in the way the upgrade script worked. Since we refactored the upgrade script, they’re no longer required to be there.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

Board footer

Powered by FluxBB