Feedback to: Textpattern CMS 4.6.0 released

jstubbs · 2016-09-11 11:14:47

Lovely work and thank you!! After updating one site I get this notice:

Theme classic (classic_theme) failed to load properly from file...

…then nothing happens which isn’t great for new users. Veterans will know to refresh the page, and the login page reappears.

After that, I get the languages tab and further warnings:

User_Error "Duplicate entry '1-pane_article_textfilter_help_visible-jstubbs' for key 'prefs_idx'"
in /home/..../webapps/..../textpattern/lib/txplib_db.php at line 405. 

And:

textpattern/lib/txplib_misc.php:1676 adminErrorHandler()
updateErrorHandler()
textpattern/lib/txplib_db.php:405 trigger_error()
textpattern/lib/txplib_db.php:455 safe_query()
textpattern/update/_to_4.6.0.php:30 safe_update()
textpattern/update/_update.php:84 include()
textpattern/index.php:180 include()

Not sure what those errors are, have to investigate a bit further!

Edit: Mmm, can’t go to any other admin tab now!

jstubbs · 2016-09-11 11:30:32

Yep can’t do anything and the corresponding line in txp_db.php isn’t so informative…

 if ($result === false) {
        trigger_error(mysqli_error($DB->link), E_USER_ERROR);
    }

jstubbs · 2016-09-11 11:54:59

OK, so Destry’s problem and fix seem to do the trick so far..

phuture303 · 2016-09-12 16:21:11

Hey there, thank you so much for your work, will try to update some sites in a few days!

Just had a look online at the demo and referring to my question about custom_fields … there are still only ten text-inputs and no radios, no selects etc. in the final 4.6?

philwareham · 2016-09-12 17:17:02

phuture303 wrote #301380:

Just had a look online at the demo and referring to my question about custom_fields … there are still only ten text-inputs and no radios, no selects etc. in the final 4.6?

Hi. That’s planned for a later release, not 4.6.

phuture303 · 2016-09-12 18:50:08

philwareham wrote #301382:

Hi. That’s planned for a later release, not 4.6.

Ok, thanks!

giz · 2016-09-12 19:01:41

Fantastic work everyone: a big thank you to all involved.

GugUser · 2016-09-13 04:05:38

I think that is no longer valid System requirements.

Bloke · 2016-09-13 06:27:49

GugUser wrote #301393:

I think that is no longer valid System requirements.

Fixed, thanks.

colak · 2016-09-13 06:29:24

Bloke wrote #301394:

Fixed, thanks.

It still mentions v4.5. Should that be v4.6?

Bloke · 2016-09-13 06:43:14

colak wrote #301395:

It still mentions v4.5. Should that be v4.6?

OK, really fixed now :-)

JimJoe · 2016-09-14 00:59:49

Thanks for all the work !

johnstephens · 2016-09-14 13:54:58

Thank you! Thank you!

Did something change about the way $variable works? I have the following code working under 4.5.7, but it throws an “undefined index” error on 4.6:

<txp:php>

global $variable;

if ($variable['my_variable']) {
  $variable['my_variable'] = ' '.$variable['my_variable'];
} else {
  $variable['my_variable'] = '';
}

</txp:php>

philwareham wrote #301382:

Hi. That’s planned for a later release, not 4.6.

Is the “ghost” Robert? What happened?

philwareham · 2016-09-14 14:03:06

johnstephens wrote #301456:

Is the “ghost” Robert? What happened?

Ha! That is where we ported the issues across from Google Code, it made all old commenters a ghost for some reason.

Bloke · 2016-09-14 14:04:30

johnstephens wrote #301456:

Did something change about the way $variable works?

Don’t think so, but our warning levels changed so your PHP version may be throwing the warning now, when it didn’t (but should have) under 4.5.7. The error-free way to check if a variable exists in PHP is either:

if (isset($variable['my_variable'])) { ... }

or:

if (!empty($variable['my_variable'])) { ... }

Though be careful of the latter if you expect values that can be evaluated as empty, such as 0, false, null, '', etc.

Textpattern CMS support forum

#16 2016-09-11 11:14:47

Re: Feedback to: Textpattern CMS 4.6.0 released

#17 2016-09-11 11:30:32

Re: Feedback to: Textpattern CMS 4.6.0 released

#18 2016-09-11 11:54:59

Re: Feedback to: Textpattern CMS 4.6.0 released

#19 2016-09-12 16:21:11

Re: Feedback to: Textpattern CMS 4.6.0 released

#20 2016-09-12 17:17:02

Re: Feedback to: Textpattern CMS 4.6.0 released

phuture303 wrote #301380:

#21 2016-09-12 18:50:08

Re: Feedback to: Textpattern CMS 4.6.0 released

philwareham wrote #301382:

#22 2016-09-12 19:01:41

Re: Feedback to: Textpattern CMS 4.6.0 released

#23 2016-09-13 04:05:38

Re: Feedback to: Textpattern CMS 4.6.0 released

#24 2016-09-13 06:27:49

Re: Feedback to: Textpattern CMS 4.6.0 released

GugUser wrote #301393:

#25 2016-09-13 06:29:24

Re: Feedback to: Textpattern CMS 4.6.0 released

Bloke wrote #301394:

#26 2016-09-13 06:43:14

Re: Feedback to: Textpattern CMS 4.6.0 released

colak wrote #301395:

#27 2016-09-14 00:59:49

Re: Feedback to: Textpattern CMS 4.6.0 released

#28 2016-09-14 13:54:58

Re: Feedback to: Textpattern CMS 4.6.0 released

philwareham wrote #301382:

#29 2016-09-14 14:03:06

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301456:

#30 2016-09-14 14:04:30

Re: Feedback to: Textpattern CMS 4.6.0 released

johnstephens wrote #301456:

Board footer