Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2013-06-03 00:57:06

damienbuckley
Member
From: Brisbane, QLD, AU
Registered: 2006-02-24
Posts: 138
Website

Any ideas what would break zem_event in 4.5.4

I know it an orphaned plugin but I have half a dozen sites using zem_event and I’ve just upgraded two to 4.5.4 (from 4.4.1) and whereas zem_event was working under 4.4.1 the datepicker etc (in admin) is now no longer showing up.

I’ve inspected the source and it seems to be loading the resources (I reinstated the ‘js’ folder into the textpattern folder that it needed) but the div with the datepicker etc is no longer being inserted.

I know this isn’t technically a TXP issue but I would appreciate any assistance as I am otherwise stuck with out of date installs…

Offline

#2 2013-06-19 09:35:14

xbl4814
Member
Registered: 2013-06-14
Posts: 10

Re: Any ideas what would break zem_event in 4.5.4

We have a similar problem.

We inherited a site from an defunct web agency and after migrating to a newer server, which necessitated the upgrade to TP 4.5.4 we cannot update existing “events” nor create new ones :-)

All the events are displaying correctly we just cannot change them:

http://www.gardens-of-argyll.co.uk/events/

Any ideas on how we can correct this problem?

Offline

#3 2013-06-19 10:04:37

etc
Developer
Registered: 2010-11-11
Posts: 5,689
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

Seemingly, the 4.4.1 article event used by zem_event was split in article_posted and article_saved in 4.5. You can try to replace the line 1926 of zem_event.php with

register_callback('zem_event_handler', 'article_posted');

to see if new event can be created, but the result is not guaranteed.

Edit: probably, the plugin type should be set to 5 too.

Last edited by etc (2013-06-19 10:17:02)

Offline

#4 2013-06-19 10:22:45

xbl4814
Member
Registered: 2013-06-14
Posts: 10

Re: Any ideas what would break zem_event in 4.5.4

Thanks for the post, which looks promising.

However we cannot find the plugin file :-)

We have tried GREP across the entire site and not coming up with anything. I know this is a really stupid question but where are the TP plugins stored?

Thanks

Offline

#5 2013-06-19 10:25:48

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,397
Website GitHub Mastodon Twitter

Re: Any ideas what would break zem_event in 4.5.4

You can find and edit the plugins in admin>plugins


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#6 2013-06-19 10:32:17

xbl4814
Member
Registered: 2013-06-14
Posts: 10

Re: Any ideas what would break zem_event in 4.5.4

Thanks and we just realised that is how you edit a plugin.

However when we change the line of code

register_callback(‘zem_event_handler’, ‘article’);

which is around line 1872 to:

register_callback(‘zem_event_handler’, ‘article_posted’);

as suggested it breaks the events admin interface and we cannot see the previously published articles and the fields we need to load or edit an event are missing :-(

Seems a lot of people are having the same problem after upgrading to TP 4.5.4

Offline

#7 2013-06-19 10:48:11

etc
Developer
Registered: 2010-11-11
Posts: 5,689
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

xbl4814 wrote:

it breaks the events admin interface and we cannot see the previously published articles and the fields we need to load or edit an event are missing :-(

Yes, sorry, that was a blind proposal. Have you tried to set the plugin type to 5 in txp_plugin table?

Offline

#8 2013-06-19 10:50:07

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,319

Re: Any ideas what would break zem_event in 4.5.4

Yup, I also thought about that. Though I presume there’s also an AJAX issue with the plugin.

Edit: I missed your first hint some posts above, Oleg.

Last edited by uli (2013-06-19 10:59:55)


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#9 2013-06-19 10:58:07

etc
Developer
Registered: 2010-11-11
Posts: 5,689
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

uli wrote:

Yup, I also thought about that. Though I presume there’s also an AJAX issue with the plugin.

I would test it, but I get Fatal error: Call to undefined function include_element() when trying to install v.0.3.5 :/

Offline

#10 2013-06-19 11:07:02

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,319

Re: Any ideas what would break zem_event in 4.5.4

etc wrote:

when trying to install v.0.3.5 :/

There’s also the possibility to copy code from the installation’s process preview window.


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#11 2013-06-19 11:12:25

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: Any ideas what would break zem_event in 4.5.4

etc wrote:

I would test it, but I get Fatal error: Call to undefined function include_element() when trying to install v.0.3.5 :/

The plugin uses crockery code. It checks if the Textpattern version is higher than 4.1.0, and if it is, it breaks. The plugin also tries to include its own jQuery library etc. It’s pretty outdated, and would require patching.

Seemingly, the 4.4.1 article event used by zem_event was split in article_posted and article_saved in 4.5.

The article event hasn’t gone anywhere. Those two events are just additions, not replacements. The article event is fired when the Write pane itself is accessed. article_posted and article_saved are fired when an article is published and updated, respectfully.

damienbuckley wrote:

I know this isn’t technically a TXP issue but I would appreciate any assistance as I am otherwise stuck with out of date installs…

Take a look at smd_calendar. Its much more up to date, and you could try migrating to it.

Last edited by Gocom (2013-06-19 11:17:36)

Offline

#12 2013-06-19 11:29:15

etc
Developer
Registered: 2010-11-11
Posts: 5,689
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

Gocom wrote:

The article event hasn’t gone anywhere. Those two events are just additions, not replacements. The article event is fired when the Write pane itself is accessed. article_posted and article_saved are fired when an article is published and updated, respectfully.

I see, thanks. The callback list is a bit misleading.

Offline

#13 2013-06-19 11:47:42

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: Any ideas what would break zem_event in 4.5.4

Well, those are manually updated lists, which also don’t really explain why, how and what causes the event to be invoked. Instead it listing all core events, it could explain what causes the editor form callbacks, so you can yourself do 1+1. Panel + editor = panel, editor_action. If you want to know the list of events, you are better off running the source through PHPdoc and searching for ‘event’. Each function/method describes the events it invokes. The description at least tells you what data is passed to the handler, and what causes the event to be invoked and how the identifier is formed.

Last edited by Gocom (2013-06-19 11:49:58)

Offline

#14 2013-06-19 13:36:08

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,502
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

In the past I’ve just removed the if/else branch in the zem_event plugin that checks for crockery (4.1.0), where it mentions include_element(). It does work and at least gets you limping along, but as Gocom says, the plugin’s pretty outdated.

Note to self: update the core callback list and include more details, until 4.6 is released when PHPDoc can take over to some extent.

Last edited by Bloke (2013-06-19 13:47:17)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Online

#15 2013-06-19 14:09:57

etc
Developer
Registered: 2010-11-11
Posts: 5,689
Website GitHub

Re: Any ideas what would break zem_event in 4.5.4

Bloke wrote:

In the past I’ve just removed the if/else branch in the zem_event plugin that checks for crockery (4.1.0), where it mentions include_element(). It does work and at least gets you limping along, but as Gocom says, the plugin’s pretty outdated.

Oh, great! I have set the plugin type to 5, and it seems to work now: new events are saved. The only drawback is that there is no “Save” button anymore. :)

Offline

Board footer

Powered by FluxBB