Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#217 2013-03-08 17:16:50

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,214
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

{Update: Pleased to Announce an update to this supremely useful plugin to make it 4.6 compatible with Phil’s awesome Hive theme you can download it here » } This was tested against 4.6 dev Branch of late February. Hope it works for you as I offer no support. It is untested on a stock 4.5 release

Offline

#218 2013-03-09 00:21:37

towndock
Member
From: Oriental, NC USA
Registered: 2007-04-06
Posts: 311
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

FYI – Dale’s fine work was to make the v2 version of ebl-image-edit work with 4.5 and beyond. Since this thread was on v1, be aware it is the diff version of the plug in.

Some Txp users have preferred the v1 version of this plugin.

Dale, I did try the 2.1 ebl-image-edit version you’ve made with Txp 4.5.4 – on initial testing all seems well.

Offline

#219 2013-03-09 00:24:16

TheEric
Plugin Author
From: Wyoming
Registered: 2004-09-17
Posts: 566

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

I may off and on have some time to work on the plugin.

@towndock – Why?

Offline

#220 2013-03-09 00:51:15

towndock
Member
From: Oriental, NC USA
Registered: 2007-04-06
Posts: 311
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Eric, it is a great plugin. I donated years ago, and it has been an important part of many sites I’ve worked on.

I think v1 simply worked more reliably than v2 initially, and a v1 habit was formed.

I may 2013 re-education on this. Could you remind me of the v2 benefits over v1?

Offline

#221 2013-03-09 00:52:57

TheEric
Plugin Author
From: Wyoming
Registered: 2004-09-17
Posts: 566

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Admittedly, I don’t remember. I was considering taking this one up again as a hobby. I just have to refresh my memory as to what I did and why.

Offline

#222 2013-03-09 10:10:11

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,532
Website GitHub Twitter

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

@TheEric

It would be great if this plugin continues development.

I realise we made some pretty sweeping changes in Textpattern 4.5 that probably broke your plugin a lot, and there are more coming in 4.6 (modal edit windows for one) but hopefully after that the admin-side will settle down structure-wise for a few years. It was a necessary task to pull Textpattern kicking and screaming into the present.

We are finally working towards a proper design document too which will help plugin authors develop stuff easier I hope.

Offline

#223 2013-07-02 09:16:11

THE BLUE DRAGON
Member
From: Israel
Registered: 2007-11-16
Posts: 601
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

mrdale wrote:

_{Update: Pleased to Announce an update to this supremely useful plugin to make it 4.6 compatible with Phil’s awesome Hive theme you can download it here » }

Thanks for that, the UI does look good now!
But you forgot to update 2 of the jCrop plugin files, the js and css.
Take a look at step #3 in my post here .
Without changing these 2 files it doesn’t works good for me.

Offline

#224 2013-07-02 12:31:20

THE BLUE DRAGON
Member
From: Israel
Registered: 2007-11-16
Posts: 601
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Double-click to create is here! :)

Apparently the “onDblClick” callback was there all the time o_O!

In the plugin code, go search for:

onChange: showCoords,

and add this below/above:

onDblClick: function(){
	if($('#eblcropctrl').is(':visible')){
		$('#eblimgcrop').click();
	}else if($('#ebltmbctrl').is(':visible')){
		$('#ebltmbcrop').click();
	}
},

save, done :)

Offline

#225 2013-07-03 21:17:08

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,242

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

THE BLUE DRAGON wrote

$('#eblimgcrop').click();

Gil, thanks a lot! So simple, so effective! :)

Plugin Garage 2:

Thanks to your post I was reminded of this plugin and its faulty properties while writing thumbnail dimensions to the database. Being a PHP-illiterate, it took me quite a while, but I think I made it work now. Having my nose so close to the code, I saw that cropping images didn’t enter dimensions into the database, too, something nobody has ever remarked, I believe. Eric had used some excess screws and washers so that safe_update got one parameter too much filled in.

Look for

    if($action != 'thumbnail') 
    {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "w = '".$width."', h = '".$height."'", "id = $id");
    } else {
        $rs = safe_update('txp_image', "thumbnail = '1'", "id = $id");
    } 

Replace with

   if($action != 'thumbnail') 
    {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "h = '$height', w = '$width'", "id = $id");
    } else {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "thumb_h = '$height', thumb_w = '$width', thumbnail = '1'", "id = $id");
    }

Last edited by uli (2013-07-04 22:44:47)


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#226 2013-07-04 05:42:42

THE BLUE DRAGON
Member
From: Israel
Registered: 2007-11-16
Posts: 601
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Thanks Uli :)
It’s becoming better and better now :)

Offline

#227 2013-07-04 12:02:48

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,242

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

THE BLUE DRAGON wrote:

It’s becoming better and better now :)

Yep, I thought likewise. What the plugin has on board is now completely fixed and polished up, I think.

BTW, I’m using the mrdale version on 4.5.4 and found no blanks so far. Thanks also to you, Dale! Was delighted to see the UI cleanup/jQuery amendments from Gil’s TXP Tips article already integrated, they’re a blessing to have :)

I’ll probably bundle the whole thing this weekend (Dale’s version plus the current jcrop files plus Gil’s and my code changes), up the version number, and upload it to TXP Resources so that snippet searching, patching, and mistaking have an end.

In this context: Are there any more amendments hanging around in the drawers out there that we should integrate now?

Last edited by uli (2013-07-09 16:35:54)


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#228 2013-07-07 16:05:11

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,214
Website

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

I’d love for you guys to fold in the interface tweeks I made and rerelease a consoldated update.

Offline

Board footer

Powered by FluxBB