[plugin] [ORPHAN] ebl_image_edit v1.0

TheEric · 2012-10-04 03:59:08

gfdesign · 2012-11-16 22:10:15

I miss this plugin for 4.5.2, it doesn’t work fine with me in a clean installation.
Is there any other option ?
Thanks

P/d: I mean, it works but appears the same image without ratio aspect inside selection (previously, it didn’t do it)

Last edited by gfdesign (2012-11-16 22:44:43)

THE BLUE DRAGON · 2012-11-17 08:23:37

gfdesign wrote:

I miss this plugin for 4.5.2, it doesn’t work fine with me in a clean installation.
Is there any other option ?
Thanks

P/d: I mean, it works but appears the same image without ratio aspect inside selection (previously, it didn’t do it)

Did you made the changes I mentioned here that need to be made for it to work on TXP v4.5 ?

TheEric · 2012-11-17 18:57:06

I set up a github repo for this at https://github.com/elimegrover/EBL-image-edit

It’s set to public, and any changes to this plugin should be placed there. I will still, intermittently, be working on it. I figured it would be best to utilize social-aspects of code to progress this plugin along. I still wish to retain my original naming convention for this plugin since it was originally my idea and concept.

{FIXED my link}

Last edited by TheEric (2012-11-17 22:31:07)

gfdesign · 2012-11-17 22:31:25

THE BLUE DRAGON dijo:

Did you made the changes I mentioned here that need to be made for it to work on TXP v4.5 ?

Yes, I did it, but I get this (the same image without ratio aspect inside selection):

I didn’t try in a online server, just in a local enviroment using XAMPP (You can see error I get in top)
Anyway, thanks for your reply, I’ll try again in a new clean installation.

Last edited by gfdesign (2012-11-17 22:37:19)

superfly · 2012-11-23 14:05:08

I fixed the epl_image_edit Plugin for my TXP v4.5 Installation. I use the Default “Hive” Admin Theme!

Here’s how to:

Search the Plugin Code for the jQuery Init Function

$("#list td:first img").attr('id','mainImg'); // Give our image an ID
$("#list td:first").attr('id','mainImgTD'); // name the table to make it easier to find.
$('#image-thumbnail td:first img').attr('id','thumb'); // Give our thumbnail image an ID
$('#image-thumbnail td:first').attr('id','thumbTD'); // name the TD that contains the image so we can swap it out.

And replace it with the following

$(".fullsize-image .content-image").attr('id','mainImg'); // Give our image an ID
$(".fullsize-image").attr('id','mainImgTD'); // name the table to make it easier to find.
$('.thumbnail-edit .content-image').attr('id','thumb'); // Give our thumbnail image an ID
$('.thumbnail-edit').attr('id','thumbTD'); // name the TD that contains the image so we can swap it out.
$('#mainImgTD').toggleClass('fullsize-image');

Worked so far for me, good luck!

Last edited by superfly (2012-11-23 14:11:33)

mrdale · 2013-03-08 17:16:50

{Update: Pleased to Announce an update to this supremely useful plugin to make it 4.6 compatible with Phil’s awesome Hive theme you can download it here » } This was tested against 4.6 dev Branch of late February. Hope it works for you as I offer no support. It is untested on a stock 4.5 release

towndock · 2013-03-09 00:21:37

FYI – Dale’s fine work was to make the v2 version of ebl-image-edit work with 4.5 and beyond. Since this thread was on v1, be aware it is the diff version of the plug in.

Some Txp users have preferred the v1 version of this plugin.

Dale, I did try the 2.1 ebl-image-edit version you’ve made with Txp 4.5.4 – on initial testing all seems well.

TheEric · 2013-03-09 00:24:16

I may off and on have some time to work on the plugin.

@towndock – Why?

towndock · 2013-03-09 00:51:15

Eric, it is a great plugin. I donated years ago, and it has been an important part of many sites I’ve worked on.

I think v1 simply worked more reliably than v2 initially, and a v1 habit was formed.

I may 2013 re-education on this. Could you remind me of the v2 benefits over v1?

TheEric · 2013-03-09 00:52:57

Admittedly, I don’t remember. I was considering taking this one up again as a hobby. I just have to refresh my memory as to what I did and why.

philwareham · 2013-03-09 10:10:11

@TheEric

It would be great if this plugin continues development.

I realise we made some pretty sweeping changes in Textpattern 4.5 that probably broke your plugin a lot, and there are more coming in 4.6 (modal edit windows for one) but hopefully after that the admin-side will settle down structure-wise for a few years. It was a necessary task to pull Textpattern kicking and screaming into the present.

We are finally working towards a proper design document too which will help plugin authors develop stuff easier I hope.

THE BLUE DRAGON · 2013-07-02 09:16:11

mrdale wrote:

_{Update: Pleased to Announce an update to this supremely useful plugin to make it 4.6 compatible with Phil’s awesome Hive theme you can download it here » }

Thanks for that, the UI does look good now!
But you forgot to update 2 of the jCrop plugin files, the js and css.
Take a look at step #3 in my post here .
Without changing these 2 files it doesn’t works good for me.

THE BLUE DRAGON · 2013-07-02 12:31:20

Double-click to create is here! :)

Apparently the “onDblClick” callback was there all the time o_O!

In the plugin code, go search for:

onChange: showCoords,

and add this below/above:

onDblClick: function(){
	if($('#eblcropctrl').is(':visible')){
		$('#eblimgcrop').click();
	}else if($('#ebltmbctrl').is(':visible')){
		$('#ebltmbcrop').click();
	}
},

save, done :)

uli · 2013-07-03 21:17:08

THE BLUE DRAGON wrote

$('#eblimgcrop').click();

Gil, thanks a lot! So simple, so effective! :)

Plugin Garage 2:

Thanks to your post I was reminded of this plugin and its faulty properties while writing thumbnail dimensions to the database. Being a PHP-illiterate, it took me quite a while, but I think I made it work now. Having my nose so close to the code, I saw that cropping images didn’t enter dimensions into the database, too, something nobody has ever remarked, I believe. Eric had used some excess screws and washers so that safe_update got one parameter too much filled in.

Look for

    if($action != 'thumbnail') 
    {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "w = '".$width."', h = '".$height."'", "id = $id");
    } else {
        $rs = safe_update('txp_image', "thumbnail = '1'", "id = $id");
    }

Replace with

   if($action != 'thumbnail') 
    {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "h = '$height', w = '$width'", "id = $id");
    } else {
        list ($width,$height) = getimagesize($imagedir . $filename);
        $rs = safe_update('txp_image', "thumb_h = '$height', thumb_w = '$width', thumbnail = '1'", "id = $id");
    }

Last edited by uli (2013-07-04 22:44:47)

Textpattern CMS

Textpattern CMS support forum

#211 2012-10-04 03:59:08

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#212 2012-11-16 22:10:15

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#213 2012-11-17 08:23:37

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#214 2012-11-17 18:57:06

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#215 2012-11-17 22:31:25

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#216 2012-11-23 14:05:08

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#217 2013-03-08 17:16:50

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#218 2013-03-09 00:21:37

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#219 2013-03-09 00:24:16

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#220 2013-03-09 00:51:15

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#221 2013-03-09 00:52:57

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#222 2013-03-09 10:10:11

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#223 2013-07-02 09:16:11

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#224 2013-07-02 12:31:20

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#225 2013-07-03 21:17:08

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Board footer