adi_matrix – Multi-article update tabs

redbot · 2011-12-18 12:30:28

Hi Adi,
I think I found a bug with checkboxes generated by glz_custom_field:
checking works ok but unchecking doesn’t seem to (preferences are not saved).
Everything is ok with radio buttons.

edit:
More specifically,
if you have only one option checked you won’t be able to uncheck it (when you hit “save” changes are not saved).
Note that unchecking works ok if you have more than one option checked.

Last edited by redbot (2011-12-18 16:33:53)

mrdale · 2011-12-18 17:08:52

Here’s an usability idea for this incredibly useful plugin.

I often end up with a lot more than 10 custom fields to display on the x axis. This requires scrolling to the right and obscuring the the article title. I don’t know how you would do this (a second table with just titles to the left) but presenting a frozen pane with titles on the left would be really helpful.

Awesome plugin BTW, probably one of the best UI plugins ever for TXP.

masa · 2011-12-18 18:37:55

mrdale wrote:

I don’t know how you would do this (a second table with just titles to the left) but presenting a frozen pane with titles on the left would be really helpful.

That gets my vote, too.

Awesome plugin BTW, probably one of the best UI plugins ever for TXP.

I totally agree!

gomedia · 2011-12-19 01:22:28

redbot wrote:

I think I found a bug with checkboxes generated by glz_custom_field checking works ok but unchecking doesn’t seem to (preferences are not saved).

I’ve sent you a beta version to try …

gomedia · 2011-12-19 01:23:53

mrdale wrote:

… presenting a frozen pane with titles on the left would be really helpful.

I like that idea, very much. I’ll put it on the list.

Gocom · 2011-12-19 02:18:50

I took quick look at adi_matrixe’s code and there seem to be some conflicts and issues;

There are some SQL injection possibilities. All user provided data that is passed to SQL queries should be escaped using doSlash(), i.e. in adi_matrix_update_article(). There are some that are not.
The code at the top of the plugin (wrapped in the conditional tags) is in a scope it shouldn’t be. All that code should be wrapped in a function to avoid conflicts.
if (isset($prefs['plugin_cache_dir'])) is always set. It can be empty, but the variable is always there. To get the performance benefit you are probably trying to get, you could change that to if(empty($prefs['plugin_cache_dir'])).
Global $glz_cfs_installed should be prefixed to avoid potential conflicts.
To avoid potential collisions and improve functionality, adi_matrix_get_articles()’s category (any, none etc) ranges selection could be easily changed so they don’t conflict with real categories — same with usernames (author). This can be easily done by using selector values that are longer than the database field’s maximum length. For author this could be done by using empty value for example.

With following:

if (!strpos($prefs['plugin_cache_dir'],'adi') === FALSE)

You probably mean:

if (strpos($prefs['plugin_cache_dir'],'adi') !== FALSE)

Last edited by Gocom (2011-12-19 02:29:25)

gomedia · 2011-12-19 03:00:15

Gocom wrote:

I took quick look at adi_matrixe’s code and there seem to be some conflicts and issues;

Thanks for your comments.

Anything to do with $prefs['plugin_cache_dir'] is for my local development environment use (& benefit) only & nothing to do with performance.

I’ll look through your other comments but if you find security issues please contact me directly – I don’t see any point in announcing this sort of thing to the world.

Gocom · 2011-12-19 03:16:38

gomedia wrote:

Anything to do with $prefs['plugin_cache_dir'] is for my local development environment use (& benefit) only & nothing to do with performance.

I didn’t even suggest it had something to do with performance. I was talking about the conditional, so that it doesn’t run the strpos() for nothing.

gomedia · 2011-12-19 03:30:16

I was taking about the “To get the performance benefit you are probably trying to get” bit of your post.

Gocom · 2011-12-19 04:16:06

gomedia wrote:

I was taking about the “To get the performance benefit you are probably trying to get” bit of your post.

Uh, yes, obviously.

mrdale · 2012-01-06 22:11:25

OK, This plugin is fast becoming a staple for me and my installs. Here are a couple of wish-list items for “the Australian”.

a page class so that you can style multiple adi_matrix pages and their items.
a frozen title pane, so you can still see the titles when you scroll.
multi-selects in the “article selection” area so you could have multiple selections and/or categories.
custom fields in the “article selection” area
sort results by more stuff, or…
table sorting might be relatively easy.
a mechanism to enable tinyMCE for textarea custom fields.

I also want a pony.

gomedia · 2012-01-06 22:41:51

mrdale wrote:

I also want a pony.

Confucius, he say: “If you want a puppy for Christmas, start by asking for a horse …”

I’m suffering the post-holiday slump at he moment but your requests have be noted. Be gentle, I’ll find first gear again soon. Really need to do some client work first. You won’t be forgotten.

mrdale · 2012-01-07 00:05:09

gomedia wrote: Really need to do some client work first. You won’t be forgotten.

Understood! Really just wanted to formalize my thoughts so that I could forget about it for a while. Thanks again

Last edited by mrdale (2012-01-07 00:05:21)

maniqui · 2012-01-07 00:23:25

a frozen title pane, so you can still see the titles when you scroll.

This certainly would be nice, but I think it would be a hell difficult to achieve. That kind of functionality is not available for HTML tables, afaik, so it will need some kind of trickery using two tables, and always setting the height of each matching row (on each table), so both tables are aligned.
Or is there already any HTML5/CSS3 trick to achieve this?

A quick google search displays some solutions.

This one seems to be the really nice one: fixedheadertable.com/

gomedia · 2012-05-23 04:13:32

Version 1.1 now available for download. Loadsastuff:

1.1
- code tidy up (thanks gocom)
- enhancement: matrix tab optional footer
- enhancement: matrix tab column sorting
- enhancement: “Any parent” & “Any child” category wildcards
- enhancement: posted timestamp (& reset)
- enhancement: expires timestamp
- enhancement: multi-section select (for maniqui & mrdale)
- enhancement: input field tooltips (for masa)
- for mrdale:
  - <body class=“adi_matrix”> on all matrix tabs
  - another attempt at horizontal scrolling, this time with a fixed article title column
  - more sorting options
  - TinyMCE support for glz_custom_field textareas
  - option to include descendent categories
- fixed: checkboxes again! (thanks redbot)
- changed: “Nothing to do” message changed to “No articles modified”
- changed: admin tab name/title to “Article Matrix”/“Article Matrix Admin”
1.0.1 (not officially released)
- fixed: completely unticked checkboxes not updated (thanks redbot)
- fixed: detect glz_custom_fields in plugin cache (thanks gocom)

Textpattern CMS

Textpattern CMS support forum

#91 2011-12-18 12:30:28

Re: adi_matrix – Multi-article update tabs

#92 2011-12-18 17:08:52

Re: adi_matrix – Multi-article update tabs

#93 2011-12-18 18:37:55

Re: adi_matrix – Multi-article update tabs

#94 2011-12-19 01:22:28

Re: adi_matrix – Multi-article update tabs

#95 2011-12-19 01:23:53

Re: adi_matrix – Multi-article update tabs

#96 2011-12-19 02:18:50

Re: adi_matrix – Multi-article update tabs

#97 2011-12-19 03:00:15

Re: adi_matrix – Multi-article update tabs

#98 2011-12-19 03:16:38

Re: adi_matrix – Multi-article update tabs

#99 2011-12-19 03:30:16

Re: adi_matrix – Multi-article update tabs

#100 2011-12-19 04:16:06

Re: adi_matrix – Multi-article update tabs

#101 2012-01-06 22:11:25

Re: adi_matrix – Multi-article update tabs

#102 2012-01-06 22:41:51

Re: adi_matrix – Multi-article update tabs

#103 2012-01-07 00:05:09

Re: adi_matrix – Multi-article update tabs

#104 2012-01-07 00:23:25

Re: adi_matrix – Multi-article update tabs

#105 2012-05-23 04:13:32

Re: adi_matrix – Multi-article update tabs

Board footer