[howto] How to add more Form types

makss · 2012-01-05 14:03:36

uli wrote:

Strikes me that the field shouldn’t show up on the default form page.

Maybe this code will solve the issue? Just download the code, backup your existing include/txp_form.php and overwrite it with this one.

makss · 2012-01-05 14:34:47

LastMod patch – add new field LastMod in txp_form table.
Some code was taken from a file include/txp_article.php
This patch should not cause conflicts with other modules or plug-ins.

Install:
1. In phpMyAdmin add new field LastMod in txp_form table with type datetime

or run sql

ALTER TABLE `txp_form` ADD `LastMod` datetime NOT NULL default '0000-00-00 00:00:00'

or run inside TxP

safe_alter("txp_form", "add `LastMod` datetime NOT NULL default '0000-00-00 00:00:00' ");

2. Download LastMod patch , backup your existing include/txp_form.php and overwrite it with this one.

Last edited by makss (2012-01-05 15:24:27)

uli · 2012-01-05 15:09:45

makss wrote:

Maybe this code will solve the issue?

That’s Stef’s file, as far as I can tell.

makss wrote:

or run safe_alter("txp_form", "add `LastMod` datetime NOT NULL default '0000-00-00 00:00:00' ");

Gives back an SQL error (#1064)

makss · 2012-01-05 15:29:39

uli wrote:

That’s Stef’s file, as far as I can tell.

Yes, this is Stef’s code with my little patch.

Gives back an SQL error (#1064)

I corrected the previous post and posted there pure sql

Last edited by makss (2012-01-05 15:32:17)

uli · 2012-01-05 15:42:17

makss wrote:

Yes, this is Stef’s code with my little patch.

No, sorry, I did a diff: identical files.

Bloke · 2012-01-05 15:43:31

uli wrote:

Strikes me that the field shouldn’t show up on the default form page.

Why not? Just because you can’t rename the form doesn’t mean you can’t put it in another category. Even in the current (non-patched) screen I can reassign my default form to the ‘Links’ category if I so desired.

Please explain why you think people should not be able to move it to an arbitrary area of their choosing? (e.g. they could collect all non-deletable forms into one group called “Static”). Might be something I’ve overlooked.

Last edited by Bloke (2012-01-05 15:44:50)

uli · 2012-01-05 15:53:52

Bloke wrote:

Even in the current (non-patched) screen I can reassign my default form to the ‘Links’ category if I so desired.

Thats true, I missed that. But I find it irritating, nevertheless. And in working environments with several people cooperating it might be confusing to not find the default form, counter-intuitively, on its traditional place. Just my 0.02 €.

Bloke · 2012-01-05 16:06:16

uli wrote:

it might be confusing to not find the default form, counter-intuitively, on its traditional place.

So you’re proposing that this patch goes the extra step of removing the select list and text box (or making them static like makss did in his patch-of-my-patch) when anyone is editing a non-deletable form, thus forbidding anyone from moving it to a new category? Seems a bit drastic, but if your view represents the majority then who am I to argue!

Last edited by Bloke (2012-01-05 16:12:43)

uli · 2012-01-09 13:48:51

Bloke wrote:

[…] thus forbidding anyone from moving it to a new category? Seems a bit drastic […]

Hm, the wording is a bit drastic. Would we judge it as a forbiddance if we could avoid the misplacing of our keyrings? (And I was speaking of only the default form, BTW, not any non-deletable.)

MarcoK · 2012-03-01 12:42:47

Bloke wrote:

…anyone wanna try this altered Form panel out where …

I have try and it work fine!
Very good idea and great solution.

It must be included into core code. Maybe the 4.4.2 release? With maybe some other improvement!

Bloke · 2012-03-01 14:36:53

MarcoK wrote:

I have try and it work fine!

Thanks for trying it out: glad it worked ok. I like it too. Unfortunately Robert didn’t like it so it probably won’t make core. Although it’s perhaps possible to control it using a pref like this:

Permit unlimited form types: o No   o Yes   o Yes, defaults protected

With ‘No’ being default behaviour. The final option would satisfy Uli’s request at being unable to move default (undeletable) Form types from their pre-assigned locations. Not sure if this kind of thing would be of benefit or if it makes it too complicated from a support perspective.

MarcoK · 2013-03-08 22:26:15

Bloke wrote:

Permit unlimited form types: o No o Yes o Yes, defaults protected
With ‘No’ being default behaviour. The final option would satisfy Uli’s request at being unable to move default (undeletable) Form types from their pre-assigned locations. Not sure if this kind of thing would be of benefit or if it makes it too complicated from a support perspective.

This is a great idea.

I ask again… include in new version???

Textpattern CMS

Textpattern CMS support forum

#13 2012-01-05 14:03:36

Re: [howto] How to add more Form types

#14 2012-01-05 14:34:47

Re: [howto] How to add more Form types

#15 2012-01-05 15:09:45

Re: [howto] How to add more Form types

#16 2012-01-05 15:29:39

Re: [howto] How to add more Form types

#17 2012-01-05 15:42:17

Re: [howto] How to add more Form types

#18 2012-01-05 15:43:31

Re: [howto] How to add more Form types

#19 2012-01-05 15:53:52

Re: [howto] How to add more Form types

#20 2012-01-05 16:06:16

Re: [howto] How to add more Form types

#21 2012-01-09 13:48:51

Re: [howto] How to add more Form types

#22 2012-03-01 12:42:47

Re: [howto] How to add more Form types

#23 2012-03-01 14:36:53

Re: [howto] How to add more Form types

#24 2013-03-08 22:26:15

Re: [howto] How to add more Form types

Board footer