how do I display one link from a link id entered in custom field?

Gallex · 2010-02-05 11:36:27

tried this:

$('a[@rel$='external']').click(function(){
     this.target = "_blank";
});

and this:

$("a[href^='http://']").attr("target","_blank");

as welll, but neither did help.
what could be wrong in this page? doctype?
i’m trying to open those external links in new window

Last edited by Gallex (2010-02-05 11:54:23)

maniqui · 2010-02-05 12:54:20

You have to wrap that code with jQuery .ready() method:

$(document).ready(function() {
    $('a[@rel$='external']').click(function(){
         this.target = "_blank";
    });
});

Or this:

$(document).ready(function() {
   $("a[href^='http://']").attr("target","_blank");
});

Tutorials:Introducing $(document).ready()

Gallex · 2010-02-05 13:23:56

but still links not opening in new window :(

Gocom · 2010-02-05 14:18:18

Gallex wrote:

but still links not opening in new window :(

Invalid Javascript, that’s why. It won’t work:

Quotes are wrong. ‘I’ am ‘variable’.
Wasn’t @ removed…?
Okay.

Suggestions:

Use an editor that colors/highlights your code (like textedit, notepad++). Makes your life so much easier.
Search. If you did search google, first hit provided correct answer to this case. But that’s just my alternate reality.
1 2

Sometimes learning is better than just ask and abe. It gives you more and eventually you notice that you have so much to give and share to others — or buff-up.

Gallex · 2010-02-06 10:13:18

Gocom wrote:

Invalid Javascript, that’s why. It won’t work:

Quotes are wrong. ‘I’ am ‘variable’.

Wasn’t @ removed…?
Suggestions:

Use an editor that colors/highlights your code (like textedit, notepad++). Makes your life so much easier.

downloaded, installed notepad++
it tells me nothing wrong with that code

$(document).ready(function() {
$('a[rel="external"]').each(function() {
	$(this).attr('target', '_blank');
});
});

or that

$(document).ready(function() {
    $('a[@rel$='external']').click(function(){
         this.target = "_blank";
    });
});

or that

$(document).ready(function() {
   $("a[href^='http://']").attr("target","_blank");
});

Search. If you did search google, first hit provided correct answer to this case. But that’s just my alternate reality.

i did. first code i get from here ,can’t find second one right now…
copy-pasted them to template, re-typed quotes, double-checked the code…nothing

Gocom · 2010-02-06 14:45:12

Gallex wrote:

downloaded, installed notepad++
it tells me nothing wrong with that code

It’s an editor not a miracle-validator. It doesn’t validate your code, it highlights your syntax. That’s what most syntax editors do:

You can clearly see that something is wrong with that code.

Gallex · 2010-02-06 15:00:58

no, i can’t. everywhere is pair of quotes. where’s the trick?

Last edited by Gallex (2010-02-06 15:13:46)

maniar · 2010-02-06 16:38:22

@Gallex – Yes there is something wrong in line 1 and line 3.

You cannot have a single quote within a single quote or a double quote within a double quote.

You need to alternate them for example:

$('a[rel="external"]').
$("a[rel='external']").

Gallex · 2010-02-07 08:37:25

is it correct code now?

$(document).ready(function() {
    $('a[@rel$="external"]').click(function(){
         this.target = "_blank";
    });
});

Gocom · 2010-02-07 09:50:47

Gallex wrote:

is it correct code now?

No. Xpath attribute selectors are still deprecated as of jQuery 1.2 and removed in 1.3 as I earlier said.

Gallex · 2010-02-07 11:49:53

now?

$(document).ready(function() {
$('a[rel="external"]').each(function() {
	$(this).attr('target', '_blank');
});
});

Gallex · 2010-02-08 14:25:23

the above is absolutely correct code, isn’t it?
to open the links with rel=“external” attribute in new window, isn’t it?

but it just not working in this page with jquery-1.4.1.min.js i’m using

maniqui · 2010-02-08 14:40:49

Gallex,

the problem is you are also using another JS library (Prototype) and so, there is a conflict between jQuery and Prototype.
It’s easily fixable using jQuery.noConflict(). Read more here: Using_jQuery_with_Other_Libraries

jens31 · 2010-02-09 10:48:36

like maniqui mentioned, you are using 2 libraries, both react to the selector $

you properly could go with this

jQuery.noConflict(); releases the $ selector, so each jQuery command you write has to begin with jQuery instead of the fancy $
the $ is then again available for the prototype library.

Gallex · 2010-02-09 11:01:18

at last…thank’s maniqui for pointing the problem reason

Textpattern CMS

Textpattern CMS support forum

#16 2010-02-05 11:36:27

Re: how do I display one link from a link id entered in custom field?

#17 2010-02-05 12:54:20

Re: how do I display one link from a link id entered in custom field?

#18 2010-02-05 13:23:56

Re: how do I display one link from a link id entered in custom field?

#19 2010-02-05 14:18:18

Re: how do I display one link from a link id entered in custom field?

#20 2010-02-06 10:13:18

Re: how do I display one link from a link id entered in custom field?

#21 2010-02-06 14:45:12

Re: how do I display one link from a link id entered in custom field?

#22 2010-02-06 15:00:58

Re: how do I display one link from a link id entered in custom field?

#23 2010-02-06 16:38:22

Re: how do I display one link from a link id entered in custom field?

#24 2010-02-07 08:37:25

Re: how do I display one link from a link id entered in custom field?

#25 2010-02-07 09:50:47

Re: how do I display one link from a link id entered in custom field?

#26 2010-02-07 11:49:53

Re: how do I display one link from a link id entered in custom field?

#27 2010-02-08 14:25:23

Re: how do I display one link from a link id entered in custom field?

#28 2010-02-08 14:40:49

Re: how do I display one link from a link id entered in custom field?

#29 2010-02-09 10:48:36

Re: how do I display one link from a link id entered in custom field?

#30 2010-02-09 11:01:18

Re: how do I display one link from a link id entered in custom field?

Board footer