Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#109 2009-08-13 15:20:43
- kevinpotts
- Member
- From: Ghost Coast
- Registered: 2004-12-07
- Posts: 370
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
The error shows in Live mode, but hides in Testing? Is there any line preceding this notice which hints at a plugin causing that message?
Correct. I’ve never seen it before. Here is the actual HTML that precedes my Doctype:
<br />
<b>Strict Standards</b>: Only variables should be passed by reference in <b>/home/.celine/graphicpush/dev.graphicpush.com/textpattern/lib/txplib_misc.php(594) : eval()'d code</b> on line <b>465</b><br />I have no clue if its a plugin; I’ve reviewed the code and I just don’t see anything wonky that would be doing it. I will continue to plug away.
Update: I have systematically removed every piece of code from an offending page, and the error remains, so I’m pretty sure it’s not something in my code.
Last edited by kevinpotts (2009-08-13 15:31:54)
Kevin
(graphicpush)
Offline
#110 2009-08-13 17:26:37
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
In case this post wasn’t read, gd_info JPG Support attribute renamed to JPEG Support for PHP 5.3.0.
It’s the only issue I’ve come across while testing 4.2.0-rc1.
We Love TXP . TXP Themes . TXP Tags . TXP Planet . TXP Make
Offline
#111 2009-08-13 17:53:04
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Thanks, Bert. Fixed in r3267.
Offline
#112 2009-08-13 18:33:49
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Hi,
i´ve just installed the new Version of Textpattern and was very curious about the new “Core support for unlimited custom fields”. Sorry, maybe my English is just to bad (it is really), but what does this exactly mean – “Core support”. The CFs are still in the “textpattern”-table. And what is the role of “glz_custom_fields” … does it mean it works only in cooperation Plugin? – sorry for my, maybe dumb, questions.
Offline
#113 2009-08-13 18:45:31
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
This means that Textpattern core code no longer imposes a hard-coded limit onto the possible number of custom fields.
Off the shelf, the article table contains ten columns for custom fields, but you can add additional ones by either SQL (ALTER TABLE textpattern...) or, more conveniently, by using any suitable plugin.
This design decision is driven by two assumptions:
- Plain vanilla Textpattern sites fit into the ten CFs limit. We want to cater for this slim requirement in core.
- Textpattern sites with extensive use of CFs will probably need a more elaborate user interface which would then be provided by plugins.
glz_custom_fields is currently the only one I am aware of which operates in this realm, but there’s no “magic” which restricts any other plugin from using this new feature.
Offline
#114 2009-08-13 20:40:32
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Okay … I got it:
For one more Custom-Field I had to change :
- “textpattern”: adding a column “custom_11”
- “txp_prefs”: adding a row “custom_11_set”
- “txp_lang”: adding one row for every language called “custom_11_set”
… and it seems to work. Just to be sure. Is this the correct way of adding the extra-fields?
Offline
#115 2009-08-13 20:54:52
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Correct. The changes to txp_lang would last only as long as you do not update languages.
Offline
#116 2009-08-14 18:38:23
- TheEric
- Plugin Author
- From: Wyoming
- Registered: 2004-09-17
- Posts: 566
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
wet wrote:
This means that Textpattern core code no longer imposes a hard-coded limit onto the possible number of custom fields.
Off the shelf, the article table contains ten columns for custom fields, but you can add additional ones by either SQL (ALTER TABLE textpattern...) or, more conveniently, by using any suitable plugin.
Wet,
Wouldn’t it bit a bit more efficient to create a separate table for custom fields (e.g., ID/int article_id/int custom_field_num/int custom_field/varchar255) and have truly unlimited custom fields without resorting to hackish ALTER queries?
Last edited by TheEric (2009-08-14 18:39:17)
Offline
#117 2009-08-14 19:22:59
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
TheEric wrote:
Wouldn’t it bit a bit more efficient to create a separate table for custom fields (e.g., ID/int article_id/int custom_field_num/int custom_field/varchar255) and have truly unlimited custom fields without resorting to hackish ALTER queries?
In terms of efficiency, adding a column is a one-time event, so it’ll be faster to pull one field from one table than to join tables for each cf query. I’m not a fan of the denormalized textpattern table, and altering tables doesn’t seem like the best idea (for the core and plugins). However, based on a previous discussion, plugin compatibility would be the problem, whereas migrating existing user data wouldn’t be very hard. I don’t have a solution for plugins, so I didn’t pursue the patch.
Last edited by jm (2009-08-14 19:23:55)
Offline
#118 2009-08-14 20:17:41
- TheEric
- Plugin Author
- From: Wyoming
- Registered: 2004-09-17
- Posts: 566
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Well, maintaining the status quo just because of compatibility is a bit silly really. This release seems to be making the most significant number of changes, why not some more?
Last edited by TheEric (2009-08-14 20:22:38)
Offline
#119 2009-08-15 00:21:17
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
Well, maintaining the status quo just because of compatibility is a bit silly really
I kind of like compatibility— it makes keeping all my sites on the most current stable release a breeze.
Offline
#120 2009-08-15 03:54:23
Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!
wet, I sent you a login to a site showing the daylight savings time issue. Let me know if you didn’t get it.
Piwik Dashboard, Google Analytics Dashboard, Minibar, Article Image Colorpicker, Admin Datepicker, Admin Google Map, Admin Colorpicker
Offline