Admin Side Theming! (r3149)

thebombsite · 2009-04-14 12:13:00

Here’s mine. It’s the one just beneath the images.

jpdupont · 2009-04-18 07:17:45

Thanks Stuart !

mrdale · 2009-04-18 15:37:16

wet wrote:
I’m aware of this.

Any updates on this?

Last edited by mrdale (2009-04-18 15:38:10)

wet · 2009-04-21 10:21:06

I think r3177 fixes the remaining problems with admin themeing.

Heads up for theme authors: theme::announce() replaces the theme::messenger() method, for the sake of disambiguation.

mrdale · 2009-04-21 15:59:37

sorry, I still have no messages… Firefox 3 mac

Firebug throws the following

[Exception... "'Syntax error, unrecognized expression: [@selected]' when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)" location: "<unknown>" data: no]@

wet · 2009-04-21 16:42:55

When/where/how exactly does this error occur? Any additional plugins loaded? Usual voodoo (clear cache, sacrifice an innocent virgin to the browser gods) performed?

mrdale · 2009-04-24 23:33:05

Wet> does an install of yours display error messages correctly?

phiw13 · 2009-04-25 01:29:54

I have no problems with the display of messages in TXP (default theme or my own theme(s)).
No js errors of any type anywhere.

mrdale · 2009-05-14 16:48:32

Wet> I’m still not seeing alert messages on any of the themes. I’m using firefox mac.

wet · 2009-05-14 16:52:36

Dale, on an unrelated note: Are you currently building yet another winery site? :P

On topic: I might need a login to help you.

mrdale · 2009-05-14 23:27:01

wet wrote:

Dale, on an unrelated note: Are you currently building yet another winery site? :P
On topic: I might need a login to help you.

You’ve got mail.

Yep I’ve built about 10 or 12… Next one’s a YMCA tho.

mrdale · 2009-05-15 19:08:58

OK Guys…

{solved} My apologies to wet. The messages are now appearing just fine. I think that my browser was caching an old version of jQuery.

Bloke · 2009-05-27 08:56:29

Just a, probably naive, question regarding the theme ‘URL’. For compatibility, should txplib_theme.php use:

$this->url = THEME.sanitizeForFile($name).DS;

or are all ‘weird’ characters valid in filenames?

Last edited by Bloke (2009-05-27 08:56:45)

wet · 2009-05-27 09:06:22

Not all weird characters are valid in file names but I think it’s a fair assumption that a theme’s author chooses them within the constraints that are imposed by the goal. But you’re quite right, rawurlencode would eventually seem fit for those borderline coders who use blanks etc. in their directory names ;-)

Bloke · 2009-05-28 01:43:29

wet wrote:

rawurlencode would eventually seem fit for those borderline coders who use blanks etc. in their directory names ;-)

… or those that, for example, use a 3rd party plugin to extend and create their own themes ;-)

Thanks for the pointer. rawurlencode is likely better than sanitizeForFile, so I’ll poke that in the plugin.

Oh, one minor thing missing from classic.php is the screenshot entry in the manifest. The theme has a screenshot.png pic but no reference to it. Is it not used on purpose?

Textpattern CMS

Textpattern CMS support forum

#91 2009-04-14 12:13:00

Re: Admin Side Theming! (r3149)

#92 2009-04-18 07:17:45

Re: Admin Side Theming! (r3149)

#93 2009-04-18 15:37:16

Re: Admin Side Theming! (r3149)

#94 2009-04-21 10:21:06

Re: Admin Side Theming! (r3149)

#95 2009-04-21 15:59:37

Re: Admin Side Theming! (r3149)

#96 2009-04-21 16:42:55

Re: Admin Side Theming! (r3149)

#97 2009-04-24 23:33:05

Re: Admin Side Theming! (r3149)

#98 2009-04-25 01:29:54

Re: Admin Side Theming! (r3149)

#99 2009-05-14 16:48:32

Re: Admin Side Theming! (r3149)

#100 2009-05-14 16:52:36

Re: Admin Side Theming! (r3149)

#101 2009-05-14 23:27:01

Re: Admin Side Theming! (r3149)

#102 2009-05-15 19:08:58

Re: Admin Side Theming! (r3149)

#103 2009-05-27 08:56:29

Re: Admin Side Theming! (r3149)

#104 2009-05-27 09:06:22

Re: Admin Side Theming! (r3149)

#105 2009-05-28 01:43:29

Re: Admin Side Theming! (r3149)

Board footer