Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2007-07-20 07:39:25

gemal
Member
From: Copenhagen, Denmark
Registered: 2007-01-09
Posts: 107
Website

Adding ping functionality

I wonder if there’s a reason for not adding full ping functionality to txp? It seems that when I look at the source code that most of the ping functionality is there.

If I produce a patch will someone look at it?

I seem a _sendPings in txplix_wrapper.php and a do_pings in txp_articles. Not sure why there’s two duplicate functions.

Offline

#2 2007-07-20 07:56:16

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: Adding ping functionality

There’s a plugin which does what you are looking for: glx_admin_ping and can be downloaded from here

Last edited by colak (2007-07-20 07:57:37)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#3 2007-07-20 08:01:14

gemal
Member
From: Copenhagen, Denmark
Registered: 2007-01-09
Posts: 107
Website

Re: Adding ping functionality

colak wrote:

There’s a plugin which does what you are looking for: glx_admin_ping and can be downloaded from here

I still think that this should be included in Txp ifself. Having to edit code to get things working is not some thing for all users :(

Last edited by gemal (2007-07-20 08:01:55)

Offline

#4 2007-07-20 08:59:20

Sencer
Archived Developer
From: cgn, de
Registered: 2004-03-23
Posts: 1,803
Website

Re: Adding ping functionality

gemal wrote:

If I produce a patch will someone look at it?

Sure, please make the patch against crockery.

I seem a _sendPings in txplix_wrapper.php and a do_pings in txp_articles. Not sure why there’s two duplicate functions.

It even says so right there in the comment above the code. The purpose of the wrapper-file is explained in the header of said file. My guess is that pedro wanted to keep interdependencies low in case of future code changes/reorganizations. It was probably meant to be temporary until we had refactored other parts of the code as well.

Offline

#5 2007-07-20 15:25:59

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: Adding ping functionality

gemal wrote:

I still think that this should be included in Txp ifself. Having to edit code to get things working is not some thing for all users :(

It’s a plugin, no core code needs be be edited. It is the code within the plugin Johan is referring to. There are many plugins like that.

Last edited by colak (2007-07-20 15:26:19)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

Board footer

Powered by FluxBB