Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#81 2009-10-02 18:57:46

flowb33
Member
From: Portland, OR
Registered: 2004-02-25
Posts: 11

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Yes. I’m using 1.3.7. Also using 0.6.2 of the upm_image plugin.

I’ve tried changing the view xx pulldown several times, but the errors still appear in the Insert Image pop up.

Offline

#82 2009-10-02 19:47:03

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,225

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Three guesses:
  1. Can’t get back to let the error happen again, but is it more than just ugly?
  2. Didn’t read carefully enough and tried Roberts tip not on the image tab but on the popup.
  3. wet_plugout

In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Online

#83 2009-11-02 03:15:33

seav
Member
From: Philippines
Registered: 2009-11-02
Posts: 2
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

The plugin has a bug where if the image title or alt text (at least any of these two, not sure about the caption) has an apostrophe, the insert Textile and XHTML options fail silently. I think there are PHP escaping issues here.

Offline

#84 2010-11-02 13:09:00

davidcrickett
New Member
From: Denmark
Registered: 2010-10-23
Posts: 3
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

I doesn’t work with the latest svn…


“Time you enjoy wasting, was not wasted.”
- John Lennon

Offline

#85 2010-11-06 15:33:30

zabba
New Member
From: Sweden
Registered: 2009-08-16
Posts: 6

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

True! It breaks in 4.3. Any takers?


“Ahh, The Door! Where’ve you been?”

Offline

#86 2010-11-07 12:24:33

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

sheeeeeet. 4.3 = broken

Offline

#87 2010-11-08 13:08:59

trenc
Plugin Author
From: Cologne
Registered: 2008-02-27
Posts: 565
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Yes it’s broken, because the article form name has changed in 4.3.0

Hotfix:

Open the plugin code and search the javascript function insertTag:

Begin of the function looks like:

function insertTag(type, id, ext, width, height, alt, title)

Two lines below is the following line:

if (window.opener.document.article)

Modify this line to:

if (window.opener.document.article_form)

Now it should work on the article write page again.

I’m sure Mary will fix this shortly.

Last edited by trenc (2010-11-08 13:10:17)

Offline

#88 2010-11-08 13:43:41

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

yo trenc.
you know what?? you are awesome. haha.
dufte gemacht, diggi!!

thx, that fixed it.

Offline

#89 2010-12-06 17:00:12

Niconemo
Member
From: Rhône-Alpes, France
Registered: 2005-04-18
Posts: 557

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Cool !

Veni look for a solution in the forum, vidi the patch, vici the big bad bug.

Thank you Tommy !


Nico

Offline

#90 2010-12-23 21:38:40

els
Admin
From: The Netherlands
Registered: 2004-06-06
Posts: 7,458

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Does anyone know why, when I apply Tommy’s fix and try to save the plugin, it gives me an interal server error?

Edit: never mind, found it.

Last edited by els (2010-12-23 21:42:05)

Offline

Board footer

Powered by FluxBB