Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#85 2010-11-06 15:33:30

zabba
New Member
From: Sweden
Registered: 2009-08-16
Posts: 6

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

True! It breaks in 4.3. Any takers?


“Ahh, The Door! Where’ve you been?”

Offline

#86 2010-11-07 12:24:33

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

sheeeeeet. 4.3 = broken

Offline

#87 2010-11-08 13:08:59

trenc
Plugin Author
From: Amsterdam
Registered: 2008-02-27
Posts: 571
Website GitHub

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Yes it’s broken, because the article form name has changed in 4.3.0

Hotfix:

Open the plugin code and search the javascript function insertTag:

Begin of the function looks like:

function insertTag(type, id, ext, width, height, alt, title)

Two lines below is the following line:

if (window.opener.document.article)

Modify this line to:

if (window.opener.document.article_form)

Now it should work on the article write page again.

I’m sure Mary will fix this shortly.

Last edited by trenc (2010-11-08 13:10:17)

Offline

#88 2010-11-08 13:43:41

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

yo trenc.
you know what?? you are awesome. haha.
dufte gemacht, diggi!!

thx, that fixed it.

Offline

#89 2010-12-06 17:00:12

Niconemo
Member
From: Rhône-Alpes, France
Registered: 2005-04-18
Posts: 557

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Cool !

Veni look for a solution in the forum, vidi the patch, vici the big bad bug.

Thank you Tommy !


Nico

Offline

#90 2010-12-23 21:38:40

els
Moderator
From: The Netherlands
Registered: 2004-06-06
Posts: 7,458

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Does anyone know why, when I apply Tommy’s fix and try to save the plugin, it gives me an interal server error?

Edit: never mind, found it.

Last edited by els (2010-12-23 21:42:05)

Offline

#91 2011-01-11 19:48:44

aksh0925
New Member
Registered: 2011-01-11
Posts: 4

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Mary:

Great Plug-in… having two errors.

Notice: Undefined index: image_list_pageby in /f5/theaksheffect/public/textpattern/lib/txplib_misc.php(638) : eval()’d code on line 416

Notice: Undefined index: image_list_pageby in /f5/theaksheffect/public/textpattern/lib/txplib_misc.php(638) : eval()’d code on line 191

Offline

#92 2011-01-11 20:09:03

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,303

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

#76?


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#93 2011-01-11 20:17:05

aksh0925
New Member
Registered: 2011-01-11
Posts: 4

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Tried that…. but it still says “Insert Failed” when I click on Insert -> Image

Offline

#94 2011-01-11 20:21:29

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,303

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

#87?


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#95 2011-01-11 20:27:12

aksh0925
New Member
Registered: 2011-01-11
Posts: 4

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

Great… thanks! Works!

Offline

#96 2011-01-11 20:30:30

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,303

Re: [plugin] [ORPHAN] upm_img_popper: Minimal image selector

) Not at all!

In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

Board footer

Powered by FluxBB