Textpattern CMS

#25 2006-01-23 06:23:32

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

This may be an esoteric problem. Still: if there haven’t been any comments yet, it seems I can subscribe to an RSS feed, but the Atom feed isn’t there, doesn’t exist, can’t be subscribed to.

#26 2006-01-23 17:54:54

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Ok, updated to v0.4 & hopefully fixed for now.

#27 2006-01-24 01:13:23

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

Yikes — that one brings down the whole site:

Fatal error: Cannot redeclare ajw_comments_feed() (previously declared in /users/home/user/domains/domain.tld/public_html/textpattern/lib/txplib_misc.php(459) : eval()’d code:7) in /users/home/user/domains/domain.tld/public_html/textpattern/lib/txplib_misc.php(459) : eval()’d code on line 13

Last edited by Anark (2006-01-24 01:13:41)

#28 2006-01-24 01:48:57

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

What’s your usage and what version Txp are you on?

#29 2006-01-24 02:06:25

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

I’m on TxP 4.0.3.

I’ve just discovered that I don’t get the error quoted above if I turn off ajw_clean_feed (haven’t tested yet if the feeds actually work).

Usage:

<code><ul>
<li><txp:feed_link label=“Entries (Atom)” title=“XML feed for entries” flavor=“atom” /> </li>

<li><txp:ajw_comments_feed_link sitewide=“y” label=“Comments (Atom)” flavor=“atom” title=“XML feed for comments” /></li>
</ul></code>

#30 2006-01-24 03:29:47

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Strange, I try the identical code on my site (v4.0.3) and it works fine; ajw_clean_feed should have no effect either way. I’ve also tried a few other combinations of tags, with no problems. Hm…

#31 2006-01-24 03:57:10

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

The site still came down after I removed all tags from the Default page, so I reinstalled ajw-clean_feed from scratch — it’s working now.

I may have accidentally messed up ajw-clean_feed while trying to fix the rss_safe_hed() issue that ocurred in ajw_comment_feed 0.3 after the upgrade to TxP 4.0.3. It looks all sorted now.

Sorry for the bother and thanks for fixing the plugin!

#32 2006-01-24 04:01:18

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

No bother at all; it actually alerted me to an unrelated bug in ajw_clean_feed that I’m working out.

Last edited by Andrew (2006-01-24 04:01:54)

#33 2006-01-24 17:49:52

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Update v0.5

#34 2006-01-25 01:24:20

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

Great!

Just because I’m curious: what’s the rationale behind keeping ajw_comments_feed and ajw_clean_feed separate plugins rather than merging them and offering a cleanurl=“y” attribute in the comment feed tag? Saving CPU overhead for those not interested in clean URLs?

#35 2006-01-25 01:41:43

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Sorta yea, and keeping comments feeds functionality separate since not all want comments feeds enabled by default and I don’t want a config.

#36 2006-03-14 21:18:48

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Now, with Mint