upm_img_popper

EddieG5 · 2006-01-03 22:41:59

I’ve upgraded to the latest TXP and am having trouble with Mary’s plugin … I had the .64 version, which I know is sorely out of date. I downloaded the plugin files she just posted, but can’t figure out how to install the plugin. Copying the code from upm_img_popper.php and pasting into the plugin area in Admin posts and error. Has anyone had luck installing?

hakjoon · 2006-01-03 23:34:00

The code for the plugins that Mary posted is not compiled.

It seems that she really is gone unfortunately. All the plugins have been pulled from her site and the plugins are noted as abandoned in the resources site.

I posted a compiled version of 0.10 which was the last version she released.

I’d be willing to take over this plugin if no one else objects since a lot of the image tag work she implemented I wanted to do anyway, but Mary beat me to it in her super human speediness.

Last edited by hakjoon (2006-01-03 23:36:21)

EddieG5 · 2006-01-04 05:06:18

Thanks, hakjoon.

It is unfortunate that Mary has left us … still not sure what happened to cause her departure. At any rate, I think it would be great if you’d be willing to take over this plugin and am sure the rest of the community would as well.

Jeremie · 2006-01-04 05:35:55

Indeed, that would be nice Hakjoon.

The-Exit · 2006-01-05 22:25:01

Thanks for taking over the plugin.

soulship · 2006-01-12 03:49:45

I am having major problems with this on a site since updating to 4.03. The bigest one is that it does not show up at all ;0 any ideas Patrick?

The only js error I see so far is:

Error: p.firstChild has no properties
Source File: http://bllb.com/textpattern/index.php?event=upm_img_popper&js=link_js
Line: 66

Thanks!

Last edited by soulship (2006-01-12 03:50:21)

hakjoon · 2006-01-12 13:25:48

Are you running any other plugins that create links in the left hand column the way img_popper does? It seems like something changing the DOM for the page so that the script can’t figure out where to place the link. The admin panels could be made a lot easier to work with if they had more ID’s there is a lot of DOM traversal gymnastics that needs to happen now that is very prone to breakage.

The plugin is working fine on a write tab with no other plugins running for me. Let me know what you find. Also if youa re running anothe rplugin that is causing this let me know so I can try to make them co-exist.

Last edited by hakjoon (2006-01-12 13:25:56)

soulship · 2006-01-12 14:46:59

Well patrick I was trying to get quick tags and img popper to play together most of the evening and now I’m turned around. It seems that now even with everything else disabled it won’t show at all. The DOM hooks are definitely lacking here. I pulled out your tiny mce and tried to get the imge funtion there working as well to no avail :( . Not super crazy about the markup anyway. So I am back to square 1. I am not sure where the conflict is comoing from at this point. The bas_img something or other plug works and shows in the left collumn fine, and I may have to hard wire that to output an img class for now, just to get me through. I know it’s off topic, but have you seen any compatibility issues with ff1.5 and some of our js DOM capturing plugins? I noticed last night that the mce sometimes works fine and sometimes assembles itself in the bottom left of the window completely outside of the text area. Only in ff 1.5? Strange but true. I may be having a bad plugin week :)

hakjoon · 2006-01-12 15:03:04

Hmmm that’s so weird. I have quicktags and img_popper working happilly together on 4.03.

I can’t imagine what could cause it to not show up at all if the Write tab is in it’s original state. I might try to retrofit this part of Mary’s code as it’s pretty fragile.

There is a newer version of tinyMCE (2.0.1) then the one in my zip if you want to try that, all the custom stuff I have done is in the ibrowser folder under plugins, the rest is all stock so it’s pretty easy to replace. Although I know what you mean about the markup I use quicktags personally.

If you want to post the source of the write tab when the plugin is failing somewhere I can take a look see if I see anything odd that’s happening. That’s helped me narrow down some pretty odd quirks in the past.

variaas · 2006-01-18 07:50:57

hakjoon,

Something I wonder if you or someone could provide a better explanation for other developers. Mary had ability to insert a link into the articles tab, but upon looking at the code I’m completely confused at how she accomplished this. I would really appreciate a better understanding around this.

Thanks!

hakjoon · 2006-01-18 13:16:36

Do you mean how she inserted the code in the article textarea or how she inserted the link for the image popper itself?

variaas · 2006-01-18 14:04:11

I’m looking to understand how she inserted the link for the image popper itself.

hakjoon · 2006-01-18 14:35:35

It’s basically just done by traversing the DOM and creating a link element where you want it to be. The admin interface doesn’t have a lot of DOM of elements with IDs so it makes it a little harder then it needs to be. Currently img_popper uses a fairly frail system to place the link that will break if the admin interface changes. I’m working on an update that is a little more foolproof, but it’s still not as easy as it could be.

So basically you

Create the link using createElement
Then you create and set the attributes the way you want them to be using setAttribute
Basically then you need to insert it somwhere. For img_popper I find the ID for “Advanced Options” using getElementByID and then get the parent using parentNode. Since the Advanced DIV has a Paragraph before it with the link that activates you get that using previousSibling
You can then insert the link in using insertBefore

The basic code looks like
<pre>
<code>
//create the link
var link = document.createElement(‘a’);
link.setAttribute(‘href’, ‘/where/to/link/to/’);

//place it

var node = document.getElementById(‘advanced’);
node.parentNode.insertBefore(link, node.previousSibling);
</code>
</pre>

And that should do it. DOM inspector is your friend for this sort of stuff. “Advanced options” is good because I think it’s always there no matter what preferences you have set (actually I should double check that).

Let me know if that makes sense otherwise I can write a more detailed example. I might move this into textbook if it makes sense.

The-Exit · 2006-03-19 11:20:08

Hi

I’m just thinking of a new feature for this lovely plugin. Sometimes, I’d like to use an image as link. So, it would be great to use links in the customized templates.

I’m thinking of an optional tag, e.g.

In the template, you can put the link whereever you want, unless you specify this option. If the link is not given, no a-tag will be produced.

What do you think?

Cheers, Matthias

hakjoon · 2006-03-19 19:35:54

Is this something that cannot be accomplished with the url attribute?

Textpattern CMS

Textpattern CMS support forum

#1 2006-01-03 22:41:59

upm_img_popper

#2 2006-01-03 23:34:00

Re: upm_img_popper

#3 2006-01-04 05:06:18

Re: upm_img_popper

#4 2006-01-04 05:35:55

Re: upm_img_popper

#5 2006-01-05 22:25:01

Re: upm_img_popper

#6 2006-01-12 03:49:45

Re: upm_img_popper

#7 2006-01-12 13:25:48

Re: upm_img_popper

#8 2006-01-12 14:46:59

Re: upm_img_popper

#9 2006-01-12 15:03:04

Re: upm_img_popper

#10 2006-01-18 07:50:57

Re: upm_img_popper

#11 2006-01-18 13:16:36

Re: upm_img_popper

#12 2006-01-18 14:04:11

Re: upm_img_popper

#13 2006-01-18 14:35:35

Re: upm_img_popper

#14 2006-03-19 11:20:08

Re: upm_img_popper

#15 2006-03-19 19:35:54

Re: upm_img_popper

Board footer