Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2005-12-11 21:27:12

fpradignac
Plugin Author
From: France near Cognac
Registered: 2005-01-29
Posts: 359
Website

comment.php return a "&" in URL

The output of the <code>function commentForm()</code> in comment.php, keep a & in the URL (with messy URL) and not &amp ; to validate.

A little hack in the form output of this function and it works.

françois.


françois

Offline

#2 2005-12-12 00:49:19

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: comment.php return a "&" in URL

More info please. What URL?


Alex

Offline

#3 2005-12-12 06:05:36

Jeremie
Member
From: Provence, France
Registered: 2004-08-11
Posts: 1,578
Website

Re: comment.php return a "&" in URL

If you have a way to clean it, describe it but mostly provide a hdiff patch to do it (on Windows, TortoiseSVN does this with two mouse clicks). It’s probably the simplest way of telling people what to change and where :)

Offline

#4 2005-12-12 09:07:07

fpradignac
Plugin Author
From: France near Cognac
Registered: 2005-01-29
Posts: 359
Website

Re: comment.php return a "&" in URL

In the value of the form tag for action :
<code><form method=“post” action=”/?id=28&c=home#cpreview” id=“txpCommentInputForm”></code>
and at the end in the value for the input tag named backpage :
<code><input type=“hidden” name=“backpage” value=”/?id=28&c=home /></code>

So I’ve just added a very hard and bad hack that replace & by &amp ; in <code>function commentForm()</code>.


françois

Offline

#5 2005-12-12 14:39:32

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: comment.php return a "&" in URL

Specifically: it is the urls on lines # 122, 159 and 160 of comment.php that need escaping.

Offline

#6 2005-12-12 18:34:51

fpradignac
Plugin Author
From: France near Cognac
Registered: 2005-01-29
Posts: 359
Website

Re: comment.php return a "&" in URL

Yes Mary you’re more explicit than me ;-)


françois

Offline

#7 2005-12-12 20:52:32

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: comment.php return a "&" in URL

“…you’re more explicit than me…”

That’s what they all say. ;D

Offline

Board footer

Powered by FluxBB