[archive] ajw_admin_workflow

Joey · 2005-09-08 16:20:08

Thanks Andrew for the info and the fix :) Working good now:)

blumie607 · 2005-10-31 02:16:25

Can you make this work with Freelancers also? So that if the ownership is transferred to a freelancer, they can edit the article?

Thanks

Andrew · 2005-11-08 05:18:40

It shouldn’t have anything to do with permission level; as long as the user has authored the article and is able to edit articles, that user will be able to transfer the ownership. This should be determined by your site’s preferences, located within (for now, at least) admin_config.php. Check to see that you haven’t restricted Freelancers from editing or publishing.

blumie607 · 2005-11-08 05:22:28

Yes, I finally realized that I should check admin_config.php (I thought it died already, but I guess not quite yet…). I did and I edited permissions and it works.

Thanks for your response, though.

soulship · 2005-12-09 22:54:13

Andrew, I’m getting the following error on a 4.02 site….

Notice: Undefined index: view in /users/home/farrah/web/public/textpattern/lib/txplib_misc.php(455) : eval()’d code on line 24

any clues as to how I can make it go bye bye?

Thanks! Jamie

Andrew · 2005-12-10 17:22:26

Are you sure that is related to this plugin? There is a $view variable used in this plugin, but it is initialized properly so will never throw a notice.

Andrew · 2005-12-10 17:23:46

Also, if you are sure it is being caused by ajw_admin_workflow, can you tell me how to reproduce it?

soulship · 2005-12-10 18:16:59

I just started getting it on after installing the plugin on a site i am slowly turning over to a client. I installed it yesterday and started getting the error/warning. I only get it for the page refresh just after transfering ownership of the article. I seems to effect nothing. As soon as the transfer is complete and I refresh the screen or leave and come back to the article that was transfered the error/warning goes away. The transfers complete just fine – as far as I can tell. The client has said nothing to me as yet so I am assuming that they are going through fine. It’s really not a critical thing. I just thought I should alert the person in charge (you) :)

Thanks!
Jamie

Andrew · 2005-12-10 18:39:41

I’ve attempted with all error reporting cranked up on both v4.0.2 and the development versions of Textpattern to reproduce the error, without luck. Perhaps another plugin also uses $_GET['view'] and is unsetting the value?

The textpattern lib gps() function does an isset() check to prevent the possibility of an undefined index notice. Also, there is only one place in which the $view variable is referenced in ajw_admin_workflow, and it directly follows the variable initialization:

   $view = gps('view');
  [...]
if ($view!='html' && $view!='preview') {

So I really don’t see how it’s possible. What other admin plugins do you have active? Do any of them use the ‘view’ querystring variable?

soulship · 2005-12-10 18:48:02

On the “write” the two other plugins that are activated are upm quicktags and bas_image selector. Hold on let me try something….

soulship · 2005-12-10 18:55:01

It’s the damndest thing. Here’s a screen if that tells you anything. I disabled any other plugs and still getting the warning.

Andrew · 2005-12-10 18:57:22

Crank up error reporting by setting production status to ‘debugging’, then try it again. Any additional clues?

soulship · 2005-12-10 19:03:56

Nothing additional with debugging mode turned on. And no other errors on any other admin screens as far as I can see thus far. Sorry that’s not much help. Maybe it’s just a ghost in the machine on burnaby if it’s only effecting this site? Like I said I have this running on several installs on several boxes and have never seen any errors creep up on any of them until now. I don’t see any reason why this would effect the funtionality. i looked at the sql table and everyting is being transfered correctly. So I am back to baffled. How about you? I will chalk this up to gremlin I guess.

Andrew · 2005-12-10 19:09:25

Well, since it is just a php “notice” there’s nothing to worry about. Try putting an @ before the reference to gps('view') in the ajw_admin_workflow source and then we can verify it is in fact the plugin. Modify the line I posted before to this:

$view = @gps('view');

Does that do away with the php notice?

Last edited by Andrew (2005-12-10 19:10:54)

soulship · 2005-12-10 19:37:43

<code>function ajw_admin_workflow($event, $step) { global $txp_user; $confirm = ‘’; // get posted variables $view = @gps(‘view’); $name = gps(‘workflow_id’); $id = gps(‘ID’); $req = array(‘1’,‘2’); // privilege levels with power access</code>

Changes nothing as far as the notice goes. Hmmm.

Textpattern CMS

Textpattern CMS support forum

#16 2005-09-08 16:20:08

Re: [archive] ajw_admin_workflow

#17 2005-10-31 02:16:25

Re: [archive] ajw_admin_workflow

#18 2005-11-08 05:18:40

Re: [archive] ajw_admin_workflow

#19 2005-11-08 05:22:28

Re: [archive] ajw_admin_workflow

#20 2005-12-09 22:54:13

Re: [archive] ajw_admin_workflow

#21 2005-12-10 17:22:26

Re: [archive] ajw_admin_workflow

#22 2005-12-10 17:23:46

Re: [archive] ajw_admin_workflow

#23 2005-12-10 18:16:59

Re: [archive] ajw_admin_workflow

#24 2005-12-10 18:39:41

Re: [archive] ajw_admin_workflow

#25 2005-12-10 18:48:02

Re: [archive] ajw_admin_workflow

#26 2005-12-10 18:55:01

Re: [archive] ajw_admin_workflow

#27 2005-12-10 18:57:22

Re: [archive] ajw_admin_workflow

#28 2005-12-10 19:03:56

Re: [archive] ajw_admin_workflow

#29 2005-12-10 19:09:25

Re: [archive] ajw_admin_workflow

#30 2005-12-10 19:37:43

Re: [archive] ajw_admin_workflow

Board footer