Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#1 2005-11-11 12:57:25
- Suzy
- New Member
- Registered: 2005-08-10
- Posts: 7
rel=nofollow not working?
neither was textile, but I upgraded to 4.0.2 thanks to a previous message in this thread.. however rel=“nofollow still not appearing. I have “Use nofollow on comments? “ checked to yes in admin,
and I have posted a comment since upgrade – any ideas?
css {display: no-problem;}
cms {display: if-and-when;}
Offline
Re: rel=nofollow not working?
confirming the observation rel=“nofollow” does not appear in my comments either using 4.0.2
Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.
Offline
#3 2005-11-12 01:00:58
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: rel=nofollow not working?
Which tag are you using? It’s only added to comment_name, not comment_web.
Offline
Re: rel=nofollow not working?
No. It’s definitely not being added anywhere. It doesn’t work on thebombsite or my test site. This is a bug and needs moving.
Last edited by thebombsite (2005-11-12 02:03:53)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#5 2005-11-12 02:18:03
- Andrew
- Plugin Author
- Registered: 2004-02-23
- Posts: 730
Re: rel=nofollow not working?
More precisely, it’s being added to links in the comment message but nothing else.
Offline
#6 2005-11-12 02:19:13
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: rel=nofollow not working?
Okay. Thread moved.
Offline
#7 2005-11-12 02:25:48
- Andrew
- Plugin Author
- Registered: 2004-02-23
- Posts: 730
Re: rel=nofollow not working?
I think it’s because the global var $txpac isn’t defined within local variable scope inside taghandlers.php -> comment_name()
Actually, aren’t all the prefs extracted? So $comment_nofollow should work in place of $txpac['comment_nofollow'], yea?
(currently trying it out…)
Does this patch solve it for everyone? Seems to work for me.
Last edited by Andrew (2005-11-12 02:35:05)
Offline
Re: rel=nofollow not working?
That works for me on <code><txp:comment_name /></code> thanks Andrew, but I’m not getting rel=nofollow for a link in the comment message either.
Last edited by thebombsite (2005-11-12 02:50:44)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#9 2005-11-12 02:50:37
- Andrew
- Plugin Author
- Registered: 2004-02-23
- Posts: 730
Re: rel=nofollow not working?
Yeah, that’s a separate function. Investigating…
Offline
#10 2005-11-12 02:59:49
- Andrew
- Plugin Author
- Registered: 2004-02-23
- Posts: 730
Re: rel=nofollow not working?
Grab the updated patch – looks like it was a combination of r501 and r1000 that caused the bug. I’ll submit it when I get the ok from one of you that confirms it’s a fix.
Last edited by Andrew (2005-11-22 23:03:56)
Offline
Re: rel=nofollow not working?
OK that’s added rel=nofollow but it’s also added the site URL to the link so I’m seeing <code>http://thebombsite.com/test/http:thebombsite.com/</code>.
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#12 2005-11-12 03:20:31
- Andrew
- Plugin Author
- Registered: 2004-02-23
- Posts: 730
Re: rel=nofollow not working?
Hm… I don’t see that (or how that’d even be possible, based on the changes the patch makes). Are you sure? Do you have an example?
Last edited by Andrew (2005-11-12 03:29:49)
Offline