[plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

davidwang · 2005-11-05 06:19:29

Hmm.. does that mean the plugin is broken in 4.0.2? I think I’ll hold off upgrading just for a while…

Skubidu · 2005-11-05 07:48:44

Okay – i tried the plugin on a new 4.0.2 installation.
The preview itself should work without problems BUT the tags <txp:nhn_comment_submit /> and <txp:nhn_comment_spamsave /> seem to be broken.

I try to solve this as soon as possible, but I’m not at home the next few days, so it might take a few days. There will be a possibility to change the tabindex in the next version, but if you’ve got any other “feature requests” – that’s the time for it.

Nils

akokskis · 2005-11-05 08:24:31

Very odd; I just installed 4.0.2 and set up my site today using your plugin and those two tags seem to be working perfectly well for me. Had a hell of a time getting it all to work like I wanted, but it finally worked out for me. :D
Thanks for such a great plugin.

(For what it’s worth, the site is running the latest revision (rev1090)).

davidwang · 2005-11-05 09:04:25

Nils, take your time man. We appreciate your time and effort for this plugin. If you’re ever in Kuala Lumpur, I’ll buy you a beer ok?

Infi · 2005-11-05 15:51:01

I’ll second that. :D But, to get the beer, you’ll have to be in the States.

squaredeye · 2005-11-05 16:56:51

Nils,

It seems to be working fine for me. Of course, I’m not actually using the preview, only the spamsave and submit without preview function.

One function I think would be helpful would be a javascript type error if someone does not click “spamsave”, currently if someone were to leave a healthy size comment and then inadvertently submit without checking the checkbox, they lose their message and have to retype it.

Their may be a better way to do this, but that’s one area I see that could use some renewal?

So, yeah, a beer? I could draw one for you? Unless you stop into Philly, then we could go to Monk’s, first place in the country to have Chimay on tap!

Thanks,

Matthew

Last edited by ma_smith (2005-11-05 17:01:36)

paularms · 2005-11-05 18:54:13

Everything is working correctly for me on 4.0.2

Neko · 2005-11-06 01:03:20

Just upgraded to 4.0.2 and I’m getting a minor problem when posting comments: they get enclosed into <code><p></p></code> tags. Anyone else is getting the same output as me?

Last edited by Neko (2005-11-06 01:04:05)

Skubidu · 2005-11-07 20:17:06

Hi everybody!

I totally reworked the live comment plugin. This is why I’m looking for some beta tester.
You can download the version 0.4 beta here.

Some new feature:

it’s possible to add tabindex and class attributes to the form elements.
it’s possible to change the text of the anti spam checkbox

Changes:

the wraping div is gone now

Thanks!
Nils

akokskis · 2005-11-07 21:52:29

the wraping div is gone now

Might I suggest that be on option? Something like a “divon” attribute, if =1 then the div is there, =0 its not. Just a thought.

Last edited by akokskis (2005-11-07 21:52:45)

Infi · 2005-11-08 00:36:24

Happy to beta test, since that’s all my site is, actually. :)

1. The comment is still not submitted.

2. nhn_spamsave: I can change the attributes. (Neat. Thank you!) BUT, if the box is not checked, the warning isn’t displayed.

3. The email check is working now, but if an address isn’t entered, it might be more desirable to have the message displayed inline (e.g. under the email textbox) rather than another page. (Just a thought.)

4. No confirmation – again, almost certainly because the comment isn’t finally submitted.

Tabindex works like a dream. Testing with TXP 4.02.

All for now.

Skubidu · 2005-11-08 07:48:23

@akokskis: That’s not necessary – you can add the div yourself by editing the form “nhn_livecommentpreview”. I can add it by default in that form, but most people asked me how to get rid of the div. That’s why I changed the plugin that way.

@Infi: I cannot reproduce your problems: I can submit comments, I have the warnings displayed. By the way – what do you mean by saying “to have the message displayed inline rather than another page”. The warnings are displayed inline over the input boxes (name, email, comment, spamwarn).
Can you please send me your diagnostics, your tag trace and a link to your test site? Thanks!

Nils

Textpattern CMS

Textpattern CMS support forum

#61 2005-11-05 06:19:29

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#62 2005-11-05 07:48:44

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#63 2005-11-05 08:24:31

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#64 2005-11-05 09:04:25

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#65 2005-11-05 15:51:01

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#66 2005-11-05 16:56:51

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#67 2005-11-05 18:54:13

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#68 2005-11-06 01:03:20

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#69 2005-11-07 20:17:06

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#70 2005-11-07 21:52:29

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#71 2005-11-08 00:36:24

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#72 2005-11-08 07:48:23

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Board footer