[plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Skubidu · 2005-09-30 20:51:54

Hello everybody!

I was thinking about using the well-known live comment hack described by Jon Hicks on my website. Alexandra asked for it, too. Because I don’t like hacking the code, I tried to get the whole hack in a plugin:

nhn_livecommentpreview: Live comment preview

new version 0.5 beta (23.01.2006): see here

version 0.3.1 (09.10.2005): download | more information | made for TXP 4.0.1
- fixed small bug (checking for <txp:nhn_comment_submit />)

version 0.3 (08.10.2005):
- fixed bug in <txp:nhn_comment_spamsave />
- added magic quotes and n-dash support

version 0.2 (02.10.2005)
- NOTE: The plugin name and the tag names have changed in this version. Please check the help for further information

version 0.1 (30.09.2005)

Last edited by wet (2009-08-13 15:04:04)

jonhicks · 2005-09-30 21:05:08

Excellent! However, I don’t think it should be named after me. The code all came from other people, I just used their hard work!

soulship · 2005-09-30 22:29:01

Great work! I will try this out over the weekend.

Thanks!
Jamie

druzli · 2005-10-01 16:34:18

Hey Skubidu.

Nice plugin, but I have a “small” problem :).

Followed your instructions and did not use the optional tags, wanted to see the functionality first.
Now I dont even see my comment form on the page.

I can see in my source that the JavaScript is there but no comment form whatsoever.
My website
(In Icelandic)

Running latest revision of Textpattern(rev989)

Any ideas?

Last edited by druzli (2005-10-01 16:40:18)

Skubidu · 2005-10-01 16:45:00

Hi druzli!

I’m not sure, why this is happening. I have not yet tried the plugin on the latest revision, I just tried the latest stable release.
Can you post the code of some of your forms, please? I’m interested how comments_display and nhn_hickslivepreview look like.

Your form comments_display should look something like this:
<txp:comments />
<txp:if_comments_allowed>
<txp:nhn_comments_form />
</txp:if_comments_allowed>

Last edited by Skubidu (2005-10-01 16:45:40)

druzli · 2005-10-01 16:57:51

Hey Skubidu.

In my tryings to get comments back on, I deleted all your tags and the plugin, and my comment form wont show up again. Was working before.

I first tryed the plugin with 4.0, maybe that is the cause of this ?

The nhn_hickslivepreview:
<code><h3>forskoða</h3>
<txp:nhn_hlp_author />:
<txp:nhn_hlp_preview />
<p class=“posted”><txp:nhn_hlp_date /></p></code>

The comments_display:
<code><txp:comments />
<txp:if_comments_allowed>
<txp:nhn_comments_form />
</txp:if_comments_allowed></code>

Now I have to find a way to find my commentsform again, any ideas ?

:)

Skubidu · 2005-10-01 17:05:54

That’s strange! The plugin doesn’t delete anything. If you change <txp_nhn_comments_form /> back to <txp:comments_form /> everything should work as it did before.

Have you changed anything else?

druzli · 2005-10-01 17:13:48

hehe, my fault.
Was missing an “s” in <code><txp:comments_form /></code>

Now I have my form back.

But im gonna try out your plugin again, will post my resaults later on or tommorow.

THX

davidm · 2005-10-01 20:21:37

skubidu, this is one nice plugin :-)

I love John’s hack, cool feature and all, but hacks are quite bothersome to maintain and a plugin is definitely the way to go… thanks a lot ! I’ll try this one and report…

Destry · 2005-10-02 07:02:09

I’ll be happy to give this a whirl sometime, after the name of this plugin changes, as was kindly suggested by Mr. Hicks.

Skubidu · 2005-10-02 07:11:51

I’m sorry, if you don’t like the name. As I started using Textpattern a year ago, I learned to know about this live preview as the “Hicks live preview” – that’s why it’s named like this.

What would you prefer? Just “nhn_livepreview” or “nhn_livecommentpreview”? For me it’s just a name to know what the plugin is all about – I can change it, if you like it.

Destry · 2005-10-02 07:26:32

Skubidu, it’s not about liking the name or not, and we certainly don’t think you meant anything but full respect, it’s just that Jon made it clear the live comment preview stuff was not of his origin, so it’s simply not appropriate to name it after him, or you could (indirectly) put Mr. Hicks in a bad position. Also, as a potential user of the plugin, I don’t want to be advertising a wrongly named product on my Web site.

Why not just name it nhn_livecommentpreview, and in your documentation make it clear where the code history comes from?

Textpattern CMS

Textpattern CMS support forum

#1 2005-09-30 20:51:54

[plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#2 2005-09-30 21:05:08

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#3 2005-09-30 22:29:01

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#4 2005-10-01 16:34:18

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#5 2005-10-01 16:45:00

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#6 2005-10-01 16:57:51

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#7 2005-10-01 17:05:54

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#8 2005-10-01 17:13:48

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#9 2005-10-01 20:21:37

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#10 2005-10-02 07:02:09

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#11 2005-10-02 07:11:51

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

#12 2005-10-02 07:26:32

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Board footer