Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2005-02-22 03:24:36

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

'Fixed' admin CSS

I spent a few minutes fixing the reported (by TopStyle) errors and warnings in textpattern.css. Also, tweaked / cleaned / optimised the code: textpattern.css.

Last edited by David_1cog (2005-02-22 03:26:43)


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#2 2005-08-03 10:32:02

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

… and a one more time (based on rev. 712):

  • removed some redundancy
  • added generic fonts where necessary
  • better use of inheritance
  • alphabetised
  • tweaked the code so that cursor indicates that tabs can be clicked (nice if that could be pulled in to core)

textpattern.css

Last edited by David_1cog (2005-08-03 10:36:13)


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#3 2005-08-03 11:21:57

Jeremie
Member
From: Provence, France
Registered: 2004-08-11
Posts: 1,578
Website

Re: 'Fixed' admin CSS

You should mail it to Dean.

Offline

#4 2005-08-03 23:49:08

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: 'Fixed' admin CSS

Crap, I just did this. shakes fist at David ;D

Don’t stick with alphabetizing: you could have very strange things happen with cascading. Sort by tags, then classes, then ids.

Offline

#5 2005-08-06 10:54:13

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

Jeremie, is that correct procedure around here? If The Powers That Be see value in what I’ve done, they can use it and / or discuss in this thread. I’ll nudge Dean with a PM in case this hasn’t been spotted.

Mary, “Crap, I just did this” – do you have a problem? What is it? Let me know and I’ll fix it. :) There’s no problem with alphabetising as I have done, provided the CSS inheritance is coded ‘properly’ / explicitly. Besides, you seem to be advocating what I have already done – elements (tags), classes (generic), ids (unique)!


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#6 2005-08-06 13:47:25

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: 'Fixed' admin CSS

David,

Yep, the correct procedure, all patches are welcome. They may or may not get used, but submitting a patch makes it real easy for the devs to roll it in. Info is here. This is where, if you’re on Windows, TortoiseSVN is tremendously useful. :)

Ah, I forgot that the css file explicitly set the class’ element (input.classname vs classname). Move along people, nothing to see here. ;D

Last edited by Mary (2005-08-06 13:47:38)

Offline

#7 2005-08-06 16:21:15

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

Thanks, Mary – I’ve Tortoised a patch and offered it up for Dean and The Team.


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#8 2005-08-06 17:00:12

Dean
Founder (Gone, but not forgotten)
From: Languedoc
Registered: 2004-02-14
Posts: 235
Website

Re: 'Fixed' admin CSS

Got it, thanks. Will testdrive today.


text*

Offline

#9 2005-08-20 20:22:20

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

Another small polish (r821):
  • stop ‘jumping’ text when hover over ‘?’ on several tabs (e.g. ‘import’)
  • make ‘?’ consistent size, font + colour across all pages
  • fix (almost) truncated ‘Continue’ button on ‘import’ tab (plus other buttons now sized according to text + padding)
  • fixed font typo ‘Time’ -> ‘Times’
  • added class <code>td.header{background:#ffcc33;}</code>, ready for someone to replace <code>style=“background:#FFCC33”</code> with <code>class=“header”</code> in txplib_head.php :)
  • fixed alignment on ‘site admin’ tab for user rows + ‘tightened up’ alignment in a few other areas
  • a little more tidying for inheritance, etc.

Same link as before: textpattern.css.

Post any gremlins here and I’ll fix.


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#10 2005-08-20 23:11:50

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

  • minor Firefox issue fixed
  • add tweak to force Firefox / Opera vertical scrollbars when content less than page height (to stop horizontal ‘jumping’ when scroll bars appear)
  • text in tabs now have equal padding / vertical centre across all browsers
One issue I couldn’t fix with CSS:
  • ‘presentation … pages’ – the <code><textarea></code> has inline styling (<code>style=“height:500px;width:600px;font-family:monaco,courier,courier new;font-size:10px;margin-top:6px”</code>) which looks OK in IE / Opera but not too legible in Firefox. Maybe just assign it a class and let the stylesheet sort it out?

Same link as before: textpattern.css.


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#11 2005-08-25 12:20:45

pbrada
New Member
From: Pilsen, CZ
Registered: 2004-04-30
Posts: 6
Website

Re: 'Fixed' admin CSS

David_1cog wrote:
One issue I couldn’t fix with CSS: ‘presentation … pages’ – the <code><textarea></code> has inline styling (<code>style=“height:500px;width:600px;font-family:monaco,courier,courier new;font-size:10px;margin-top:6px”</code>) which looks OK in IE / Opera but not too legible in Firefox. Maybe just assign it a class and let the stylesheet sort it out?

In my textpattern install, I have tried to solve this so that (also) the textareas have consistent sizes between tabs. Maybe the mod can be of some help here – I have posted a set of cutouts that show how to set textarea sizes via the CSS by changing the text_area() function and modifying the textpattern.css. Of course, it requires to rewrite all inline HTML+style for textareas into the call to the function.

(I didn’t want to end-up with dozens of textarea classes, so I opted for a “standard” set of width/height dimensions in the stylesheet which fit well into the text_area() function interface. Maybe a cleaner solution could be to use classes like “textarea_big { width: 100px; height: 400px }” and change the function params.)

Premek

Offline

#12 2005-12-30 10:12:09

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

Updated for 4.03: fixes missing generic font name for two new classes added in 4.03; alphabetised to match existing format; includes previous tweaks and improvements (puzzlingly not included in core ;)).

textpattern.css


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#13 2006-05-06 15:58:43

David_1cog
Member
From: Bristol, England
Registered: 2004-09-09
Posts: 58
Website

Re: 'Fixed' admin CSS

Re-worked again, taking in to account some changes made to the current SVN branch CSS. I’ve chopped out a lot of redundant code, improved display consistentcy and generally tarted things up (in a similar style to TextBook).

I’ve used input pseudo class for submit buttons, so best to use Firefox or Opera9 if you want pretty buttons, as IE does not recognise input pseudos.

textpattern.css


David @ 1 Cog
“Follow the shoe!” … “No, follow the gourd!”

Offline

#14 2006-06-20 21:08:39

jamiew
Archived Plugin Author
From: NYC
Registered: 2005-01-08
Posts: 74
Website

Re: 'Fixed' admin CSS

Thank you David — this is a drastic improvement over the standard textpattern.css, especially the fonts.

Any chance you could direct your expertise with the admin layout to produce something fluid? Hate how the textareas don’t resize — I know Rob wrote some javascript to do it, but even those arn’t fluid, and there’s that nasty flicker on initial resize.

Offline

Board footer

Powered by FluxBB