mrh_email_article_link

colak · 2005-07-12 14:11:51

hi aesop.. the warnings dispappeared. It might have been my fault as I probably did not upgradr all the documents with the particular svn. I am currently using svn483 and there are no warnings.
For your info this is how I use this tag:
In a cusom field I have: <code><txp:mrh_email_article_link subject=“Title of each article” /></code>
In the default form I have<code>
<ul>
…
<txp:if_custom_field name=“custom1”><li><txp:custom_field name=“custom1” /></txp:if_custom_field>
<txp:if_custom_field name=“custom2”><txp:custom_field name=“custom2” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom3”><li><txp:custom_field name=“custom3” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom4”><li><txp:custom_field name=“custom4” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom5”><li><txp:custom_field name=“custom5” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom6”><li><txp:custom_field name=“custom6” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom7”><li><txp:custom_field name=“custom7” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom8”><li><txp:custom_field name=“custom8” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom9”><li><txp:custom_field name=“custom9” /></li></txp:if_custom_field>
<txp:if_custom_field name=“custom10”><li><txp:custom_field name=“custom10” /></li></txp:if_custom_field></ul></div>
<txp:body /> 
<txp:rsx_frontend_edit_link prefix=” [” suffix=”]”>Edit</txp:rsx_frontend_edit_link>
</txp:if_individual_article></code>…

colak · 2005-07-12 14:14:05

On another subject
I had to go into the sourse of the plugin where I changed your &s into ‘& amp ;’ as the plugin produces invalid xhtml otherwise. As far as I could see, it appeared in two (&body) instanses

Last edited by colak (2005-07-12 14:14:50)

aesop1 · 2005-07-12 15:11:24

Ah, I will update the plugin today. The invalid XHTML is the result of my cutting and pasting my modified source from the TXP plugin “edit” window when I updated the plugin for RC3. I did originally have the <code>’&amp’</code> there instead before the browser rendered them for me. Let that be a lesson to me!

Thanks for the catch and the clarification.

Last edited by aesop1 (2005-07-12 15:14:42)

mjarecki · 2005-07-14 00:20:21

Hi

I’ve discovered a problem that this plug-in (in addition to upm_img_popper 0.6.3) causes on my system. I’m using Rev 486 and mrh_email_article_link 0.2. The plug-in works fine on my normal pages but seems to kill my RSS feeds with the following error message ahead of the correct RSS code:

<code>
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined index: s in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 14 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
</code>

Any ideas?

Cheers

Mark

mjarecki · 2005-07-14 01:08:02

I seem to have fixed the problem, regarding mrh_email_article_link. It seems that it causes problems when used in an actual article and can only be used within an article form. Using the following at the top of an article page with Textile on seems to be causing issues with RSS:

<txp:mrh_email_article_link />
</code>

Mark

aesop1 · 2005-07-14 04:07:02

Yes, Mark, I would think that would be the culprit. Although some other people seem to have been able to use it elsewhere (depending on the plugin combo they have installed), the assumed use of the plugin is within a single article form since that is where the plugin’s variables are certain to be available. Glad you got it working. I’ll have to check out upm_image—that Mary writes a mean plugin!

aesop1 · 2005-07-14 04:21:24

Colak,

I just followed up and took a look at your site (nice, btw) to see how the plugin was being used. I noticed that on a few pages we were seeing duplicate subfolders (or sections perhaps) in the email article links. This tends to happen if $siteurl is being set with the TXP admin interface (the place where you type in the site URL and subfolder if any) with a subfolder. As far as I can tell, this may be snafu with TXP.

As it turns out, this creates a problem for the plugin since it assembles the URL with duplicate subfolders or section as the case may be. What you might try doing — offline preferably — is removing the site url from the Admin interface entirely (actually leaving it blank). I believe Zem or someone indicated that TXP can figure out your site url without this info.

If this doesn’t work we will have to figure something else out. Sorry to place this here, but I don’t know how else to reach you.

Matt

Last edited by aesop1 (2005-07-14 04:30:45)

colak · 2005-07-14 06:41:54

Hi aesop
Thanks for spotting it!
I have the textpattern isntall in a subfolder called main.
I have deleted the site url from the admin interface but the particular problem is still there.
I have also changed my privacy perferences should you wish to contact me directly…

aesop1 · 2005-07-14 13:46:30

Darn. We’ll need to put in some programming that will take into account a subfolder. I’ll take a look at this later today or this evening.

aesop1 · 2005-07-15 14:21:48

Colak, I have been buried with work, but I should get to taking a look at the plugin issue next week. The probable solution will be to examine the $siteurl string for a subfolder and then trim that from the string.

Note to other users: this will only effect users with subfolders defined in the “Site URL” of the admin “Site preferences area.

colak · 2005-07-16 09:16:09

thanks aesop1, I’m really looking forward to your next release

aesop1 · 2005-07-16 18:39:32

Plugin updated to 0.3 to deal with the $siteurl subfolder issue. Let me know how it’s working.

Thanks,

Matt

colak · 2005-07-17 07:48:45

Perfect! worked like a dream!
Thanks aesop !!!

Last edited by colak (2005-07-17 08:05:08)

aesop1 · 2005-07-17 14:49:02

Good to hear. Thanks for the feedback, Colak.

june · 2005-08-22 16:35:51

Hi,

I’m having some validation problems. The email article link validates fine on most pages. But when I click on a date in my mdp_calendar…the email article link on that date page does not validate.

And it doesn’t say there is anything wrong with the calendar links, just the email article link. Here is what the link looks like:

http://domain.com/?month=2005-08-01&s=events

I’m guessing when the calendar generates that link, the & is really an & amp; but when the email article generates that link the & is only an &.

Any suggestions on how to fix this?

thanks!

june

Last edited by june (2005-08-22 16:37:47)

Textpattern CMS

Textpattern CMS support forum

#16 2005-07-12 14:11:51

Re: mrh_email_article_link

#17 2005-07-12 14:14:05

Re: mrh_email_article_link

#18 2005-07-12 15:11:24

Re: mrh_email_article_link

#19 2005-07-14 00:20:21

Re: mrh_email_article_link

#20 2005-07-14 01:08:02

Re: mrh_email_article_link

#21 2005-07-14 04:07:02

Re: mrh_email_article_link

#22 2005-07-14 04:21:24

Re: mrh_email_article_link

#23 2005-07-14 06:41:54

Re: mrh_email_article_link

#24 2005-07-14 13:46:30

Re: mrh_email_article_link

#25 2005-07-15 14:21:48

Re: mrh_email_article_link

#26 2005-07-16 09:16:09

Re: mrh_email_article_link

#27 2005-07-16 18:39:32

Re: mrh_email_article_link

#28 2005-07-17 07:48:45

Re: mrh_email_article_link

#29 2005-07-17 14:49:02

Re: mrh_email_article_link

#30 2005-08-22 16:35:51

Re: mrh_email_article_link

Board footer