Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2005-04-22 04:30:12

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

hi all, i’ve updated the plugin to reflect the wishes from your responses. new is the class which is applied to the comment-invite and the handling of the nocomment-string. if no nocomment-string is given, the invitation of the article-form is used. if no comment-invitation should be shown at this point, the nocomment-attribute has to be empty (but set).

I also removed several bugs. the description above and the history should be extensive enough. if not, please ask.


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

#14 2005-04-22 04:32:47

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

@lee: I am working on the extension with the name of the latest commentator. give me some days ;)


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

#15 2005-04-22 07:47:59

lee
Member
From: Normandy, France
Registered: 2004-06-17
Posts: 831

Re: [archived] gho_comments_invite

Wow, thanks.

Offline

#16 2005-04-23 08:26:09

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [archived] gho_comments_invite

Yay! Thanks for this! I’ve just made a small change on my copy – taking out the span and putting the class attribut in the link tag.

$out .= '<a href="'.permlinkurl($thisarticle).'#'.gTxt('comment').'" class="'.$class.'">'.$before.'</a>';


Cheers,
Jon VC#9

Offline

#17 2005-04-25 04:52:46

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

@jonhicks: I decided to take a span because I’m intending to make it configurable what exactly will be linked, the whole invitation or only the part without numbers or whatever. so with the span around you can take the class to format the whole line and with “span.classname a” will be able to format the link itself.

without this (maybe) further developing setting the class into the link would of course be the better/shorter solution.


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

#18 2005-04-25 08:57:34

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [archived] gho_comments_invite

Its hard to know. Some people would put the link in something like a paragraph tag, and maybe give that a class, some would prefer a span for extra flexibility. Its not a big problem anyway, and it was a small tinker to remove the span.

Its a great plugin anyway – thanks!


Cheers,
Jon VC#9

Offline

#19 2005-05-01 19:35:52

lee
Member
From: Normandy, France
Registered: 2004-06-17
Posts: 831

Re: [archived] gho_comments_invite

@graumeister: I am working on the extension with the name of the latest commentator. give me some days ;)

Just wondering if this is still in the works.

Thanks
Lee

Offline

#20 2005-05-02 04:30:50

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

I worked the weekend on the plugin, just now its on the notebook and will be transfered this evening.


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

#21 2005-05-02 08:45:36

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

@lee: the update is online. I made a new tag named gho_last_commentator which shows the “last commented by”-line. It it not yet fully configurable. Maybe it would be useful to link the name to the specific comment?


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

#22 2005-05-02 09:53:12

lee
Member
From: Normandy, France
Registered: 2004-06-17
Posts: 831

Re: [archived] gho_comments_invite

Thanks for taking the trouble to do this. I’ll test it out.

Offline

#23 2005-05-03 05:43:23

bleveck
Member
Registered: 2004-05-30
Posts: 52
Website

Re: [archived] gho_comments_invite

what would be the regular expression for “comes from google and the query has both word1 and word2 in it”?

Offline

#24 2005-05-03 06:31:41

graumeister
Plugin Author
From: Ban Bang Por, Samui, Thailand
Registered: 2005-01-16
Posts: 167
Website

Re: [archived] gho_comments_invite

that could be a little problem because eventuelly the forumsoftware will cut letters out. lets try ;)

(.*)\.google\.(.*)search?(.*)q=([^+]*)word1([^+]*)word2(.*)

might be a dirty way but should work. (not tested)


Samui? Samui! (about the life as farang in thailand)
David’s Neighbour

Offline

Board footer

Powered by FluxBB