Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#13 2004-09-15 14:33:40
- igner
- Plugin Author
- Registered: 2004-06-03
- Posts: 337
Re: Could my comments.php hacks be a plug-in?
whoops – on item 3 above, I neglected to mention that you need to then drop the assignment and evaluation of $class…otherwise you’ll get some funky results.
And then my dog ate my badger, and the love was lost.
Offline
Re: Could my comments.php hacks be a plug-in?
Igner, Thats really useful thanks. PHP is not my first language (or my second, third…), so its really useful to get your feedback, and learn slicker ways of doing it. I’ll implement those when I get a chance.
Thanks also for solving that problem with the template – that makes sense now!
Cheers,
Jon VC#9
Offline
#15 2004-09-15 14:43:41
- igner
- Plugin Author
- Registered: 2004-06-03
- Posts: 337
Re: Could my comments.php hacks be a plug-in?
It’s nice to be able to give back occasionally. Would that there were more time in the day to do so.
BTW – you’ve probably found it already, but FileMerge is in /Developer/Utilities.
And then my dog ate my badger, and the love was lost.
Offline
Re: Could my comments.php hacks be a plug-in?
Yeah found that – thanks! Never knew what it could do though!
Cheers,
Jon VC#9
Offline
Re: Could my comments.php hacks be a plug-in?
Is it possible to programmatically rename a function? If so, then you could use a tag function in a plugin to rename the saveComment() and popComments() functions to orig_saveComment() and orig_popComments(), and then have yours put in their place. I know this type of thing is possible in Tcl and like languages, but I haven’t done enough with PHP to know whether this language is as priviledged.
Offline
#18 2004-09-15 20:37:59
- igner
- Plugin Author
- Registered: 2004-06-03
- Posts: 337
Re: Could my comments.php hacks be a plug-in?
That’s what I’m going to look at – from a cursory inspection, it doesn’t appear to be the case. Though I haven’t given up hope yet…
And then my dog ate my badger, and the love was lost.
Offline
Re: Could my comments.php hacks be a plug-in?
I’ve attempted to make some of the changes noted in textpattern notes part 2 to my RC1 install but I’m not having very much luck.
I am trying to do steps 2 and 3 to change the comment output to use divs instead of lis. I made these changes to my comment.php and uploaded it but the changes don’t apply when I refresh my page. Somehow my comments are still being formatted in an ordered list even though the code is most definitely changed.
Anyone have an idea of whats going on here? I would appreciate any help.
Offline
Re: Could my comments.php hacks be a plug-in?
Rob, could you send me your comments.php file?
BTW – you’re not using Safari by any chance? Could be an issue with Safari’s over-eager cache.
Cheers,
Jon VC#9
Offline
Re: Could my comments.php hacks be a plug-in?
> jonhicks wrote:
> Well skEdit support would just make my day!
I’ve documented all the changes I made here:
http://www.hicksdesign.co.uk/journal/527/textpattern-notes-part-2
http://www.hicksdesign.co.uk/journal/528/textpattern-notes-part-3
The large part of the changes were from Justin Low, who worked out how to remove the need to preview comments first. The whole comments.php file can be downloaded here
Hi. i’m getting a 404 on your comment.zip. any chance you could fix the link? thanks!
I see the moon, and the moon sees me.
God bless the moon, and God bless me.
Offline
Re: Could my comments.php hacks be a plug-in?
Fixed. Sorry, I’d removed the file some time ago
Cheers,
Jon VC#9
Offline
Re: Could my comments.php hacks be a plug-in?
Any chance of reviving the zipped file location? I am slow right now and was hoping to play with this but can’t find the copy that I saved anywhere and I don’t have my old laptop to hunt deeper>
Thanks!
Jamie
Last edited by soulship (2005-04-18 22:15:17)
Offline