[plugin] [ORPHAN] ebl_image_edit v1.0

TheEric · 2020-12-24 01:10:01

Awesome! I was reminiscing back to my pre-attorney days and saw that this hadn’t been updated. Was thinking of ways to get myself more time to start some hobby-level dev work. Those mockups look stellar. I might suggest some fancy thumbnail generation functionality as well from the original (similar to how image edit did).

Bloke · 2020-12-24 01:30:26

TheEric wrote #327778:

Was thinking of ways to get myself more time to start some hobby-level dev work.

Please do! Your work is excellent.

I might suggest some fancy thumbnail generation functionality as well from the original (similar to how image edit did).

Yeah, thumbnail generation is something I’ve been banging around my head a lot. See GitHub issue 1472 for lots of back-and-forth over whether to generate pre-defined image sizes or (better, imo) on-the-fly images at a set of breakpoints you choose at any time, cached after first generation. If you have any thoughts on this, by all means weigh in.

TheEric · 2024-12-04 05:43:47

Wut?

TheEric · 2024-12-12 05:33:50

I’m working on a rewrite of this. I’m not exactly thrilled with the latest changes that break most everything that existed previously.

TheEric · 2024-12-13 02:20:22

Update – Note, keeping updates here because this may not pan out and I might fizzle back into more work related stuff at some point. If that happens, I’ll leave where I’m at on my github.

TheEric · 2024-12-14 20:34:04

For anyone following along, this officially works with 4.8.8 now. If/When 4.9 comes out, I’ll deal with that.

I’m not releasing it yet because I would like a couple more features added to it.

jakob · 2024-12-15 07:50:19

Cool! Great that you’ve brought it up to date. One’s got so used to prepping images in advance that I only realise how much some of this functionality is missing when I show others how to use Textpattern.

4.9 is already in a very good and stable position and I – and I think others – use it actively nowadays. Certainly the UI in the image pane has remained stable for a long while, and changes that affect the UI (like the preview pane developments right now) are rare. If you can and are willing, I think you could definitely cater for 4.9 now.

Bloke · 2024-12-15 08:32:36

If it’s any use, I do have an images branch floating around that I could merge up to date. Although it uses Intervention, which may not be the route we eventually take in Txp 5, it adds core hooks to the images panel for transforms. A bunch of transforms are predefined at present (rotation, flipping, etc) with unlimited undo/redo steps and I’ve written an extension plugin that adds brightness/contrast to demonstrate the hooks.

It’s ugly as all sin at the moment, but it works. I was struggling with crop as it needs JavaScript that’s beyond my pay grade.

As I say, this may not be the way we ultimately move: it depends on how we implement multiple thumbs, but I’m happy to open up my meddling if it helps. You might be able to leverage some of it or suggest better ways to do it in core, or submit a PR that does it way better than I have.

Btw. I’m not entirely sure how many transforms, if any, we should supply as standard. Thoughts on that are also welcome.

etc · 2024-12-15 10:58:27

Bloke wrote #338536:

Btw. I’m not entirely sure how many transforms, if any, we should supply as standard. Thoughts on that are also welcome.

I would rather reduce core to a vital minimum: define data structure, store and retrieve data. Transforms (even Textile) look more like plugin territory. But my experience with images is close to zero, they might require some special treatment.

TheEric · 2024-12-22 05:14:48

I would agree. Keep core functionality separate. Perhaps introduce core plugins?

Bloke · 2024-12-22 08:19:43

TheEric wrote #338614:

I would agree. Keep core functionality separate. Perhaps introduce core plugins?

Yep, that’s a good shout.

We have the notion of core plugins available already. Anything beginning com_. com_connect, com_article_image, …

TheEric · 2024-12-22 08:39:45

That whole idea feeds into my modularization idea I’ve had for TXP for a while. e.g. Don’t like/want comments? Remove the module.

TheEric · 2024-12-23 06:09:56

I’ve changed the look and feel a lot from the above. The buttons there were just ugly. It would be nice if there was a second/tertiary menu in the hive design patterns. I’m catering to the Hive theme primarily. If there are other themes that get used, I’ll provide a way for the CSS to be modified to suit it, but thats not something I’m getting into. Same with language localization.

All original functionality works as it did from version 2.0. Advanced functionality is being created to address some of the requests of the past ten years as shown in the advanced panel. Note – none of them are activated/working yet, so they’re all disabled currently. The icons will be finalized once I get closer to getting it completed.

New upcoming features:

Add Watermark
Brighten
Darken
Sharpen
Blur
Desaturate
Colorize

Issues:

Crop generally works with the resized images though its not as precise as math positioning from a smaller image to the original. I’m debating making the image go full size when the crop is activated to avoid this.
Acvanced feature not implemented yet

Github:

Everything is being updated to my github but is currently private. If I lose motivation or get swamped with work, I may open it publicly.

jakob · 2024-12-23 08:14:24

TheEric wrote #338622:

I’ve changed the look and feel a lot from the above. The buttons there were just ugly. It would be nice if there was a second/tertiary menu in the hive design patterns.

I’m guessing the closest is the “Buttonset” (.nav-tertiary class) in the UI Buttons group. I think you used that already in an earlier iteration.

BTW: your screenshot looks good but doesn’t show. My browser says the certificate is invalid. EDIT: just seen that’s already been mentioned in the other thread.

TheEric · 2025-01-04 02:02:56

The pictures should all work now. I made the mistake of using network solutions when Google Domains shut down.

Textpattern CMS

Textpattern CMS support forum

#256 2020-12-24 01:10:01

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#257 2020-12-24 01:30:26

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

TheEric wrote #327778:

#258 2024-12-04 05:43:47

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#259 2024-12-12 05:33:50

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#260 2024-12-13 02:20:22

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#261 2024-12-14 20:34:04

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#262 2024-12-15 07:50:19

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#263 2024-12-15 08:32:36

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#264 2024-12-15 10:58:27

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Bloke wrote #338536:

#265 2024-12-22 05:14:48

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#266 2024-12-22 08:19:43

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

TheEric wrote #338614:

#267 2024-12-22 08:39:45

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#268 2024-12-23 06:09:56

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

#269 2024-12-23 08:14:24

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

TheEric wrote #338622:

#270 2025-01-04 02:02:56

Re: [plugin] [ORPHAN] ebl_image_edit v1.0

Board footer