dev-demo site: Preview panel fails to openin Safari

phiw13 · 2024-11-17 00:58:27

Browser: Safari 18.1 release and latest Safari TP

On the dev-demo site, log in and view Write panel, default article

Safari release.
Click on the Preview link
The Preview panel does not open
Console:

Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'nopane.classList') (textpattern.js 2210)

Safari TP
performing the same actions:
The panel opens (text view)
Toggling to HTML view: a blank panel. Nothing in the error console. Inspecting the space where content should go: the <div id="pane-preview" class="html"> and the shadowDOM container do not exist. Trying to toggle back to the text preview results in the same blank panel.

Both browsers work fine (all actions performed as expected, no errors) on my localhost test sites and on two remote servers sites, all running latest TXP 4.9-dev.

This has been going on for at least the past week, and who knows how much longer (hat least since this testing).

etc · 2024-11-17 09:00:18

Certainly a stale cache, there is no nopane constant in the current textpattern.js.

I also have noticed that this file is often outdated on our demo sites.

phiw13 · 2024-11-17 09:36:33

Despite not often visiting dev-demo, and usually force reloading before entering, that might be the case indeed.

I see this: textpattern.js Cache-Control: max-age=31536000. Might be a good idea to shorten that to 3 hours (Cache-Control: max-age=10800), the maximum life time of the site as far as I understand.

etc · 2024-11-17 09:54:53

Force-reload does not help, it looks like cache happens on the server side.

phiw13 · 2024-11-18 05:57:39

Force-reload (option-cmd-R in Safari) didn’t work but I was able to get it working by going: Safari Settings > Privacy > Manage website data and search for and delete textpattern.co. That is not great though.

The 3 relevant headers (for textpattern.js) as far as I can see:

Cache-Control: max-age=31536000
cf-cache-status: MISS
cf-ray: 8e45af2a4e2796b8-KIX

As I noted above Cache-Control should be set something more reasonable. I wonder too, is it Cloudflare caching (much) more than necessary? I suppose Pete has some control over that.

gaekwad · 2024-11-18 09:37:50

I’ll fix that. Please stand by.

gaekwad · 2024-11-18 09:46:14

phiw13 wrote #338271:

The 3 relevant headers (for textpattern.js) as far as I can see:

Cache-Control: max-age=31536000...

As I noted above Cache-Control should be set something more reasonable. I wonder too, is it Cloudflare caching (much) more than necessary? I suppose Pete has some control over that.

Given the nature of the dev site rebuild processes, it’s now set more aggressively than before:

Cache-Control: max-age=14400

Last edited by gaekwad (2024-11-18 09:46:42)

gaekwad · 2024-11-18 15:53:32

Aside: I’ve set up github.com/textpattern/server-site-support to help track these things.

Please open issues for any improvements, over and above “this ain’t working, pal” – both types of messages are appreciated (albeit differently).

phiw13 · 2024-11-19 03:04:20

gaekwad wrote #338274:

Given the nature of the dev site rebuild processes, it’s now set more aggressively than before:

Cache-Control: max-age=14400...

Thanks that will hopefully solves the stale textpattern.js.

Textpattern CMS

Textpattern CMS support forum

#1 2024-11-17 00:58:27