Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2024-04-26 17:35:03

colin99
Member
Registered: 2005-11-15
Posts: 68

Comment error with TXP 4.9 DEV

Forgive me if this is the wrong place for this question -
I see that TXP 4.9 handles comments in kind of a new way — meaning that the comments php functionality/location is in a new home.
Despite having the most up to date PHP on my server (8.3) [and I dropped it down to 7.3 to see if that was the issue…]
any attempts at adding comments to content results in the errors (and here is a chunk…)

Fatal error: Uncaught Error: Call to undefined function Textpattern\Tag\Syntax\comments_preview() in /home/——/public_html/txp2/textpattern/vendors/Textpattern/Tag/Syntax/Comment.php:183 Stack trace: #0

There is more, obviously, but this is a starting point.


On the World Wide Web since Day 1 – Editor/Creator – Coffeecrew.comCoffee.bc.ca
Twitter – Twitter.Com/CoffeeCrew -

Offline

#2 2024-04-27 04:50:58

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,102
Website

Re: Comment error with TXP 4.9 DEV

Can you provide some more details – context, comment set up, etc ?

Comments on my side (with TXP4.9.0-dev and both PHP 8.2 and 8.3) work flawlessly.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#3 2024-04-27 05:18:54

colin99
Member
Registered: 2005-11-15
Posts: 68

Re: Comment error with TXP 4.9 DEV

I am running the 4.9 DEV according to Stef Dawson’s instruction —
Got the DEV ZIP from GitHub — downloaded it —
Rsync’ed the files over my old 4.8.8 install…

Error is as follows…

Fatal error: Uncaught Error: Call to undefined function Textpattern\Tag\Syntax\comments_preview() in /home/——/public_html/txp2/textpattern/vendors/Textpattern/Tag/Syntax/Comment.php:183 Stack trace: #0 [internal function]: Textpattern\Tag\Syntax\Comment::comments_form(Array, NULL) #1 /home/——/public_html/txp2/textpattern/vendors/Textpattern/Tag/Registry.php(138): call_user_func(Array, Array, NULL) #2 /home/——/public_html/txp2/textpattern/lib/txplib_publish.php(534): Textpattern\Tag\Registry->process(‘comments_form’, Array, NULL) #3 /home/dxerca/public_html/txp2/textpattern/lib/txplib_publish.php(423): processTags(‘comments_form’, ‘’, NULL, false) #4 /home/dxerca/public_html/txp2/textpattern/publish/taghandlers.php(2084): parse(‘\n<txp:comments_…’, true) #5 [internal function]: if_comments_allowed(Array, ‘\n<txp:comments_…’) #6 /home/——/public_html/txp2/textpattern/vendors/Textpattern/Tag/Registry.php(138): call_user_func(‘if_comments_all…’, Array, ‘\n<txp:comments_…’) #7 /home/——/public_html/tx in /home/——/public_html/txp2/textpattern/vendors/Textpattern/Tag/Syntax/Comment.php on line 183

I can switch between any version of PHP; 7.2 to 8.X


On the World Wide Web since Day 1 – Editor/Creator – Coffeecrew.comCoffee.bc.ca
Twitter – Twitter.Com/CoffeeCrew -

Offline

#4 2024-04-27 06:27:12

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,102
Website

Re: Comment error with TXP 4.9 DEV

At first sight, I don’t know…

Does the Admin > Diagnostics panel tell anything ?


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#5 2024-04-27 12:39:48

etc
Developer
Registered: 2010-11-11
Posts: 5,084
Website GitHub

Re: Comment error with TXP 4.9 DEV

That’s a bug, sorry. Should be fixed now, thanks for the report.

Offline

#6 2024-04-27 18:05:54

colin99
Member
Registered: 2005-11-15
Posts: 68

Re: Comment error with TXP 4.9 DEV

etc wrote #337122:

That’s a bug, sorry. Should be fixed now, thanks for the report.

Bravo — I corrected line 183 in comment.php and we are rolling —
I encourage folks to download the 4.9 DEV and have fun — it is pretty solid at this point.


On the World Wide Web since Day 1 – Editor/Creator – Coffeecrew.comCoffee.bc.ca
Twitter – Twitter.Com/CoffeeCrew -

Offline

Board footer

Powered by FluxBB