com_connect - form and contact mailer

trenc · 2021-07-26 16:34:40

Thanks Stef,

I’ve just found out: If you set break to a value, the default attribute is parted by this break value. So the default value is somewhere handled as list and then outputted after a whole list-array-split-join process.

Bloke · 2021-07-26 16:40:18

Ah yeah. Might be because empty break is being treated as “default list separator” which is comma.

trenc · 2021-07-26 16:55:02

Hm, but where is this applied on the default attribute?

Bloke · 2021-07-26 16:57:35

trenc wrote #331146:

Hm, but where is this applied on the default attribute?

Probably in core’s atts handler, although it might be in the plugin’s lAtts().

If memory serves, it depends what’s passed in. If we pass null it might use the default but if we pass in "" then it might use it verbatim. Or perhaps vice versa. I’d have to refresh my memory. Or Oleg might chime in.

trenc · 2021-07-26 17:01:30

Ah yes,
if I set the break attribute directly in the plugin code to null will do as workaround.

etc · 2021-07-26 17:43:04

Bloke wrote #331147:

Probably in core’s atts handler, although it might be in the plugin’s lAtts().

Rather the latter, since com_connect_lAtts() does not handle the global break introduced recently.

Bloke · 2021-07-26 20:42:20

etc wrote #331149:

Rather the latter, since com_connect_lAtts() does not handle the global break introduced recently.

In which case the plugin needs fixing to do so.

phiw13 · 2021-08-01 06:11:17

Textpattern 4.8.7 / PHP 8.0.2
Latest version of the plugin: 4.7.0+ (PHP file downloaded from Github)

Issue: email subject line failure.

It appears something is not parsed correctly when trying to generate a custom subject line with a form (nearly verbatim from the help file). The “subject” <select /> tag outputs correctly when used in the body of the email.

<txp:php>
    global $com_connect_form;
    echo 'Contact [site name] - ' . $com_connect_form['Subject'];
</txp:php>

Output: Contact [site name] - array.

In debug mode, we get the whole error report inserted in the subject line (see below) – complete with entities etc.

<txp:com_connect_select break="" class="" label="Subject" name="subject">
<txp:com_connect_option class="" label="{Select one}" selected />
<txp:com_connect_option class="" label="Some" value="Some" />
<txp:com_connect_option class="" label="Thing" value="Thing" />
<txp:com_connect_option class="" label="Or other" value="Or other" />
</txp:com_connect_select>

Debug mode output (copied from raw source of message):

Subject: <pre dir="auto">Tag error: <b>&lt;txp:php&gt;     global $com_connect_form;     echo &#039;Contact [site name] - &#039; . $com_connect_form[&#039;Subject&#039;]; &lt;/txp:php&gt;</b> -> <b> Warning: Array to string conversion while parsing form <strong>contact_subject</strong> on page <strong>default</strong></b></pre> <pre class="backtrace" dir="ltr"><code>textpattern/publish/taghandlers.php:4365 eval() php() textpattern/vendors/Textpattern/Tag/Registry.php:140 call_user_func() textpattern/lib/txplib_publish.php:544 Textpattern\Tag\Registry-&gt;process() textpattern/lib/txplib_publish.php:406 processTags() textpattern/lib/txplib_misc.php:3414 parse() textpattern/plugins/com_connect/com_connect.php:227 parse_form() com_connect() textpattern/vendors/Textpattern/Tag/Registry.php:140 call_user_func() textpattern/lib/txplib_publish.php:544 Textpattern\Tag\Registry-&gt;process()</code></pre>Contact [site name] - Array

etc · 2021-08-01 19:30:33

Bloke wrote #331150:

In which case the plugin needs fixing to do so.

Maybe done, but needs someone to test.

phiw13 · 2021-08-02 05:37:47

etc wrote #331183:

Maybe done, but needs someone to test.

hmmm… as I am messing with a contact form, a quick test. Odd this:

Input:

<txp:com_connect_select break="" class="" label="Subject" name="subject">
...
<txp:com_connect_option class="" label="Something" value="Something" />
...
</txp:com_connect_select>

expected output:

<option value="Something" label="Something">Something</option>

actual output:

Something<br />
<option value="Something" label="Something">Something</option>

Note the loose Something<br /> at the start of line.

colak · 2021-08-02 07:26:44

What kind of output does <txp:com_connect_option class="" label="" value="Something" /> return?

phiw13 · 2021-08-02 07:43:49

colak wrote #331185:

What kind of output does <txp:com_connect_option class="" label="" value="Something" /> return?

Output in both my working copy and the most recent patched version (Olegs patch):

<option value="Something"></option>

(when you click/tap open the select, it shows a blank line, as expected given the outputted HTML)

Textpattern CMS

Textpattern CMS support forum

#301 2021-07-26 16:34:40

Re: com_connect - form and contact mailer

#302 2021-07-26 16:40:18

Re: com_connect - form and contact mailer

#303 2021-07-26 16:55:02

Re: com_connect - form and contact mailer

#304 2021-07-26 16:57:35

Re: com_connect - form and contact mailer

trenc wrote #331146:

#305 2021-07-26 17:01:30

Re: com_connect - form and contact mailer

#306 2021-07-26 17:43:04

Re: com_connect - form and contact mailer

Bloke wrote #331147:

#307 2021-07-26 20:42:20

Re: com_connect - form and contact mailer

etc wrote #331149:

#308 2021-08-01 06:11:17

Re: com_connect - form and contact mailer

#309 2021-08-01 19:30:33

Re: com_connect - form and contact mailer

Bloke wrote #331150:

#310 2021-08-02 05:37:47

Re: com_connect - form and contact mailer

etc wrote #331183:

#311 2021-08-02 07:26:44

Re: com_connect - form and contact mailer

#312 2021-08-02 07:43:49

Re: com_connect - form and contact mailer

colak wrote #331185:

Board footer