Textpattern CMS

#1 2021-05-12 01:34:47

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

txp:output_form tag generates error with empty forms

As of TXP 4.8, the output_form tag generates an error if the form exists but is empty:

Tag error: <txp:output_form form="empty" /> ->  Textpattern Notice: Form not found. empty while parsing form None on page default
textpattern/lib/txplib_misc.php:3152 trigger_error()
textpattern/lib/txplib_misc.php:3186 fetch_form()
textpattern/publish/taghandlers.php:535 parse_form()
output_form()
textpattern/vendors/Textpattern/Tag/Registry.php:141 call_user_func()
textpattern/lib/txplib_publish.php:541 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:447 processTags()
textpattern/lib/txplib_misc.php:3281 parse()
textpattern/publish.php:727 parse_page()
index.php:74 textpattern()

If the form contains something – even just a space character – the error is not generated.

Any reason for this change in behaviour?

#2 2021-05-12 06:38:38

etc

Developer

Registered: 2010-11-11

Posts: 5,053

Website GitHub

Re: txp:output_form tag generates error with empty forms

gomedia wrote #330107:

As of TXP 4.8, the output_form tag generates an error if the form exists but is empty:

Tag error: <txp:output_form form="empty" /> -> Textpattern Notice: Form not found. empty while parsing form None on page default...

If the form contains something – even just a space character – the error is not generated.

Any reason for this change in behaviour?

No recent change, this bug must have been there since ages. Should be fixed now, thanks and sorry!

---

bloatware

#3 2021-05-12 06:47:55

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: txp:output_form tag generates error with empty forms

etc wrote #330108:

No recent change, this bug must have been there since ages. Should be fixed now, thanks and sorry!

Thanks for that! Very happy to fall into a hole … for the team.

Problem doesn’t exist on TXP 4.7, so something’s definitely changed since then.