Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2021-04-02 09:45:10

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,468
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

phiw13 wrote #329648:

So can we expect a quick 4.8.6 bug-fix follow up

Probably.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#14 2021-04-02 10:19:58

etc
Developer
Registered: 2010-11-11
Posts: 5,240
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

phiw13 wrote #329648:

So can we expect a quick 4.8.6 bug-fix follow up (the ever lying feedreader told me about it) or do I better patch up 4.8.5 if I want to use that (PHP 8 fixes, and something) ?

You can already copy 4.8.6 publish.php file, awaiting its release.

Offline

#15 2021-04-02 12:07:35

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,225
Website

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

etc wrote #329650:

You can already copy 4.8.6 publish.php file, awaiting its release.

Yes sure I can do that, or copy-paste the noted “fix” etc.
The problem is that the problem I saw is not on one of my sites, but a client’s site. Once you modify one or other file, you get that nice message in Diagnostics:

Some Textpattern files have been modified: …

Not sure I am confortable leaving it like that. Personally that is fine, dunno what the site owner/admin will think1, even if explained nicely.

The site is doing fine with Textpattern 4.8.4 so no real hurry (and potential changes are not depending on any new 4.8.5 feature). Runs on PHP 7.4.

–^–

1 … will think now, or in a week or two when he has forgotten all what I told him.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#16 2021-04-02 13:42:32

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,280
GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

I’ve set up a 4.8.6 demo for testing (will be gone after release):

dev-demo.textpattern.co/4.8.6/

Get your credentials from www.textpattern.co/demo

Offline

#17 2021-04-03 07:03:48

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,640
GitHub Twitter

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

phiw13 wrote #329652:

Yes sure I can do that, or copy-paste the noted “fix” etc.
The problem is that the problem I saw is not on one of my sites, but a client’s site. Once you modify one or other file, you get that nice message in Diagnostics:

Some Textpattern files have been modified: …...

Here is the MD5 code for this file in replacement of the current one into the checksums.txt:

fb869f2fcdf0b8d1e3782b908945689a


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#18 2021-04-03 08:36:35

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,225
Website

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

Pat64 wrote #329658:

Here is the MD5 code for this file in replacement of the current one into the checksums.txt:

fb869f2fcdf0b8d1e3782b908945689a

Yeah, that would work to eliminate that Diagnostics warning. Thanks for the idea.

(I actually got a different MD5 value for the file I downloaded earlier and uploaded to one of my own sites. Calculating the MD5 is easy anyway: md5 path/to/file.ext)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#19 2021-04-03 09:04:10

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,468
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

If you’ve cloned the Textpattern toolbelt you can also rebuild the checksums en masse:

php /path/to/textpattern-toolbelt/release/checksums.php /path/to/repo/textpattern rebuild

The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#20 2021-04-07 06:03:51

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,225
Website

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

This morning I did a second attempt at upgrading the site I mentioned above. This time, thanks to a modified publish.php and an updated MD5 for the checksums.txt file I was successful.

Bloke wrote #329662:

“Textpattern toolbelt[…]

Interesting and noted, thanks. I have no immediate need for a mass change in Textpattern Core files, but who good to know anyway.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#21 2021-05-06 19:25:04

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 305
Website GitHub Twitter

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

Hello,
updated two sites and there I used some „older” variables within txp:php for a side menu. Somehow the behaviour has changed, so I got this warning:
Warning: Undefined variable $pretext while parsing form ...

in this function:

                        <txp:php>
                          global $id_current_art;
                          if (!$id_current_art) $id_current_art = $pretext['id'];                          
                          if ($id_current_art == article_id())
                            echo ' class="active"';                          
                        </txp:php>

And active class is never used, because id_current_art will never be even article_id().

In History.txt I found only mentioned the pre-pretext_end callback.

The PHP version is 8.0.5.

Btw. on the Download page the Release notes are still linking to 4.8.4 😀

Last edited by whocarez (2021-05-06 19:27:56)

Offline

#22 2021-05-06 19:41:31

etc
Developer
Registered: 2010-11-11
Posts: 5,240
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

Yep, I have removed the (unused) global $pretext declaration from php() function, sorry. You’ll need to declare it yourself now:

    global $id_current_art, $pretext;

Offline

#23 2021-05-06 19:46:12

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 305
Website GitHub Twitter

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

Thanks for your quick response. That made it!

Offline

#24 2021-05-06 21:05:22

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,468
Website GitHub

Re: Feedback for: Textpattern CMS 4.8.5 released: bug fixes & improvements

whocarez wrote #330049:

on the Download page the Release notes are still linking to 4.8.4 😀

Ooops, mea culpa. Fixed, thank you.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

Board footer

Powered by FluxBB