Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

bici · 2020-12-07 17:51:53

since Christ was a baby my config file has had the opening and closing tags:

<?php
$txpcfg['db'] = 'foods_txp';
$txpcfg['user'] = '******';
$txpcfg['pass'] = '******';
$txpcfg['host'] = 'localhost';
$txpcfg['table_prefix'] = '';
$txpcfg['txpath'] = '/home/me/apex/stuff_app/textpattern';
$txpcfg['dbcharset'] = 'utf8';
define('PROTOCOL', 'https://');
?>

i never noticed that the config-dist.php files that comes with the distribution did NOT have a closing tag:

?>

If i recall when we install textpattern are we not given the config..php file to replace the one that came with the distribution ? which has the closing tag?

EDIT: obfuscated your user/pass.

jakob · 2020-12-07 18:03:39

It doesn’t matter if it does or doesn’t have a closing tag, so both should work.

gaekwad · 2020-12-07 18:10:28

bici wrote #327336:

If i recall when we install textpattern are we not given the config..php file to replace the one that came with the distribution ? which has the closing tag?

The config-dist.php is an example of what can be done, not necessarily would should be done, and your own site/server setup will have its own settings.

The config.php is not included so if you merge the new release into your site, it won’t nuke any config.php, though if you go full bore and overwrite /textpattern it will probably zap your config anyway, and a restore from backup will be needed.

whocarez · 2020-12-10 19:03:01

Updated all five sites from 4.8.3 to 4.8.4. No big problems yet. Recognized only, that the notice A new Textpattern version (4.8.4) has been installed. came up only in English.

I also switched from php 7.4.13 to php 8.0.0 and linked to that I got some errors in two plugins.

Fatal error: Array and string offset access syntax with curly braces is no longer supported

This problem I could solve by replacing these curly braces {} with square brackets [].

Despite of that I got a few warnings.

etc_pagination
<txp:etc_pagination range="5" prev="<" next=">" wraptag="" break="" pgcounter="pg" current="here" /> -> Warning: Undefined array key 1

smd_thumbnail
<txp:smd_thumbnail_info type='128px' item='w' /> -> Textpattern Notice: Unbekanntes Tag-Attribut: type.

aks_article
Warning: Undefined array key "aks_article_scope"
Warning: Trying to access array offset on value of type null
both in
textpattern/plugins/aks_article/aks_article.php:40 aks_article_doArticles()

But all plugins seem to work, as they should.

Textpattern version: 4.8.4 (b1d8d97c3c8ac6238394682e3c76a8d6)
Last update: 2020-12-10 16:51:47/2020-11-29 15:45:21
Textpattern path: __TXP-ROOT/textpattern
Article URL pattern: title_only
Production status: live
Temporary directory path: __TXP-ROOT/textpattern/tmp
PHP version: 8.0.0
GD Graphics Library: 2.2.5; Supported formats: GIF, JPEG, PNG, WebP.
Server timezone: Europe/Berlin
Server local time: 2020-12-10 19:49:08
Daylight Saving Time enabled?: 0
Automatically adjust Daylight Saving Time setting?: 1
Time zone (GMT offset in seconds): Europe/Berlin (3600)
MySQL: 5.5.5-10.5.8-MariaDB-1:10.5.8+maria~buster-log (mariadb.org binary distribution) 
Database server time: 2020-12-10 19:49:08
Database server time offset: 0 s
Database server timezone: SYSTEM
Database session timezone: SYSTEM
Locale: de_DE.UTF-8
Site / Admin language: de / de
Web server: nginx/1.18.0
PHP server API: fpm-fcgi
RFC 2616 headers: 0
Server OS: Linux 4.19.0
Admin-side theme: hive 4.8.4
Active plugins: 
	adi_gps-0.4
	aks_cache-0.3d
	aks_header-0.4.1
	arc_twitter-4.5.0 (modified)
	com_connect-4.6.0
	css_rating-0.1b
	etc_cache-0.2.4
	etc_pagination-0.4.7b
	ied_plugin_composer-1.2.1
	jnm_no_reset_time-0.1
	pap_comconnect-0.1.2
	peg_nested_comments-0.2.5
	smd_textile_bar-0.1.1
	smd_thumbnail-0.6.1
	the_video-0.8
	tru_tags-3.9.2 (modified)
	wcz_utf8_url-0.1.6

Update

Logging in in Debug mode, brings up a lot of warnings for values from txp_pref:

Warning "Undefined array key "max_custom_fields""
in /var/www/ahrens/textpattern/vendors/Textpattern/DB/Core.php at line 245.

textpattern/vendors/Textpattern/DB/Core.php:245 adminErrorHandler()
textpattern/include/txp_auth.php:342 Textpattern\DB\Core->checkPrefsIntegrity()
textpattern/include/txp_auth.php:50 doTxpValidate()
textpattern/index.php:150 doAuth()

Warning "Undefined array key "ied_plugin_editor""
in /var/www/ahrens/textpattern/vendors/Textpattern/DB/Core.php at line 245.

textpattern/vendors/Textpattern/DB/Core.php:245 adminErrorHandler()
textpattern/include/txp_auth.php:342 Textpattern\DB\Core->checkPrefsIntegrity()
textpattern/include/txp_auth.php:50 doTxpValidate()
textpattern/index.php:150 doAuth()

.....

Last edited by whocarez (2020-12-10 20:53:00)

etc · 2020-12-10 22:06:25

whocarez wrote #327411:

etc_pagination
<txp:etc_pagination range="5" prev="<" next=">" wraptag="" break="" pgcounter="pg" current="here" /> -> Warning: Undefined array key 1

Thanks for the report, these warnings should be fixed now.

Textpattern CMS

Textpattern CMS support forum

#21 2020-12-07 17:51:53

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

#22 2020-12-07 18:03:39

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

#23 2020-12-07 18:10:28

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

bici wrote #327336:

#24 2020-12-10 19:03:01

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

#25 2020-12-10 22:06:25

Re: Feedback for: Textpattern CMS 4.8.4 released: PHP 8.0 compatible

whocarez wrote #327411:

Board footer