Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#11 2020-06-20 16:59:41

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,983

Re: Some article_custom kung fu - articles with both of 2 categories

Much obliged, sirs – thank you very much. I will report back!

Offline

#12 2020-06-21 13:32:46

etc
Developer
Registered: 2010-11-11
Posts: 3,686
Website

Re: Some article_custom kung fu - articles with both of 2 categories

I’ve made

<txp:article_custom match="Category1, Category2" category="foo, bar" />

in dev act as Pete asks, i.e. yield both Category1, Category2 be in foo, bar. This is more consistent with general AND logic of match, where categories were an exception. The previous OR behaviour is obtained with

<txp:article_custom match="Category" category="foo, bar" />

or simply by omitting match attribute. Dunno whether to merge it into 4.8.2, it’s potentially not bw-compatible, though the risk is tiny.

Offline

#13 2020-06-21 13:47:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,456
Website

Re: Some article_custom kung fu - articles with both of 2 categories

I like that! I’d say it’s 4.8.2 worthy, if you can extract that commit only from dev and stick it in the 4.8.2 branch (or, I guess, just repeat what you did in 4.8.2, whichever’s easier). As you say, since virtually nobody used it that way, I think we’re safe doing it.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#14 2020-06-21 13:51:51

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,983

Re: Some article_custom kung fu - articles with both of 2 categories

Wow! Very nice! Thanks, Oleg – much appreciated.

Offline

#15 2020-06-21 14:06:18

etc
Developer
Registered: 2010-11-11
Posts: 3,686
Website

Re: Some article_custom kung fu - articles with both of 2 categories

Bloke wrote #323871:

I like that! I’d say it’s 4.8.2 worthy, if you can extract that commit only from dev and stick it in the 4.8.2 branch (or, I guess, just repeat what you did in 4.8.2, whichever’s easier). As you say, since virtually nobody used it that way, I think we’re safe doing it.

Okay, if nobody objects, it will go into 4.8.2 too.

Offline

#16 2020-06-21 14:42:24

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,987
Website

Re: Some article_custom kung fu - articles with both of 2 categories

etc wrote #323873:

Okay, if nobody objects, it will go into 4.8.2 too.

I’m sure it will be of use!!! Please do!


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | NeMe @ github | Covid-19; a resource
I do my best editing after I click on the submit button.

Offline

Board footer

Powered by FluxBB