Feedback to: Textpattern CMS 4.8.1 Released

gaekwad · 2020-05-31 06:14:11

Please provide any feedback here related to Textpattern 4.8.1 Released.

We appreciate all feedback. Please check the issue queue before raising a problem.

colak · 2020-05-31 15:38:24

Thanks so much guys. Updated and I am experiencing no obvious hitches.

Dragondz · 2020-06-02 11:20:42

Hi

Updated a website form 4.6.2 to 4.8.1 without a hitch, i had only updated the Glz custom field to the newer version (thanks jacob for this).

Thanks Devs.

NB. I tryed to use php 7.3 but got error message then i stuck to 7.1 (The 7.2 version seems to have problem to be setting in my hosting)

Vienuolis · 2020-06-02 13:44:39

Thank you, upgraded two websites today, in seconds.

And a few dozen minutes to rewrite image captions from my custom txp::figure. Sorry, I am not a programmer, and do not quite understand my former code :(

	<figure>
<txp:image yield="id" /> <txp:if_yield>
<figcaption><txp:yield escape="tidy,textile" /></figcaption> <txp:else />
<txp:image_info yield="id" escape="tidy,textile" wraptag="figcaption" /> </txp:if_yield>
	</figure>

Which now returns only number “1” (with no quotes) instead of description from a Caption field of the image.

I would be grateful for some solution to restore former copying of caption from a database, when it is not provided in an article.

Last edited by Vienuolis (2020-06-02 13:44:57)

colak · 2020-06-02 13:49:33

Vienuolis wrote #323494:

Thank you, upgraded two websites today, in seconds.

And a few dozen minutes to rewrite image captions from my custom txp::figure. Sorry, I am not a programmer, and do not quite understand my former code :(

<figure>...

Which now returns only number “1” (with no quotes) instead of description from a Caption field of the image.

I would be grateful for some solution to restore former copying of caption from a database, when it is not provided in an article.

Do you have that snippet in a form and then call it in the articles?

Bloke · 2020-06-02 14:25:12

Vienuolis wrote #323494:

now returns only number “1” (with no quotes) instead of description from a Caption field of the image.

Drat. It only happens if used inside <txp:if_yield> so I suspect it’s to do with the shortcode ‘else’ capability. Damn damn damn. We must get some unit testing in place for at least the tag suite. I’m going to elevate this as a priority.

Doesn’t even work if you try and cheat by setting the caption beforehand:

<figure>
<txp:image yield="id" />
<txp:variable name="caption"><txp:image_info yield="id" wraptag="figcaption" escape="tidy,textile" /></txp:variable>
<txp:if_yield>
   <figcaption><txp:yield escape="tidy,textile" /></figcaption>
<txp:else />
   <txp:variable name="caption" />
</txp:if_yield>
</figure>

Sorry for the hassle. In the meantime, Oleg or someone might be able to come up with a clever workaround or tag structure until we figure out what’s going on.

Last edited by Bloke (2020-06-02 14:26:07)

jakob · 2020-06-02 14:46:00

Do you have any luck when you don’t use yield as an attribute of another tag? (I didn’t even know about that). Something like this:

<txp:images id='<txp:yield name="id" />'>
<figure>
     <txp:image />
<txp:if_yield>
     <txp:yield escape="tidy,textile" wraptag="figcaption" />
<txp:else />
     <txp:image_info escape="tidy,textile" wraptag="figcaption" />
</txp:if_yield>
</figure>
</txp:images>

I use this tag-in-tag method predominantly and didn’t notice 4.8.1 failing on my shortcodes.

Bloke · 2020-06-02 15:19:47

jakob wrote #323499:

Do you have any luck when you don’t use yield as an attribute of another tag?

Sadly not; same issue. As soon as you wrap anything in <txp:if_yield> the ‘else’ part returns 1 instead of the content of any tags.

colak · 2020-06-02 15:42:17

Bloke wrote #323501:

Sadly not; same issue. As soon as you wrap anything in <txp:if_yield> the ‘else’ part returns 1 instead of the content of any tags.

I cannot replicate this and I am using if_yield in many pages of our site. In this text for example, I use a short tag the form of which contains:

<txp:if_yield name="caption">
<figure<txp:if_yield name="class"> class="<txp:yield name="class" />"</txp:if_yield>>
<txp:image id='<txp:yield name="id" />' />
<figcaption class="grid_24"><txp:yield name="caption" escape="tidy,textile" /></figcaption>
</figure>
<txp:else />
<txp:image id='<txp:yield name="id" />'<txp:if_yield name="class"> class='<txp:yield name="class" />'</txp:if_yield> />
</txp:if_yield>

Bloke · 2020-06-02 15:53:39

I think it’s okay if you use <txp:if_yield> with an attribute. It just fails if you try to get the shortcode’s container. Thus a workaround to Vienuolis’ code is potentially:

<figure>
<txp:image yield="id" />
<txp:if_yield name="caption">
   <figcaption><txp:yield name="caption" escape="tidy,textile" /></figcaption>
<txp:else />
   <txp:image_info yield="id" wraptag="figcaption" escape="tidy,textile" />
</txp:if_yield>
</figure>

That just means the caption attribute has to be passed in via a shortcode attribute, instead of using the container to hold a custom caption.

Vienuolis · 2020-06-02 16:24:20

Yes, the caption is returned to figcaption, while name="caption" is included in txp:if_yield — thank you, Stef!

etc · 2020-06-02 18:04:14

What a buffoon I am! Line 534 of taghandlers.php should be

$yield[] = isset($thing) ? array($thing) : null;

There is no other way to fix it. I truly apologize.. :-(

Bloke · 2020-06-02 18:14:23

etc wrote #323507:

What a buffoon I am!

Haha! Don’t worry about it, and thanks for fixing it. My fault for mentioning the feature and not testing it thoroughly enough.

There’s a workaround for now, but we could squeeze 4.8.2 out in a week or two to patch this and anything else we spot. Won’t affect 4.9 work as that’s got its own branch (dev).

EDIT: though, annoyingly, when merging from 4.8.2 to dev, it pulls the version numbers from 4.8.2 and overwrites the dev ones. So with each merge we need to manually readjust textpattern/textpattern.js, textpattern/index.php and package.json. No biggie. Just something to be aware of. Quite why git thinks 4.9.0 is greater than 4.8.2 and splats the higher values instead of creating merge conflicts or figuring it out, I’m not sure. Maybe it’s a bug and I need to upgrade my local git environment. I’m running 2.8.1, which is way out of date.

Last edited by Bloke (2020-06-02 18:48:56)

whocarez · 2020-06-23 10:22:02

Updated three sites from 4.8.0 to 4.8.1 without any problem yet.

PHP version: 7.3.19-1+0~20200612.60+debian8~1.gbp6c8fe1
GD Graphics Library: 2.2.5; Supported formats: GIF, JPEG, PNG, WebP.
MySQL: 5.5.5-10.2.32-MariaDB-10.2.32+maria~jessie-log
Web server: nginx/1.16.1

Bloke · 2020-06-23 10:25:02

Brilliant, thanks @whocarez.

4.8.2 is shaping up nicely for imminent release too. Just mops up a few little issues we discovered, tweaks a couple of tags and enhances some stuff for a smoother ride with international users (see forum.textpattern.com/viewtopic.php?id=50806).

Textpattern CMS

Textpattern CMS support forum

#1 2020-05-31 06:14:11