Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#445 2020-03-04 15:45:32

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

etc wrote #322061:

It’s part of load-time optimizations (why have I ever touched it!)

:)

Try to call smd_tags_url_handler() function directly on plugin load (public-side) and set its load order to something lower than 5?

I think it already is called? I tried setting load order to 1: no change.

Hmmmm…

EDIT: Ah, you mean not as a callback? Okay, I’ll try that.

EDIT 2: Tried that. No change :(

Last edited by Bloke (2020-03-04 15:50:37)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#446 2020-03-04 17:04:48

etc
Developer
Registered: 2010-11-11
Posts: 4,545
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

I have no (previously) working smd/tru_tags install and have some troubles to set it up. Could someone send me admin credentials for plugin testing, preferably on a toy site?

Offline

#447 2020-03-04 17:18:56

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

etc wrote #322065:

I have no (previously) working smd/tru_tags install and have some troubles to set it up. Could someone send me admin credentials for plugin testing, preferably on a toy site?

Thank you. I’ll send you some over.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#448 2020-03-06 11:48:54

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

Thanks to Oleg’s fantastic assistance, he’s helped me patch the plugin to work with 4.8.0. This is only a bandaid and it’d be nice to do things properly via callback, without hijacking the URL first, but it works and will get people out of a hole until this can hopefully be addressed in Txp 4.8.1.

If you are able to take the GitHub master for a spin, please do so and verify it works. I’ll bundle up a proper release of the plugin later today.

Thank you for your patience, and sorry for the hassle.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#449 2020-03-06 13:51:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

Okay, version 0.7.0 released.

All users of Textpattern 4.7.0+ (and especially those on 4.8.0) please install this version to fix the URL handling bug and hopefully restore your tag filter pages.

Please let me know how you get on and if there are any further issues.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#450 2020-03-06 15:28:11

jayrope
Plugin Author
From: Berlin
Registered: 2006-07-06
Posts: 660
Website

Re: smd_tags: unlimited article, image, file and link taxonomy

I had the 404 error already with version 0.60 on 4.7.2 – unfortunately with 0.70 in 4.7.2 that error remains here. I can’t upgrade to 4.80 yet as i need glz_custom_fields momentarily, before those plugin features become core functionality.
I am also wondering if that error could as well be caused by certain php libraries not being active, that#s just guessing though, have no clear indication for anything missing.

Just FYI.


a hole turned upside down is a dome, when there’s also gravity.

Offline

#451 2020-03-06 23:33:49

michaelkpate
Moderator
From: Avon Park, FL
Registered: 2004-02-24
Posts: 1,372
Website GitHub Mastodon

Re: smd_tags: unlimited article, image, file and link taxonomy

Unfortunately, it isn’t working for me, either.

http://presidents.cmsstyles.com/smd_tags/article/orci


Textpattern version: 4.8.0 (3a700fa86044132fa6b97439de8272c7)
Last update: 2020-02-25 19:00:47/2020-02-25 18:59:16
Textpattern path: __TXP-ROOT/textpattern
Article URL pattern: section_id_title
Production status: debug
Temporary directory path: __TXP-ROOT/textpattern/tmp
PHP version: 7.4.3
GD Graphics Library: bundled (2.1.0 compatible); Supported formats: GIF, JPEG, PNG.
Server timezone: America/Los_Angeles
Server local time: 2020-03-06 15:21:15
Daylight Saving Time enabled?: 0
Automatically adjust Daylight Saving Time setting?: 1
Time zone (GMT offset in seconds): America/New_York (-18000)
MySQL: 5.7.28-log (Source distribution) 
Database server time: 2020-03-06 15:21:15
Database server time offset: 2 s
Database server timezone: SYSTEM
Database session timezone: SYSTEM
Locale: en_GB.UTF-8
Site / Admin language: en-gb / en-gb
Web server: Apache
PHP server API: cgi-fcgi
RFC 2616 headers: 0
Server OS: Linux 4.14.117-grsec-grsec+
Admin-side theme: hive 4.8.0
Active plugins: 
	com_connect-4.6.0
	csb_if_newer_than-1.0 (modified)
	etc_date-0.3
	pax_grep-0.2.3
	rah_replace-0.4.2
	smd_tags-0.7.0
	smd_thumbnail-0.5.3

Offline

#452 2020-03-07 10:22:25

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

Drat. This is weird. See, it works perfectly on a brand new install. Filters stuff like a charm. But I put it on my already populated dev environment and it 404d every time.

However, since my dev site is an utter mess and does odd things sometimes, I put it down to this and released the plugin anyway. Seems maybe that was premature.

Sorry for the false start. I’ll have to see if I can figure out what’s going on. Maybe between Oleg and I we can suss out what’s making it fail and fix the plugin and/or Txp.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#453 2020-03-07 13:27:39

saccade
Plugin Author
From: Neubeuern, Germany
Registered: 2004-11-05
Posts: 517

Re: smd_tags: unlimited article, image, file and link taxonomy

just for the record: also 404d every time.

Offline

#454 2020-04-04 21:41:21

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,186
Website

Re: smd_tags: unlimited article, image, file and link taxonomy

Also for the record with 0.7.0, the links generated by the plugin:

www.domain.com/triggersection/tagname -> 404
www.domain.com/triggersection/article/tagname -> 404

but messy links work:

www.domain.com/triggersection/?smd_tag=tagname -> works
www.domain.com/triggersection/?smd_tag_type=article&smd_tag=tagname -> works

where the trigger section is set up in txp and has no articles of its own.

One more info: with PHP 7.4.2 I get:

Error in Tag: <txp:smd_related_tags section="blog" type="article" wraptag="" break="" form="blog_listentry" /> -> Notice: Trying to access array offset on value of type null beim Verarbeiten des Bausteins Keine auf der Seitenvorlage default

but not with PHP 7.3.9.


TXP Builders – finely-crafted code, design and txp

Offline

#455 2020-04-04 23:36:26

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,562
Website GitHub

Re: smd_tags: unlimited article, image, file and link taxonomy

Right, thanks for the nudge. I need to find a fix for this somehow, between the plugin and Txp. Can’t figure out why it works okay on a brand new install and not on an existing site, both with bleeding edge -dev code. Weird. I’ll give it some kicking.

Also, do you happen to have more detail such as a plugin line number in debugging mode for the PHP 7.4.2 error? That sounds like something isn’t set and I should defend against it, but I’m unsure where to start looking. Thank you.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#456 2020-04-05 09:03:24

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,186
Website

Re: smd_tags: unlimited article, image, file and link taxonomy

Bloke wrote #322490:

Right, thanks for the nudge. I need to find a fix for this somehow, between the plugin and Txp. Can’t figure out why it works okay on a brand new install and not on an existing site, both with bleeding edge -dev code. Weird. I’ll give it some kicking.

Sorry. Is there any way to usefully compare the conditions of existing and new installations to see what differs?

Also, do you happen to have more detail such as a plugin line number in debugging mode for the PHP 7.4.2 error?

Yes, gargle shows that error message with other systems also in combination with PHP 7.4.2. The error message itself isn’t very informative:

smd_related_tags()
textpattern/vendors/Textpattern/Tag/Registry.php:141 call_user_func()
textpattern/lib/txplib_publish.php:541 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:447 processTags()
textpattern/plugins/smd_tags/smd_tags.php:3710 parse()
smd_if_tag_list()
textpattern/vendors/Textpattern/Tag/Registry.php:141 call_user_func()
textpattern/lib/txplib_publish.php:541 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:447 processTags()
textpattern/publish/taghandlers.php:4266 parse()

In tag trace it occurs directly after:

[smd_related_tags matches: tagname]

and before the SQL statement:

SQL: SELECT SQL_CALC_FOUND_ROWS txp.ID, Posted, Expires, AuthorID, LastMod, LastModID, txp.Title, Title_html, Body, Body_html, Excerpt, Excerpt_html, Image, Category1, Category2, Annotate, AnnotateInvite, comments_count, Status, textile_body, textile_excerpt, Section, override_form, Keywords, txp.description, url_title,custom_1,custom_2, uid, feed_time, unix_timestamp(Posted) as uPosted, unix_timestamp(LastMod) as uLastMod, unix_timestamp(Expires) as uExpires, COUNT(smt.name) as tag_sum FROM textpattern AS txp
                LEFT JOIN smd_tags_used AS tu ON txp.id = tu.item_id
                LEFT JOIN smd_tags AS smt ON tu.tag_id = smt.id
                WHERE tu.type = 'article' AND txp.Status IN (4) AND txp.id != "" AND txp.Section IN ('blog') AND smt.name IN ('tagname') GROUP BY txp.id ORDER BY Posted desc LIMIT 0,99999 ]

Thereafter the found rows are shown and put into [smd_related_tags article records: Array….

Not sure if that’s a great help. MAMP’s PHP log doesn’t list the error (I guess because it’s a notice).


TXP Builders – finely-crafted code, design and txp

Offline

Board footer

Powered by FluxBB