Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
gaekwad wrote #321715:
What can I do here to test that?
I think just visiting the Sections panel would do it. That uses json_encode() to handle the multi-edit Change Theme/Page/Style feature so if that function is missing, the page’ll probably blow up. According to the docs, JSON is installed by default in 5.2.0+ so I’d be interested to know which bits aren’t installed in your Canonical environment.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
I’ve added some defensive code around SimpleXML which should at least stop the errors flying, but if you run /setup in such an environment, it’ll not populate any content and your front-end will report Unknown Section. Your pophelp will also either return the name of the field or ‘Help topic not available’ as it won’t be able to load the XML files.
Now, an easier check might be to simply add this as a requirement to the assert_system_requirements() function so it’ll just unceremoniously STOP if you don’t have it installed. That means if you install or upgrade to 4.8.0 and you don’t happen to have it on your server, you’ll get a white screen and message to install it before you can do anything else on the admin side.
What’s everyone’s feeling on this drastic measure versus what I’ve done here?
Last edited by Bloke (2020-02-17 17:18:01)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Bloke wrote #321716:
I think just visiting the Sections panel would do it. That uses
json_encode()to handle the multi-edit Change Theme/Page/Style feature so if that function is missing, the page’ll probably blow up.
Haven’t got Textpattern installed (no XML support, so haven’t tried). Presumably any PHP code using json_encode() would do the trick, right?
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
gaekwad wrote #321718:
Haven’t got Textpattern installed (no XML support, so haven’t tried). Presumably any PHP code using
json_encode()would do the trick, right?
Yep, if that’s one of the functions that’s missing when you reported No JSON support above.
If that function works, but there are other facets of JSON that don’t work, then we might get away with it.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Bloke wrote #321719:
Yep, if that’s one of the functions that’s missing when you reported No JSON support above.
More testing underway. I’ll report back.
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Bloke wrote #321714:
Wait, so that means the
json_encode()function is missing?
I was wrong – rechecked and it’s there. No idea how that slipped through – sorry about that. The command line php -i doesn’t seem to tally with the phpinfo() output.
Screengrab of phpinfo(): i.imgur.com/u1GBCCw.png (warning: is long)
SimpleXML does not appear in phpinfo().
Edit: running apt install php-xml adds SimpleXML support.
Last edited by gaekwad (2020-02-17 17:58:37)
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
gaekwad wrote #321721:
The command line
php -idoesn’t seem to tally with thephpinfo()output.
That’s cool. So we only need to decide if we should forbid any interaction with Txp if SimpleXML is missing, or if we let it limp along and report it in Diagnostics. For the latter, the fallout would be:
- No default content on fresh installs. No Sections, Categories, Links, or welcome article. Thus, first experience when viewing the public site is a white screen with ‘Unknown section’.
- No pophelp topics. Any clicks on ‘?’ will result in either the raw help string being displayed (if it exists in the database – quite a few match the string name, so fall into this camp) or the ‘Help text is missing’ message.
A halfway-house approach might be to permit installation to continue, but display a warning somewhere that no default content will be installed. Downside: that will require a new translation string in setup (and maybe a new string in Diagnostics, although we might be able to hijack one of the existing ones there).
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
…or we leave core as-is and add SimpleXML to the sys reqs. It’s a very rare issue, few reports in here, and in the case of Debian-derived hosting it can be added trivially via php-xml.
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
I have hit on what seems to be quite an issue. Automatic thumbnail generation stopped working. Also, the initial crop options disappeared and no thumbnail preferences are loaded.
screenshot below:
Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Also, I am using rah_privileges and I just noticed a new option.
Image › can upload ‘unsafe’ image types
This option seems to be unticked for everyone and it is the first time I noticed it. What I’m not sure of is what the “‘unsafe’ image types” might be, and if it is for real, why do we not have an official preference for it? :)
Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
colak wrote #321725:
what the ‘unsafe’ image types might be.
.swf primarily.
gaekwad wrote #321723:
we leave core as-is and add SimpleXML to the sys reqs.
That is an option, but I generally dislike error messages flying when we can easily trap them for people that don’t read the requirements closely. We already trap the PHP version and bail out if it’s not met. If we’re going to add SimpleXML as a required system component, we should trap that too and bail out immediately, imo.
Last edited by Bloke (2020-02-17 20:42:24)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
colak wrote #321724:
I have hit on what seems to be quite an issue. Automatic thumbnail generation stopped working. Also, the initial crop options disappeared and no thumbnail preferences are loaded.
On your own site? Please supply additional info/diagnostics if so. If it’s the demo site then that’s by design as the image dir is not writable.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Bloke wrote #321728:
On your own site? Please supply additional info/diagnostics if so. If it’s the demo site then that’s by design as the image dir is not writable.
On my dev site online.
here is the diagnostics
Textpattern version: 4.8.0-beta.3 (ae7254dae95d82b81cd8059433879a54)
Last update: 2020-02-14 16:29:04/2020-02-14 16:25:25
Textpattern path: __TXP-ROOT/textpattern
Article URL pattern: section_category_title
Production status: live
Temporary directory path: /home/colak/tmp
PHP version: 7.4.2
GD Graphics Library: bundled (2.1.0 compatible); Supported formats: GIF, PNG.
Server timezone: UTC
Server local time: 2020-02-17 20:49:01
Daylight Saving Time enabled?: 0
Automatically adjust Daylight Saving Time setting?: 0
Time zone (GMT offset in seconds): Asia/Nicosia (7200)
MySQL: 5.6.46-86.2 (Percona Server (GPL), Release 86.2, Revision 5e33e07)
Database server time: 2020-02-17 20:49:01
Database server time offset: 0 s
Database server timezone: SYSTEM
Database session timezone: SYSTEM
Locale: en_GB.UTF-8
Site / Admin language: en-gb / en-gb
Web server: Apache
PHP server API: cgi-fcgi
RFC 2616 headers: 0
Server OS: Linux 3.10.0-1062.9.1.el7.x86_64
Admin-side theme: hive 4.8.0-beta.3
Active plugins:
act_if_mobile-0.1.2 (modified)
adi_matrix-2.1beta5
adi_notes-1.4beta4
com_connect-4.6.0-beta.3
etc_query-1.3.3
ext_com_connect_verify-0.1 (modified)
ext_file_attach-1.0.3
fha_time_diff-0.23 (modified)
ied_plugin_composer-1.2.1
oui_cookie-1.0.0-BETA3
pap_comconnect-0.1.2 (modified)
pat_speeder-1.1
rah_external_output-1.0.4
rah_privileges-0.2
rss_admin_db_manager-4.5.1
smd_tabber-0.11
smd_where_used-0.2
wet_opensearch-0.1
.htaccess file contents:
------------------------
...
------------------------I can send you an invite should you wish to investigate it.
Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
colak wrote #321729:
I can send you an invite should you wish to investigate it.
Yes please. We didn’t change anything image-related between beta 2 and 3 so this is perplexing.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released
Reading through these instructions from Digital Ocean, they recommend running
$ sudo apt install php-curl php-gd php-mbstring php-xml php-xmlrpc php-soap php-intl php-zip“download and install some of the more popular PHP extensions for use with WordPress.”
Offline